Skip to content

Commit d3e9071

Browse files
perf(web): useMediaQuery compiles without manual memoization
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 70d60e0 commit d3e9071

2 files changed

Lines changed: 11 additions & 13 deletions

File tree

‎apps/web/reactCompiledFiles.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,4 +96,5 @@ export const REACT_COMPILED_FILES = [
9696
"apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx",
9797
"apps/web/src/components/ThreadTerminalDrawer.tsx",
9898
"apps/web/src/components/settings/SettingsPanels.tsx",
99+
"apps/web/src/hooks/useMediaQuery.ts",
99100
] as const;

‎apps/web/src/hooks/useMediaQuery.ts‎

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { useCallback, useSyncExternalStore } from "react";
1+
import { useSyncExternalStore } from "react";
22

33
const BREAKPOINTS = {
44
"2xl": 1536,
@@ -63,20 +63,17 @@ export type MediaQueryInput = {
6363
export function useMediaQuery(query: BreakpointQuery | MediaQueryInput | (string & {})): boolean {
6464
const mediaQuery = parseQuery(query);
6565

66-
const subscribe = useCallback(
67-
(callback: () => void) => {
68-
if (typeof window === "undefined") return () => {};
69-
const mql = window.matchMedia(mediaQuery);
70-
mql.addEventListener("change", callback);
71-
return () => mql.removeEventListener("change", callback);
72-
},
73-
[mediaQuery],
74-
);
75-
76-
const getSnapshot = useCallback(() => {
66+
const subscribe = (callback: () => void) => {
67+
if (typeof window === "undefined") return () => {};
68+
const mql = window.matchMedia(mediaQuery);
69+
mql.addEventListener("change", callback);
70+
return () => mql.removeEventListener("change", callback);
71+
};
72+
73+
const getSnapshot = () => {
7774
if (typeof window === "undefined") return false;
7875
return window.matchMedia(mediaQuery).matches;
79-
}, [mediaQuery]);
76+
};
8077

8178
return useSyncExternalStore(subscribe, getSnapshot, getServerSnapshot);
8279
}

0 commit comments

Comments
 (0)