@@ -1034,11 +1034,6 @@ export function rankPullRequestsByMergeReadiness<Entry extends PullRequestListEn
10341034 } ) ;
10351035}
10361036
1037- /**
1038- * Rows in tier order, newest activity first inside each tier. Recent work is what the reader has
1039- * in their head, so the row they just pushed outranks a month-old one in the same trouble; the
1040- * Oldest sort is there for the forgotten ones. Rows with no readable timestamp trail their tier.
1041- */
10421037function rankByTierThenRecency < Entry extends PullRequestListEntry > (
10431038 entries : ReadonlyArray < Entry > ,
10441039 tier : ( entry : Entry ) => number ,
@@ -1056,15 +1051,6 @@ function rankByTierThenRecency<Entry extends PullRequestListEntry>(
10561051 } ) ;
10571052}
10581053
1059- /**
1060- * The contributor's queue over their own work, most certainly theirs to unblock first: a conflict
1061- * only they can resolve, then a reviewer's request for changes, then a red check (which may yet
1062- * be flaky), then their drafts, then what is waiting on someone else, then what is approved and
1063- * green. That last tier is nobody's blocker — and whether the reader may merge it is not
1064- * something a row knows — so a reader hunting for it wants "Merge readiness" instead. A host that
1065- * reports no verdict or check rollup lands in the waiting tier rather than a fixing one. Finished
1066- * work follows everything open.
1067- */
10681054export function rankPullRequestsBlockedOnAuthor < Entry extends PullRequestListEntry > (
10691055 entries : ReadonlyArray < Entry > ,
10701056) : ReadonlyArray < Entry > {
@@ -1079,21 +1065,13 @@ export function rankPullRequestsBlockedOnAuthor<Entry extends PullRequestListEnt
10791065 } ) ;
10801066}
10811067
1082- /**
1083- * The reviewer's queue over reviews asked of them: every open request, newest activity first,
1084- * then finished work.
1085- */
10861068export function rankPullRequestsBlockedOnReviewer < Entry extends PullRequestListEntry > (
10871069 entries : ReadonlyArray < Entry > ,
10881070) : ReadonlyArray < Entry > {
10891071 return rankByTierThenRecency ( entries , ( entry ) => ( entry . state === "open" ? 0 : 1 ) ) ;
10901072}
10911073
1092- /**
1093- * Keeps authored work first while applying the selected ordering inside every involvement group.
1094- * "Blocked on me" ranks each group by the reader's role in it, and reads that role off
1095- * `involvement` when the page has collapsed to a single unlabeled group.
1096- */
1074+ /** Keeps authored work first while applying the selected ordering inside every involvement group. */
10971075export function sortPullRequestGroups < Entry extends PullRequestListEntry > (
10981076 groups : ReadonlyArray < PullRequestGroup < Entry > > ,
10991077 sort : PullRequestListSort ,
@@ -1111,8 +1089,6 @@ export function sortPullRequestGroups<Entry extends PullRequestListEntry>(
11111089 }
11121090 if ( sort === "blocked" ) {
11131091 if ( searchText . trim ( ) . length > 0 ) return groups ;
1114- // The reader's role in a group: its own key, or the involvement filter for the lone
1115- // unlabeled group the page shows when one involvement is selected.
11161092 const role = ( key : PullRequestGroupKey ) =>
11171093 key === "others" ? involvement : key === "authored" ? "authored" : "reviewing" ;
11181094 return groups . map ( ( group ) => {
0 commit comments