Skip to content

Commit d2b73d5

Browse files
perf(web): the composer state hooks compile without manual memoization
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent a702563 commit d2b73d5

3 files changed

Lines changed: 24 additions & 27 deletions

File tree

‎apps/web/src/components/chat/useComposerFocusState.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
import { useCallback, useState } from "react";
1+
import { useState } from "react";
22

33
export function useComposerFocusState() {
44
const [isComposerFocused, setIsComposerFocused] = useState(false);
55
const [isComposerScrollCollapsed, setIsComposerScrollCollapsed] = useState(false);
66

7-
const restoreAfterTimelineReachedEnd = useCallback(() => {
7+
const restoreAfterTimelineReachedEnd = () => {
88
setIsComposerScrollCollapsed(false);
9-
}, []);
9+
};
1010

1111
return {
1212
isComposerFocused,
Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,38 @@
1-
import { useCallback, useRef, useState } from "react";
1+
import { useRef, useState } from "react";
22

33
import type { ComposerTrigger } from "../../composer-logic";
44

55
export function useComposerTriggerState(initialTrigger: () => ComposerTrigger | null) {
66
const [trigger, setActiveTrigger] = useState(initialTrigger);
77
const dismissedTriggerRef = useRef<ComposerTrigger | null>(null);
88

9-
const resolveTrigger = useCallback((candidate: ComposerTrigger | null) => {
9+
const resolveTrigger = (candidate: ComposerTrigger | null) => {
1010
const dismissed = dismissedTriggerRef.current;
1111
return candidate &&
1212
dismissed &&
1313
candidate.kind === dismissed.kind &&
1414
candidate.rangeStart === dismissed.rangeStart
1515
? null
1616
: candidate;
17-
}, []);
17+
};
1818

19-
const setTrigger = useCallback(
20-
(candidate: ComposerTrigger | null) => {
21-
const activeTrigger = resolveTrigger(candidate);
22-
if (candidate === null || activeTrigger !== null) {
23-
dismissedTriggerRef.current = null;
24-
}
25-
setActiveTrigger(activeTrigger);
26-
},
27-
[resolveTrigger],
28-
);
19+
const setTrigger = (candidate: ComposerTrigger | null) => {
20+
const activeTrigger = resolveTrigger(candidate);
21+
if (candidate === null || activeTrigger !== null) {
22+
dismissedTriggerRef.current = null;
23+
}
24+
setActiveTrigger(activeTrigger);
25+
};
2926

30-
const dismissTrigger = useCallback((candidate: ComposerTrigger | null) => {
27+
const dismissTrigger = (candidate: ComposerTrigger | null) => {
3128
dismissedTriggerRef.current = candidate;
3229
setActiveTrigger(null);
33-
}, []);
30+
};
3431

35-
const resetTrigger = useCallback((candidate: ComposerTrigger | null) => {
32+
const resetTrigger = (candidate: ComposerTrigger | null) => {
3633
dismissedTriggerRef.current = null;
3734
setActiveTrigger(candidate);
38-
}, []);
35+
};
3936

4037
return { trigger, setTrigger, resolveTrigger, dismissTrigger, resetTrigger };
4138
}

‎apps/web/src/components/chat/useComposerTypingGuard.ts‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { useCallback, useEffect, useState } from "react";
1+
import { useEffect, useState } from "react";
22
import {
33
COMPOSER_TYPING_IDLE_MS,
44
createComposerTypingGuardState,
@@ -29,16 +29,16 @@ export function useComposerTypingGuard(scope: string, requestIds: readonly strin
2929
),
3030
}));
3131
}
32-
const dispatch = useCallback((event: Parameters<typeof updateComposerTypingGuard>[1]) => {
32+
const dispatch = (event: Parameters<typeof updateComposerTypingGuard>[1]) => {
3333
setSnapshot((current) => ({
3434
...current,
3535
state: updateComposerTypingGuard(current.state, event),
3636
}));
37-
}, []);
38-
const onDraftChange = useCallback(() => dispatch({ type: "type", now: Date.now() }), [dispatch]);
39-
const onFocus = useCallback(() => dispatch({ type: "focus" }), [dispatch]);
40-
const onBlur = useCallback(() => dispatch({ type: "blur" }), [dispatch]);
41-
const onSend = useCallback(() => dispatch({ type: "send" }), [dispatch]);
37+
};
38+
const onDraftChange = () => dispatch({ type: "type", now: Date.now() });
39+
const onFocus = () => dispatch({ type: "focus" });
40+
const onBlur = () => dispatch({ type: "blur" });
41+
const onSend = () => dispatch({ type: "send" });
4242
useEffect(() => {
4343
if (state.held.size === 0) return;
4444
const timeout = window.setTimeout(

0 commit comments

Comments
 (0)