Skip to content

Commit d210cfb

Browse files
perf(server): storage checks read page size and vacuum mode once
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 38ec081 commit d210cfb

1 file changed

Lines changed: 18 additions & 6 deletions

File tree

‎apps/server/src/persistence/DatabaseStorage.ts‎

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,17 +49,30 @@ const make = Effect.gen(function* () {
4949
const doctorTargetsThisDatabase =
5050
path.resolve(config.dbPath) ===
5151
path.resolve(config.baseDir, "userdata", path.basename(config.dbPath));
52+
// Only VACUUM changes these, and doctor refuses to VACUUM while a server has the database open.
53+
let layout: { readonly pageSize: number; readonly incrementalVacuum: boolean } | undefined;
54+
const readLayout = Effect.suspend(() =>
55+
layout !== undefined
56+
? Effect.succeed(layout)
57+
: Effect.gen(function* () {
58+
const size = yield* sql<{ readonly page_size: number }>`PRAGMA page_size`;
59+
const mode = yield* sql<{ readonly auto_vacuum: number }>`PRAGMA auto_vacuum`;
60+
layout = {
61+
pageSize: size[0]?.page_size ?? 0,
62+
incrementalVacuum: mode[0]?.auto_vacuum === 2,
63+
};
64+
return layout;
65+
}),
66+
);
5267
const publishStatus = Effect.gen(function* () {
5368
if (!doctorTargetsThisDatabase) return;
69+
const { pageSize, incrementalVacuum } = yield* readLayout;
5470
const pages = yield* sql<{ readonly page_count: number }>`PRAGMA page_count`;
5571
const free = yield* sql<{ readonly freelist_count: number }>`PRAGMA freelist_count`;
56-
const size = yield* sql<{ readonly page_size: number }>`PRAGMA page_size`;
57-
const mode = yield* sql<{ readonly auto_vacuum: number }>`PRAGMA auto_vacuum`;
58-
const pageSize = size[0]?.page_size ?? 0;
5972
const next: DatabaseStorageStatus = {
6073
databaseBytes: (pages[0]?.page_count ?? 0) * pageSize,
6174
reclaimableBytes: (free[0]?.freelist_count ?? 0) * pageSize,
62-
incrementalVacuumEnabled: mode[0]?.auto_vacuum === 2,
75+
incrementalVacuumEnabled: incrementalVacuum,
6376
compactCommand,
6477
};
6578
// Every set reaches each open Storage page; most passes change nothing.
@@ -71,8 +84,7 @@ const make = Effect.gen(function* () {
7184
);
7285

7386
const reclaim = Effect.gen(function* () {
74-
const mode = yield* sql<{ readonly auto_vacuum: number }>`PRAGMA auto_vacuum`;
75-
if (mode[0]?.auto_vacuum !== 2) return;
87+
if (!(yield* readLayout).incrementalVacuum) return;
7688
// The driver steps once per statement; incremental_vacuum frees one page per step. Yield between pages.
7789
for (let page = 0; page < RECLAIM_PAGES_PER_PASS; page++) {
7890
const free = yield* sql<{ readonly freelist_count: number }>`PRAGMA freelist_count`;

0 commit comments

Comments
 (0)