Skip to content

Commit d0ade67

Browse files
fix(azure-devops): keep PR previews readable without build checks
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent a4cdee5 commit d0ade67

2 files changed

Lines changed: 52 additions & 0 deletions

File tree

‎packages/source-control-azure-devops/src/server/AzureDevOpsPullRequestProvider.test.ts‎

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,43 @@ describe("getChangeRequest", () => {
192192
);
193193
});
194194

195+
describe("getChangeRequestPreview", () => {
196+
it.effect("stays readable when build checks are not", () =>
197+
Effect.gen(function* () {
198+
const provider = yield* make.pipe(
199+
Effect.provide(
200+
Layer.mock(AzureDevOpsPullRequestCli.AzureDevOpsPullRequestCli)({
201+
getPullRequest: () => Effect.succeed(PULL_REQUEST),
202+
listBuildChecks: () =>
203+
Effect.fail(
204+
new AzureDevOpsPullRequestCli.AzureDevOpsPullRequestReadError({
205+
command: "az",
206+
cwd: "/w",
207+
operation: "listBuildChecks",
208+
cause: "policy read denied",
209+
}),
210+
),
211+
}),
212+
),
213+
);
214+
const input = { cwd: "/w", repository: "acme/web", host: "dev.azure.com", number: 7 };
215+
216+
const preview = yield* provider.getChangeRequestPreview!(input);
217+
expect(preview).toEqual({
218+
number: 7,
219+
title: "Pull request 7",
220+
url: PULL_REQUEST.url,
221+
author: null,
222+
state: "open",
223+
isDraft: false,
224+
createdAt: PULL_REQUEST.createdAt,
225+
});
226+
const detail = yield* Effect.flip(provider.getChangeRequest(input));
227+
expect(detail._tag).toBe("PullRequestProviderError");
228+
}),
229+
);
230+
});
231+
195232
describe("getDiff reads", () => {
196233
it.effect("holds every reader together to one request's worth of processes", () =>
197234
Effect.gen(function* () {

‎packages/source-control-azure-devops/src/server/AzureDevOpsPullRequestProvider.ts‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,21 @@ export const make = Effect.gen(function* () {
318318
})),
319319
),
320320

321+
// Previews show no checks, so they skip the policy reads that full detail fails closed on.
322+
getChangeRequestPreview: (input) =>
323+
cli.getPullRequest({ cwd: input.cwd, number: input.number }).pipe(
324+
Effect.mapError(fail("getChangeRequestPreview")),
325+
Effect.map((pullRequest) => ({
326+
number: pullRequest.number,
327+
title: pullRequest.title,
328+
url: pullRequest.url,
329+
author: pullRequest.author,
330+
state: pullRequest.state,
331+
isDraft: pullRequest.isDraft,
332+
createdAt: pullRequest.createdAt,
333+
})),
334+
),
335+
321336
getChangeRequest: Effect.fn("AzureDevOpsPullRequestProvider.getChangeRequest")(
322337
function* (input) {
323338
const pullRequest = yield* cli.getPullRequest({ cwd: input.cwd, number: input.number });

0 commit comments

Comments
 (0)