Skip to content

Commit d0310e7

Browse files
t3dotggclaude
andcommitted
fix(server): Grok refresh no longer restores removed models from cache
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 066c8fc commit d0310e7

2 files changed

Lines changed: 44 additions & 0 deletions

File tree

‎apps/server/src/provider/ProviderRegistry.test.ts‎

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -687,6 +687,44 @@ it.layer(
687687
);
688688
});
689689

690+
it("drops Grok models a completed probe no longer advertises", () => {
691+
const previousProvider = {
692+
instanceId: ProviderInstanceId.make("grok"),
693+
driver: ProviderDriverKind.make("grok"),
694+
status: "ready",
695+
enabled: true,
696+
installed: true,
697+
auth: { status: "authenticated" },
698+
checkedAt: "2026-09-30T00:00:00.000Z",
699+
version: "1.0.44",
700+
models: [
701+
{ slug: "grok-4.7", name: "Grok 4.7", isCustom: false, capabilities: null },
702+
{ slug: "codexhub-removed", name: "Removed", isCustom: false, capabilities: null },
703+
],
704+
slashCommands: [],
705+
skills: [],
706+
} as const satisfies ServerProvider;
707+
const refreshedProvider = {
708+
...previousProvider,
709+
checkedAt: "2026-09-30T00:01:00.000Z",
710+
models: [previousProvider.models[0]],
711+
} satisfies ServerProvider;
712+
const acpFailedProvider = {
713+
...refreshedProvider,
714+
status: "warning",
715+
message: "Grok CLI is installed but ACP initialize failed.",
716+
} satisfies ServerProvider;
717+
718+
assert.deepStrictEqual(
719+
ProviderRegistry.mergeProviderSnapshot(previousProvider, refreshedProvider).models,
720+
[previousProvider.models[0]],
721+
);
722+
assert.deepStrictEqual(
723+
ProviderRegistry.mergeProviderSnapshot(previousProvider, acpFailedProvider).models,
724+
[...previousProvider.models],
725+
);
726+
});
727+
690728
it("retains stale OpenCode models when a refresh fails", () => {
691729
const previousProvider = {
692730
instanceId: ProviderInstanceId.make("opencode"),

‎apps/server/src/provider/ProviderRegistry.ts‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,12 @@ const shouldRetainMissingProviderModels = (provider: ServerProvider): boolean =>
179179
);
180180
}
181181

182+
if (provider.driver === ProviderDriverKind.make("grok")) {
183+
// Grok reports ready only after ACP initialize returns its model list; the
184+
// pending, ACP-failed, and logged-out probes are warning/error.
185+
return !(provider.installed && provider.status === "ready");
186+
}
187+
182188
const isAntigravity = provider.driver === ProviderDriverKind.make("antigravity");
183189
const isCodex = provider.driver === ProviderDriverKind.make("codex");
184190
if (!isAntigravity && !isCodex && provider.driver !== ProviderDriverKind.make("opencode")) {

0 commit comments

Comments
 (0)