Skip to content

Commit cf82199

Browse files
sheehanmunimclaudeYash-Singh1
authored
test(server): ACP teardown tests pass on Windows hosts (#17080)
Co-authored-by: Claude Opus 5.5 <[email protected]> Co-authored-by: Yash Singh <[email protected]>
1 parent 7808950 commit cf82199

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

‎apps/server/src/orchestration-v2/Adapters/AcpAdapterV2.test.ts‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12316,7 +12316,11 @@ describe("AcpAdapterV2", () => {
1231612316
});
1231712317
assert.equal(taskkillCommands.length, 1);
1231812318
yield* Scope.close(runtimeScope, Exit.void);
12319-
assert.equal(taskkillCommands.length, 1);
12319+
// The scope finalizer picks its kill path from the host, not processGroupPlatform,
12320+
// so only a Windows host sends it through taskkill a second time.
12321+
const finalizerTaskkills = (yield* HostProcess.Platform) === "win32" ? 1 : 0;
12322+
assert.equal(taskkillCommands.length, 1 + finalizerTaskkills);
12323+
assert.deepEqual(taskkillCommands.at(-1), taskkillCommands[0]);
1232012324
}).pipe(Effect.provide(layerTest)),
1232112325
);
1232212326

@@ -12433,6 +12437,7 @@ describe("AcpAdapterV2", () => {
1243312437

1243412438
it.live("poisons the session when hard teardown defects and blocks replacement work", () =>
1243512439
Effect.gen(function* () {
12440+
if ((yield* HostProcess.Platform) !== "linux") return;
1243612441
const childProcessSpawner = yield* ChildProcessSpawner.ChildProcessSpawner;
1243712442
const fileSystem = yield* FileSystem.FileSystem;
1243812443
const idAllocator = yield* IdAllocator.IdAllocatorV2;

0 commit comments

Comments
 (0)