Skip to content

Commit cf247b9

Browse files
committed
fix(web): align maintainer edits with PR menu actions
1 parent 651dacf commit cf247b9

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

‎apps/web/src/components/pullRequest/PullRequestActionsMenu.tsx‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,7 @@ export function PullRequestActionsMenu({
288288
{canEditPullRequestMaintainerEdits(detail) ? (
289289
<>
290290
<MenuCheckboxItem
291+
variant="icon"
291292
checked={maintainerCanModify === true}
292293
disabled={!canSaveMaintainerEdits}
293294
closeOnClick={false}

‎apps/web/src/components/ui/menu.tsx‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ function MenuCheckboxItem({
163163
variant = "default",
164164
...props
165165
}: MenuPrimitive.CheckboxItem.Props & {
166-
variant?: "default" | "switch";
166+
variant?: "default" | "icon" | "switch";
167167
}) {
168168
return (
169169
<MenuPrimitive.CheckboxItem
@@ -173,6 +173,7 @@ function MenuCheckboxItem({
173173
variant === "switch"
174174
? "grid-cols-[1fr_auto] gap-4 pe-1.5"
175175
: "grid-cols-[1rem_minmax(0,1fr)] pe-4",
176+
variant === "icon" && "grid-cols-[0.625rem_minmax(0,1fr)]",
176177
className,
177178
)}
178179
data-slot="menu-checkbox-item"
@@ -190,8 +191,11 @@ function MenuCheckboxItem({
190191
</>
191192
) : (
192193
<>
193-
<MenuPrimitive.CheckboxItemIndicator className="col-start-1">
194+
<MenuPrimitive.CheckboxItemIndicator
195+
className={cn("col-start-1", variant === "icon" && "-mx-0.5")}
196+
>
194197
<svg
198+
className={variant === "icon" ? "size-3.5" : undefined}
195199
fill="none"
196200
height="24"
197201
stroke="currentColor"

0 commit comments

Comments
 (0)