Skip to content

Commit cea5473

Browse files
Bil0000claude
andcommitted
fix(web): reset server paging when switching threads
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent d6a8a6c commit cea5473

2 files changed

Lines changed: 32 additions & 12 deletions

File tree

‎apps/web/src/components/chat/ThreadServersPanel.browser.test.tsx‎

Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,31 @@ vi.mock(import("../../portDiscoveryState"), async (importOriginal) => ({
2121
import { render } from "../../../test/render";
2222
import { ThreadServersPanel } from "./ThreadServersPanel";
2323

24-
it("pages servers four at a time and collapses back", async () => {
25-
await using screen = await render(
26-
<ThreadServersPanel environmentId={EnvironmentId.make("env")} threadId={ThreadId.make("t")} />,
27-
);
28-
const rows = () => screen.container.querySelectorAll("li").length;
24+
const panel = (threadId: string) => (
25+
<ThreadServersPanel
26+
environmentId={EnvironmentId.make("env")}
27+
threadId={ThreadId.make(threadId)}
28+
/>
29+
);
2930

30-
expect(rows()).toBe(4);
31+
it("pages servers four at a time, collapses back, and resets on thread switch", async () => {
32+
await using screen = await render(panel("a"));
33+
const count = (selector: string) => screen.container.querySelectorAll(selector).length;
34+
const expectRows = (rows: number) => vi.waitFor(() => expect(count("li")).toBe(rows));
35+
36+
await expectRows(4);
3137
await page.getByRole("button", { name: "Show 4 more" }).click();
32-
expect(rows()).toBe(8);
38+
await expectRows(8);
39+
expect(count("[data-thread-details-server-overflow]")).toBe(4);
3340
await page.getByRole("button", { name: "Show 2 more" }).click();
34-
expect(rows()).toBe(10);
41+
await expectRows(10);
3542
await page.getByRole("button", { name: "Show less" }).click();
36-
expect(rows()).toBe(4);
43+
await expectRows(4);
44+
45+
await page.getByRole("button", { name: "Show 4 more" }).click();
46+
await expectRows(8);
47+
await screen.rerender(panel("b"));
48+
await expectRows(4);
49+
await screen.rerender(panel("a"));
50+
await expectRows(4);
3751
});

‎apps/web/src/components/chat/ThreadServersPanel.tsx‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,17 @@ const SERVER_PAGE_COUNT = 4;
3434

3535
const serverKey = (server: DiscoveredLocalServer) => `${server.pid}:${server.port}`;
3636

37-
/** Local servers the thread's terminals and agent started. Hidden while none run. */
38-
export function ThreadServersPanel(props: {
37+
interface ThreadServersPanelProps {
3938
readonly environmentId: EnvironmentId;
4039
readonly threadId: ThreadId;
41-
}) {
40+
}
41+
42+
/** Local servers the thread's terminals and agent started. Hidden while none run. */
43+
export function ThreadServersPanel(props: ThreadServersPanelProps) {
44+
return <ThreadServersList key={`${props.environmentId}:${props.threadId}`} {...props} />;
45+
}
46+
47+
function ThreadServersList(props: ThreadServersPanelProps) {
4248
const servers = useThreadDiscoveredPorts(props);
4349
const canOpen = useEnvironmentScope(props.environmentId, AuthPreviewOperateScope);
4450
const canStop = useAtomValue(

0 commit comments

Comments
 (0)