Skip to content

Commit cc50042

Browse files
fix(codex): image items identified by fileId are no longer dropped
Codex now reports a generated image either by inline `result` or by `fileId`. The schema generated from the pinned protocol still required `result`, so the whole notification failed to decode and was dropped, losing the image's saved path. Patch the imageGeneration ThreadItem variant in the generator to accept `fileId` and make `result` optional. Fixes #35851 Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent a17f170 commit cc50042

2 files changed

Lines changed: 101 additions & 37 deletions

File tree

‎packages/effect-codex-app-server/scripts/generate.ts‎

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,32 @@ function openStringEnum(schema: Schema.Json): Schema.Json {
186186
};
187187
}
188188

189+
// Newer Codex identifies a generated image by `fileId` and omits the inline `result`.
190+
// Requiring `result` fails the whole notification decode and drops the finished image.
191+
function acceptImageFileIds(schema: Schema.Json): Schema.Json {
192+
if (!isJsonSchemaNode(schema) || !Array.isArray(schema.oneOf)) return schema;
193+
return {
194+
...schema,
195+
oneOf: schema.oneOf.map((variant: Schema.Json) => {
196+
if (
197+
!isJsonSchemaNode(variant) ||
198+
!isJsonSchemaNode(variant.properties) ||
199+
!isJsonSchemaNode(variant.properties.type) ||
200+
!Array.isArray(variant.properties.type.enum) ||
201+
!variant.properties.type.enum.includes("imageGeneration") ||
202+
!Array.isArray(variant.required)
203+
) {
204+
return variant;
205+
}
206+
return {
207+
...variant,
208+
properties: { ...variant.properties, fileId: { type: "string" } },
209+
required: variant.required.filter((key: Schema.Json) => key !== "result"),
210+
};
211+
}),
212+
};
213+
}
214+
189215
const getGeneratedPaths = Effect.fn("getGeneratedPaths")(function* () {
190216
const path = yield* Path.Path;
191217
const generatedDir = path.join(import.meta.dirname, "..", "src", "_generated");
@@ -682,7 +708,9 @@ const generateFiles = Effect.fn("generateFiles")(function* () {
682708
DefinitionOverrides[definitionName] ??
683709
(OpenStringEnumDefinitions.has(definitionName)
684710
? openStringEnum(definitionSchema)
685-
: definitionSchema),
711+
: definitionName === "ThreadItem"
712+
? acceptImageFileIds(definitionSchema)
713+
: definitionSchema),
686714
localDefinitionNames,
687715
file.namespace,
688716
exportNameByQualifiedName,

0 commit comments

Comments
 (0)