@@ -190,47 +190,6 @@ describe("observability", () => {
190190 } ) . pipe ( Effect . provide ( NodeServices . layer ) ) ,
191191 ) ;
192192
193- it . effect ( "redacts WebSocket credentials from recorded and exported URLs" , ( ) =>
194- Effect . gen ( function * ( ) {
195- const delegates : Array < Tracer . NativeSpan > = [ ] ;
196- const records : Array < EffectTraceRecord > = [ ] ;
197- const tracer = yield * makeLocalFileTracer ( {
198- filePath : "unused" ,
199- maxBytes : 1024 ,
200- maxFiles : 1 ,
201- batchWindowMs : 10_000 ,
202- sink : {
203- filePath : "unused" ,
204- push : ( record ) => {
205- if ( record . type === "effect-span" ) records . push ( record ) ;
206- } ,
207- flush : Effect . void ,
208- close : ( ) => Effect . void ,
209- } ,
210- delegate : Tracer . make ( {
211- span : ( options ) => {
212- const span = new Tracer . NativeSpan ( options ) ;
213- delegates . push ( span ) ;
214- return span ;
215- } ,
216- } ) ,
217- } ) ;
218- yield * Effect . annotateCurrentSpan ( {
219- "url.full" : "http://127.0.0.1:3773/ws?wsTicket=ticket-secret&clientSurface=web" ,
220- "url.query" : "dpop=proof-secret&wsTicket=ticket-secret" ,
221- "url.path" : "/ws" ,
222- } ) . pipe ( Effect . withSpan ( "GET" ) , Effect . provideService ( Tracer . Tracer , tracer ) ) ;
223-
224- const expected = {
225- "url.full" : "http://127.0.0.1:3773/ws?wsTicket=<redacted>&clientSurface=web" ,
226- "url.query" : "dpop=<redacted>&wsTicket=<redacted>" ,
227- "url.path" : "/ws" ,
228- } ;
229- assert . deepInclude ( records [ 0 ] ?. attributes , expected ) ;
230- assert . deepInclude ( Object . fromEntries ( delegates [ 0 ] ! . attributes ) , expected ) ;
231- } ) . pipe ( Effect . provide ( NodeServices . layer ) ) ,
232- ) ;
233-
234193 it ( "normalizes circular arrays, maps, and sets without recursing forever" , ( ) => {
235194 const array : Array < unknown > = [ "alpha" ] ;
236195 array . push ( array ) ;
@@ -408,6 +367,69 @@ describe("observability", () => {
408367 ) ,
409368 ) ;
410369
370+ it . effect ( "keeps WebSocket credentials out of trace files and exported spans" , ( ) =>
371+ Effect . scoped (
372+ Effect . gen ( function * ( ) {
373+ const fileSystem = yield * FileSystem . FileSystem ;
374+ const path = yield * Path . Path ;
375+ const tempDir = yield * fileSystem . makeTempDirectoryScoped ( { prefix : "t3-trace-sink-" } ) ;
376+ const tracePath = path . join ( tempDir , "shared.trace.ndjson" ) ;
377+ const sink = yield * makeTraceSink ( {
378+ filePath : tracePath ,
379+ maxBytes : 1024 * 1024 ,
380+ maxFiles : 2 ,
381+ batchWindowMs : 10_000 ,
382+ } ) ;
383+ const delegates : Array < Tracer . NativeSpan > = [ ] ;
384+ const tracer = yield * makeLocalFileTracer ( {
385+ filePath : tracePath ,
386+ maxBytes : 1024 * 1024 ,
387+ maxFiles : 2 ,
388+ batchWindowMs : 10_000 ,
389+ sink,
390+ delegate : Tracer . make ( {
391+ span : ( options ) => {
392+ const span = new Tracer . NativeSpan ( options ) ;
393+ delegates . push ( span ) ;
394+ return span ;
395+ } ,
396+ } ) ,
397+ } ) ;
398+ const url = "/ws?wsTicket=ticket-secret&dpop=proof-secret&clientSurface=web" ;
399+
400+ yield * Effect . annotateCurrentSpan ( {
401+ "url.full" : `http://127.0.0.1:3773${ url } ` ,
402+ "url.query" : url . slice ( 4 ) ,
403+ } ) . pipe (
404+ Effect . withSpan ( "GET" , { kind : "server" } ) ,
405+ Effect . provideService ( Tracer . Tracer , tracer ) ,
406+ ) ;
407+ yield * Effect . die ( new Error ( `ResponseError (503 GET ${ url } )` ) ) . pipe (
408+ Effect . withSpan ( "GET" , { kind : "server" } ) ,
409+ Effect . provideService ( Tracer . Tracer , tracer ) ,
410+ Effect . exit ,
411+ ) ;
412+ yield * sink . close ( ) ;
413+
414+ const written = yield * fileSystem . readFileString ( tracePath ) ;
415+ const exported = delegates . map ( ( span ) =>
416+ JSON . stringify ( {
417+ attributes : Object . fromEntries ( span . attributes ) ,
418+ exit :
419+ span . status . _tag === "Ended" && Exit . isFailure ( span . status . exit )
420+ ? Cause . pretty ( span . status . exit . cause )
421+ : "" ,
422+ } ) ,
423+ ) ;
424+ for ( const text of [ written , ...exported ] ) {
425+ assert . notInclude ( text , "ticket-secret" ) ;
426+ assert . notInclude ( text , "proof-secret" ) ;
427+ }
428+ assert . include ( written , "wsTicket=<redacted>&dpop=<redacted>&clientSurface=web" ) ;
429+ } ) ,
430+ ) ,
431+ ) ;
432+
411433 it . effect ( "drops only the invalid trace record when serialization fails" , ( ) =>
412434 Effect . scoped (
413435 Effect . gen ( function * ( ) {
0 commit comments