Skip to content

Commit c9fae23

Browse files
Memoize ChatView selection handlers with useCallback
- Wrap model, effort, and env mode handlers in `useCallback` - Stabilize callback identities while preserving composer focus behavior
1 parent 4d2f16b commit c9fae23

1 file changed

Lines changed: 26 additions & 17 deletions

File tree

‎apps/web/src/components/ChatView.tsx‎

Lines changed: 26 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -812,23 +812,32 @@ export default function ChatView() {
812812
}
813813
};
814814

815-
const onModelSelect = (model: ModelSlug) => {
816-
if (!activeThread) return;
817-
dispatch({
818-
type: "SET_THREAD_MODEL",
819-
threadId: activeThread.id,
820-
model: resolveModelSlug(model),
821-
});
822-
scheduleComposerFocus();
823-
};
824-
const onEffortSelect = (effort: ReasoningEffort) => {
825-
setSelectedEffort(effort);
826-
scheduleComposerFocus();
827-
};
828-
const onEnvModeChange = (mode: "local" | "worktree") => {
829-
setEnvMode(mode);
830-
scheduleComposerFocus();
831-
};
815+
const onModelSelect = useCallback(
816+
(model: ModelSlug) => {
817+
if (!activeThread) return;
818+
dispatch({
819+
type: "SET_THREAD_MODEL",
820+
threadId: activeThread.id,
821+
model: resolveModelSlug(model),
822+
});
823+
scheduleComposerFocus();
824+
},
825+
[activeThread, dispatch, scheduleComposerFocus],
826+
);
827+
const onEffortSelect = useCallback(
828+
(effort: ReasoningEffort) => {
829+
setSelectedEffort(effort);
830+
scheduleComposerFocus();
831+
},
832+
[scheduleComposerFocus],
833+
);
834+
const onEnvModeChange = useCallback(
835+
(mode: "local" | "worktree") => {
836+
setEnvMode(mode);
837+
scheduleComposerFocus();
838+
},
839+
[scheduleComposerFocus],
840+
);
832841

833842
const onKeyDown = (e: KeyboardEvent<HTMLTextAreaElement>) => {
834843
if (e.key === "Enter" && !e.shiftKey) {

0 commit comments

Comments
 (0)