Skip to content

Commit c983c52

Browse files
StiensWoutclaude
andcommitted
fix(server): an unreadable dictation directory no longer stops server startup
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent a77b317 commit c983c52

2 files changed

Lines changed: 23 additions & 2 deletions

File tree

‎apps/server/src/dictation/Dictation.test.ts‎

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ const testLayer = (
2828
language?: string;
2929
install?: DictationArtifacts.DictationArtifacts["Service"]["install"];
3030
remove?: DictationArtifacts.DictationArtifacts["Service"]["remove"];
31+
inspectFails?: boolean;
3132
load?: DictationRecognizer.DictationRecognizer["Service"]["load"];
3233
} = {},
3334
) =>
@@ -55,7 +56,11 @@ const testLayer = (
5556
return {
5657
supported: options.supported ?? true,
5758
paths: () => ({ runtime: "/unused", model: "/unused" }),
58-
inspect: Effect.sync(() => ({ runtime, models: new Map(disk) })),
59+
inspect: options.inspectFails
60+
? Effect.fail(
61+
new DictationError({ reason: "install-failed", message: "Unreadable state." }),
62+
)
63+
: Effect.sync(() => ({ runtime, models: new Map(disk) })),
5964
install: (model, progress) =>
6065
(options.install ?? complete)(model, (artifact, value) =>
6166
Effect.gen(function* () {
@@ -882,3 +887,12 @@ it.effect("warm never installs a model while its removal is still deleting files
882887
);
883888
}),
884889
);
890+
891+
it.effect("an unreadable install directory leaves dictation not installed instead of failing", () =>
892+
Effect.gen(function* () {
893+
const service = yield* Dictation.Dictation;
894+
const state = yield* service.state;
895+
assert.strictEqual(state.runtime._tag, "not-installed");
896+
assert.strictEqual(state.ready, false);
897+
}).pipe(Effect.provide(testLayer({ engine: "off", inspectFails: true })), Effect.scoped),
898+
);

‎apps/server/src/dictation/Dictation.ts‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import {
44
DICTATION_SAMPLE_RATE,
55
DictationError,
66
DictationSessionId,
7+
type DictationInstallState,
78
type DictationModelId,
89
type DictationAppendInput,
910
type DictationCancelInput,
@@ -100,7 +101,13 @@ const make = Effect.gen(function* () {
100101
),
101102
);
102103
const initialSettings = yield* readSettings;
103-
const installed = yield* artifacts.inspect;
104+
// An unreadable state directory must not stop the server from starting; it reads as not installed.
105+
const installed = yield* artifacts.inspect.pipe(
106+
Effect.orElseSucceed(() => ({
107+
runtime: { _tag: "not-installed" } satisfies DictationInstallState,
108+
models: new Map<DictationModelId, DictationInstallState>(),
109+
})),
110+
);
104111
const state = yield* SubscriptionRef.make<DictationState>({
105112
supported: artifacts.supported,
106113
settings: initialSettings.dictation,

0 commit comments

Comments
 (0)