Skip to content

Commit c979424

Browse files
committed
fix(server): keep an explicit mark unread after an automatic compaction
1 parent 0031a8d commit c979424

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

‎apps/server/src/orchestration-v2/IdleCompactionService.test.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ function compactedThread(threadId: string, lastVisitedAt: DateTime.Utc | null) {
2626
ordinal,
2727
userMessageId,
2828
status: "completed",
29+
requestedAt: DateTime.subtract(completedAt, { minutes: 1 }),
2930
completedAt,
3031
}) as unknown as OrchestrationV2Run;
3132
const previous = run(1, "message", at(0));
@@ -48,6 +49,7 @@ it.effect("marks a caught-up thread read when its automatic compaction completes
4849
const threads = [
4950
compactedThread("unseen", null),
5051
compactedThread("behind", at(-1)),
52+
compactedThread("marked-unread", DateTime.subtract(at(58), { milliseconds: 1 })),
5153
compactedThread("caught-up", at(1)),
5254
];
5355
const events = yield* Queue.unbounded<OrchestrationV2DomainEvent>();

‎apps/server/src/orchestration-v2/IdleCompactionService.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,8 @@ export const make = Effect.gen(function* () {
105105
if (
106106
thread.lastVisitedAt === null ||
107107
previous?.completedAt == null ||
108-
DateTime.isGreaterThan(previous.completedAt, thread.lastVisitedAt)
108+
DateTime.isGreaterThan(previous.completedAt, thread.lastVisitedAt) ||
109+
!DateTime.isLessThan(thread.lastVisitedAt, run.requestedAt)
109110
)
110111
return;
111112
yield* orchestrator.dispatch({

0 commit comments

Comments
 (0)