Skip to content

Commit c8231f9

Browse files
t3dotggclaude
andauthored
fix(mobile): queue Steer button no longer opens the editor on a near miss (#24832)
Co-authored-by: Claude Opus 5.5 <[email protected]>
1 parent dca46e2 commit c8231f9

1 file changed

Lines changed: 94 additions & 83 deletions

File tree

‎apps/mobile/src/features/threads/ThreadQueueControl.tsx‎

Lines changed: 94 additions & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -324,97 +324,108 @@ export function ThreadQueueSheet({ route }: StaticScreenProps<QueueTarget>) {
324324
background={theme["--color-sheet"]}
325325
onRemove={() => void act(run.id, "remove")}
326326
>
327-
<Menu
328-
accessibilityLabel={`Actions for queued message ${index + 1}`}
329-
shouldOpenOnLongPress
330-
actions={[
331-
...(workflow?.canPromoteToSteer || workflow?.canSendNow
332-
? [
333-
{
334-
id: "steer",
335-
title: workflow?.canSendNow ? "Send now" : "Steer now",
336-
attributes: { disabled: !controls.canSend },
337-
image: Platform.OS === "ios" ? "arrow.turn.left.up" : "arrow_upward",
338-
},
339-
]
340-
: []),
341-
{
342-
id: "edit",
343-
title: "Edit",
344-
attributes: { disabled: !controls.canEdit },
345-
image: Platform.OS === "ios" ? "pencil" : "edit",
346-
},
347-
{ id: "up", title: "Move up", attributes: { disabled: !controls.canMoveUp } },
348-
{
349-
id: "down",
350-
title: "Move down",
351-
attributes: { disabled: !controls.canMoveDown },
352-
},
353-
{
354-
id: "remove",
355-
title: "Remove",
356-
attributes: { disabled: !controls.canDismiss, destructive: true },
357-
},
358-
]}
359-
onPressAction={({ nativeEvent }) =>
360-
void act(run.id, nativeEvent.event as QueueAction)
361-
}
362-
>
363-
<Pressable
364-
accessibilityRole="button"
365-
accessibilityLabel={title}
366-
accessibilityHint={
367-
controls.canEdit
368-
? "Opens this message in the composer for editing"
369-
: undefined
327+
<View className="flex-row items-center">
328+
<Menu
329+
accessibilityLabel={`Actions for queued message ${index + 1}`}
330+
shouldOpenOnLongPress
331+
style={{ flex: 1 }}
332+
actions={[
333+
...(workflow?.canPromoteToSteer || workflow?.canSendNow
334+
? [
335+
{
336+
id: "steer",
337+
title: workflow?.canSendNow ? "Send now" : "Steer now",
338+
attributes: { disabled: !controls.canSend },
339+
image: Platform.OS === "ios" ? "arrow.turn.left.up" : "arrow_upward",
340+
},
341+
]
342+
: []),
343+
{
344+
id: "edit",
345+
title: "Edit",
346+
attributes: { disabled: !controls.canEdit },
347+
image: Platform.OS === "ios" ? "pencil" : "edit",
348+
},
349+
{ id: "up", title: "Move up", attributes: { disabled: !controls.canMoveUp } },
350+
{
351+
id: "down",
352+
title: "Move down",
353+
attributes: { disabled: !controls.canMoveDown },
354+
},
355+
{
356+
id: "remove",
357+
title: "Remove",
358+
attributes: { disabled: !controls.canDismiss, destructive: true },
359+
},
360+
]}
361+
onPressAction={({ nativeEvent }) =>
362+
void act(run.id, nativeEvent.event as QueueAction)
370363
}
371-
disabled={!controls.canEdit}
372-
onPress={() => void act(run.id, "edit")}
373-
className="min-h-14 flex-row items-center gap-2.5 py-2.5 active:opacity-70"
374364
>
375-
<QueueAttachmentThumbnails
376-
environmentId={target.environmentId}
377-
attachments={attachments}
378-
/>
379-
<Text
380-
className={
381-
controls.isEditing
382-
? "min-w-0 flex-1 text-sm text-foreground-muted"
383-
: "min-w-0 flex-1 text-sm text-foreground"
365+
<Pressable
366+
accessibilityRole="button"
367+
accessibilityLabel={title}
368+
accessibilityHint={
369+
controls.canEdit
370+
? "Opens this message in the composer for editing"
371+
: undefined
384372
}
385-
numberOfLines={1}
373+
disabled={!controls.canEdit}
374+
onPress={() => void act(run.id, "edit")}
375+
className="min-h-14 flex-row items-center gap-2.5 py-2.5 active:opacity-70"
386376
>
387-
{context?.guest === undefined ? null : (
388-
<Text className="font-t3-medium text-adaptive-fuchsia-600-300">
389-
{`${context.guest.name} `}
390-
</Text>
391-
)}
392-
{title}
393-
</Text>
394-
{controls.isEditing ? (
395-
<Text className="shrink-0 text-2xs uppercase tracking-wide text-primary">
396-
Editing
397-
</Text>
398-
) : null}
399-
{workflow?.canPromoteToSteer || workflow?.canSendNow ? (
400-
<Pressable
401-
accessibilityRole="button"
402-
accessibilityLabel={
403-
workflow?.canSendNow
404-
? `Send message ${index + 1} now`
405-
: `Steer with message ${index + 1} now`
377+
<QueueAttachmentThumbnails
378+
environmentId={target.environmentId}
379+
attachments={attachments}
380+
/>
381+
<Text
382+
className={
383+
controls.isEditing
384+
? "min-w-0 flex-1 text-sm text-foreground-muted"
385+
: "min-w-0 flex-1 text-sm text-foreground"
406386
}
407-
disabled={!controls.canSend}
408-
onPress={() => void act(run.id, "steer")}
409-
className="h-8 shrink-0 justify-center rounded-full bg-primary px-3 active:opacity-70 disabled:opacity-40"
387+
numberOfLines={1}
410388
>
411-
<Text className="font-t3-medium text-xs text-primary-foreground">
389+
{context?.guest === undefined ? null : (
390+
<Text className="font-t3-medium text-adaptive-fuchsia-600-300">
391+
{`${context.guest.name} `}
392+
</Text>
393+
)}
394+
{title}
395+
</Text>
396+
{controls.isEditing ? (
397+
<Text className="shrink-0 text-2xs uppercase tracking-wide text-primary">
398+
Editing
399+
</Text>
400+
) : null}
401+
</Pressable>
402+
</Menu>
403+
{workflow?.canPromoteToSteer || workflow?.canSendNow ? (
404+
// Outside the edit row and full row height, so a near miss never opens the editor.
405+
<Pressable
406+
accessibilityRole="button"
407+
accessibilityLabel={
408+
workflow?.canSendNow
409+
? `Send message ${index + 1} now`
410+
: `Steer with message ${index + 1} now`
411+
}
412+
disabled={!controls.canSend}
413+
onPress={() => void act(run.id, "steer")}
414+
className="shrink-0 justify-center self-stretch pl-4 active:opacity-70 disabled:opacity-40"
415+
>
416+
<View className="min-h-9 flex-row items-center gap-1.5 rounded-full bg-primary px-4">
417+
<SymbolView
418+
name={workflow?.canSendNow ? "arrow.up" : "arrow.turn.left.up"}
419+
size={13}
420+
tintColorClassName="accent-primary-foreground"
421+
/>
422+
<Text className="font-t3-medium text-sm text-primary-foreground">
412423
{workflow?.canSendNow ? "Send now" : "Steer"}
413424
</Text>
414-
</Pressable>
415-
) : null}
416-
</Pressable>
417-
</Menu>
425+
</View>
426+
</Pressable>
427+
) : null}
428+
</View>
418429
</QueueRowSwipeable>
419430
</Animated.View>
420431
</QueueShiftedRow>

0 commit comments

Comments
 (0)