Skip to content

Commit c75c3f7

Browse files
committed
Merge main into fix/checkpoint-index-metadata
2 parents 5d0afd8 + 6fd68f5 commit c75c3f7

708 files changed

Lines changed: 52901 additions & 10667 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.gitignore‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ dist-electron/
3030
.electron-runtime/
3131
.showcase/
3232
apps/mobile/.showcase/
33+
apps/mobile/.generated/
34+
/.generated/
3335
artifacts/app-store/screenshots/
3436
.github/pr-assets/
3537
native/**/target/
@@ -38,3 +40,6 @@ node_modules/
3840
*.log
3941
.env*
4042
!.env.example
43+
44+
# pnpm content-addressable store; never belongs in the repo.
45+
.pnpm-store/

‎apps/desktop/src/app/DesktopApp.ts‎

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import * as Cause from "effect/Cause";
2+
import * as Duration from "effect/Duration";
23
import * as Effect from "effect/Effect";
34
import * as Option from "effect/Option";
45
import * as Ref from "effect/Ref";
@@ -142,6 +143,20 @@ const handleFatalStartupError = Effect.fn("desktop.startup.handleFatalStartupErr
142143
const fatalStartupCause = <E>(stage: string, cause: Cause.Cause<E>) =>
143144
handleFatalStartupError(stage, Cause.pretty(cause)).pipe(Effect.andThen(Effect.failCause(cause)));
144145

146+
export const stopAllPoolInstances = Effect.fn("desktop.app.stopAllPoolInstances")(
147+
function* (): Effect.fn.Return<void, never, DesktopBackendPool.DesktopBackendPool> {
148+
// Stop every backend in the pool with a timeout to guarantee the quit
149+
// path makes progress even if a backend hangs during teardown.
150+
const pool = yield* DesktopBackendPool.DesktopBackendPool;
151+
const instances = yield* pool.list;
152+
yield* Effect.forEach(
153+
instances,
154+
(instance) => instance.stop({ timeout: Duration.seconds(5) }),
155+
{ concurrency: "unbounded" },
156+
);
157+
},
158+
);
159+
145160
const bootstrap = Effect.gen(function* () {
146161
const pool = yield* DesktopBackendPool.DesktopBackendPool;
147162
const primaryBackend = yield* pool.primary;
@@ -313,18 +328,12 @@ const scopedProgram = Effect.scoped(
313328
const shutdown = yield* DesktopShutdown.DesktopShutdown;
314329

315330
yield* Effect.addFinalizer(() =>
316-
Effect.gen(function* () {
317-
const pool = yield* DesktopBackendPool.DesktopBackendPool;
318-
// Stop every backend in the pool, not just the primary. The
319-
// electronApp.quit() path can race ahead of the layer-scope
320-
// cascade, so leaving the WSL instance for its parent scope
321-
// finalizer means it gets hard-killed by the OS instead of
322-
// receiving SIGTERM + grace. Stops run concurrently.
323-
const instances = yield* pool.list;
324-
yield* Effect.forEach(instances, (instance) => instance.stop(), {
325-
concurrency: "unbounded",
326-
});
327-
}).pipe(Effect.ensuring(shutdown.markComplete)),
331+
// Stop every backend in the pool, not just the primary. The
332+
// electronApp.quit() path can race ahead of the layer-scope
333+
// cascade, so leaving the WSL instance for its parent scope
334+
// finalizer means it gets hard-killed by the OS instead of
335+
// receiving SIGTERM + grace.
336+
stopAllPoolInstances().pipe(Effect.ensuring(shutdown.markComplete)),
328337
);
329338

330339
yield* startup;

‎apps/desktop/src/app/DesktopConnectionCatalogStore.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -372,6 +372,7 @@ const migrateSavedEnvironmentRecords = Effect.fn(
372372
profiles,
373373
credentials,
374374
remoteDpopTokens: [],
375+
disabledEnvironmentIds: [],
375376
};
376377
});
377378

‎apps/desktop/src/backend/DesktopBackendManager.test.ts‎

Lines changed: 74 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ import { HttpClient, HttpClientRequest, HttpClientResponse } from "effect/unstab
2323
import { ChildProcess, ChildProcessSpawner } from "effect/unstable/process";
2424

2525
import * as DesktopBackendManager from "./DesktopBackendManager.ts";
26+
import * as DesktopApp from "../app/DesktopApp.ts";
27+
import * as DesktopBackendPool from "./DesktopBackendPool.ts";
2628
import * as DesktopObservability from "../app/DesktopObservability.ts";
2729
import * as DesktopTelemetryPublisher from "../telemetry/DesktopTelemetryPublisher.ts";
2830
import * as DesktopWslEnvironment from "../wsl/DesktopWslEnvironment.ts";
@@ -1503,4 +1505,76 @@ describe("DesktopBackendManager", () => {
15031505
}).pipe(Effect.provide(TestClock.layer())),
15041506
),
15051507
);
1508+
1509+
it.effect("stopAllPoolInstances bounds the quit finalizer when backends hang", () =>
1510+
Effect.scoped(
1511+
Effect.gen(function* () {
1512+
// Each backend's process-scope finalizer reports when it starts and
1513+
// when it finishes, keyed by instance name, so the test can prove
1514+
// both backends reached each milestone instead of inferring it from
1515+
// a shared flag or a clock advance.
1516+
const teardownStarted = yield* Queue.unbounded<string>();
1517+
const teardownFinished = yield* Queue.unbounded<string>();
1518+
const allowTeardown = yield* Deferred.make<void>();
1519+
1520+
const makeInstance = (name: string) =>
1521+
makeTestInstance({
1522+
spawnerLayer: Layer.succeed(
1523+
ChildProcessSpawner.ChildProcessSpawner,
1524+
ChildProcessSpawner.make(() =>
1525+
Effect.gen(function* () {
1526+
const scope = yield* Scope.Scope;
1527+
yield* Scope.addFinalizer(
1528+
scope,
1529+
Queue.offer(teardownStarted, name).pipe(
1530+
Effect.andThen(Deferred.await(allowTeardown)),
1531+
Effect.andThen(Queue.offer(teardownFinished, name)),
1532+
Effect.asVoid,
1533+
),
1534+
);
1535+
return makeProcess({ exitCode: Effect.never });
1536+
}),
1537+
),
1538+
),
1539+
httpClientLayer: httpClientLayer(() => Effect.never),
1540+
});
1541+
1542+
const instance1 = yield* makeInstance("instance1");
1543+
const instance2 = yield* makeInstance("instance2");
1544+
1545+
yield* instance1.start;
1546+
yield* instance2.start;
1547+
1548+
const mockPool = Layer.succeed(DesktopBackendPool.DesktopBackendPool, {
1549+
list: Effect.succeed([instance1, instance2]),
1550+
get: () => Effect.succeed(Option.none()),
1551+
primary: Effect.die(new Error("primary not implemented")),
1552+
register: () => Effect.die(new Error("register not implemented")),
1553+
unregister: () => Effect.die(new Error("unregister not implemented")),
1554+
});
1555+
1556+
// Mirror the quit path: register stopAllPoolInstances as a scope
1557+
// finalizer and let the scope close run it, rather than calling it
1558+
// as an ordinary interruptible effect.
1559+
const quitFiber = yield* Effect.scoped(
1560+
Effect.addFinalizer(() => DesktopApp.stopAllPoolInstances()),
1561+
).pipe(Effect.provide(mockPool), Effect.forkChild);
1562+
1563+
const started = yield* Queue.takeN(teardownStarted, 2);
1564+
assert.deepEqual(started.toSorted(), ["instance1", "instance2"]);
1565+
1566+
// Both backends are now hung in teardown. Advancing past the 5s
1567+
// budget must let the quit finalizer return without them.
1568+
yield* TestClock.adjust(Duration.seconds(5));
1569+
yield* Fiber.join(quitFiber);
1570+
assert.equal(yield* Queue.size(teardownFinished), 0);
1571+
1572+
// The timed-out closes keep running in the background and finish
1573+
// once the backends unblock.
1574+
yield* Deferred.succeed(allowTeardown, undefined);
1575+
const finished = yield* Queue.takeN(teardownFinished, 2);
1576+
assert.deepEqual(finished.toSorted(), ["instance1", "instance2"]);
1577+
}).pipe(Effect.provide(TestClock.layer())),
1578+
),
1579+
);
15061580
});

‎apps/desktop/src/electron/ElectronProtocol.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,7 @@ describe("ElectronProtocol", () => {
226226
"https:",
227227
]);
228228
assert.deepEqual(directives["media-src"], ["'self'", "t3code:", "blob:", "http:", "https:"]);
229+
assert.deepEqual(directives["frame-src"], ["'self'", "blob:", "http:", "https:"]);
229230
assert.deepEqual(directives["font-src"], ["'self'", "t3code:", "data:"]);
230231
});
231232
});

‎apps/desktop/src/electron/ElectronProtocol.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,9 @@ export function makeDesktopContentSecurityPolicy(input: DesktopProtocolRegistrat
9191
"style-src 'self' 'unsafe-inline'",
9292
`font-src 'self' ${input.scheme}: data:`,
9393
"worker-src 'self' blob:",
94-
"frame-src 'self' https://challenges.cloudflare.com",
94+
// Document viewers use local Blob URLs and signed assets from runtime environments.
95+
// HTML viewers retain their own sandbox; the renderer's script policy stays unchanged.
96+
"frame-src 'self' blob: http: https:",
9597
"form-action 'self'",
9698
].join("; ");
9799
}

‎apps/desktop/src/electron/ElectronShell.ts‎

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { MAC_PERMISSION_SETTINGS_URLS } from "../permissions/MacPermission.ts";
12
import {
23
REMOTE_CAPABLE_EDITOR_IDS,
34
remoteSchemeForEditor,
@@ -10,20 +11,6 @@ import * as Option from "effect/Option";
1011

1112
import * as Electron from "electron";
1213

13-
/**
14-
* Deep links to individual System Settings panes. These are app-fixed, not
15-
* renderer-supplied, so they skip `parseSafeExternalUrl` — which exists to keep
16-
* arbitrary link schemes from reaching the OS handler — and open through their
17-
* own path below. The pane rather than the URL crosses the IPC boundary, so a
18-
* renderer can only ask for one of these known destinations.
19-
*
20-
* Full Disk Access uses the post-Ventura `PrivacySecurity.extension` anchor.
21-
*/
22-
const SYSTEM_SETTINGS_URLS: Record<SystemSettingsPane, string> = {
23-
"full-disk-access":
24-
"x-apple.systempreferences:com.apple.settings.PrivacySecurity.extension?Privacy_AllFiles",
25-
};
26-
2714
// Remote open-in-editor deep links (`vscode://vscode-remote/ssh-remote+…`,
2815
// `zed://ssh/<host>/<path>`) must reach the OS handler; every other non-web
2916
// scheme stays blocked.
@@ -88,7 +75,7 @@ export const make = ElectronShell.of({
8875
}),
8976
openSystemSettings: (pane) =>
9077
Effect.promise(() =>
91-
Electron.shell.openExternal(SYSTEM_SETTINGS_URLS[pane]).then(
78+
Electron.shell.openExternal(MAC_PERMISSION_SETTINGS_URLS[pane]).then(
9279
() => true,
9380
() => false,
9481
),

‎apps/desktop/src/ipc/DesktopIpcHandlers.ts‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ import {
3939
getWindowFullscreenState,
4040
openExternal,
4141
openSystemSettings,
42+
checkSystemPermission,
43+
pasteAsText,
4244
probeRemoteEditors,
4345
pickFolder,
4446
pickProjectFavicon,
@@ -122,6 +124,8 @@ export const installDesktopIpcHandlers = Effect.fn("desktop.ipc.installHandlers"
122124
yield* ipc.handle(showContextMenu);
123125
yield* ipc.handle(openExternal);
124126
yield* ipc.handle(openSystemSettings);
127+
yield* ipc.handle(checkSystemPermission);
128+
yield* ipc.handle(pasteAsText);
125129
yield* ipc.handle(probeRemoteEditors);
126130
yield* ipc.handle(getUpdateState);
127131
yield* ipc.handle(setUpdateChannel);

‎apps/desktop/src/ipc/channels.ts‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ export const OPEN_EXTERNAL_CHANNEL = "desktop:open-external";
77
export const OPEN_SYSTEM_SETTINGS_CHANNEL = "desktop:open-system-settings";
88
export const PROBE_REMOTE_EDITORS_CHANNEL = "desktop:probe-remote-editors";
99
export const MENU_ACTION_CHANNEL = "desktop:menu-action";
10+
export const PASTE_AS_TEXT_CHANNEL = "desktop:paste-as-text";
1011
export const SNAP_SHOT_EVENT_CHANNEL = "desktop:snap-shot-event";
1112
export const QUIT_SHORTCUT_CHANNEL = "desktop:quit-shortcut";
1213
export const GET_WINDOW_FULLSCREEN_STATE_CHANNEL = "desktop:get-window-fullscreen-state";
@@ -105,3 +106,7 @@ export const PREVIEW_RECORDING_SAVE_CHANNEL = "desktop:preview-recording-save";
105106
export const PREVIEW_RECORDING_FRAME_CHANNEL = "desktop:preview-recording-frame";
106107
export const PREVIEW_STATE_CHANGE_CHANNEL = "desktop:preview-state-change";
107108
export const PREVIEW_POINTER_EVENT_CHANNEL = "desktop:preview-pointer-event";
109+
110+
export const MAC_PERMISSION_HELPER_CHANNEL = "desktop:mac-permission-helper";
111+
112+
export const CHECK_SYSTEM_PERMISSION_CHANNEL = "desktop:check-system-permission";

‎apps/desktop/src/ipc/methods/window.test.ts‎

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,23 @@ import { vi } from "vite-plus/test";
66

77
import type * as Electron from "electron";
88

9+
const { focusedWebContents, ownerWindow } = vi.hoisted(() => ({
10+
focusedWebContents: vi.fn(),
11+
ownerWindow: vi.fn(),
12+
}));
13+
vi.mock("electron", () => ({
14+
webContents: { getFocusedWebContents: focusedWebContents },
15+
BrowserWindow: { fromWebContents: ownerWindow },
16+
}));
17+
918
import * as DesktopBackendManager from "../../backend/DesktopBackendManager.ts";
1019
import * as DesktopBackendPool from "../../backend/DesktopBackendPool.ts";
1120
import * as ElectronDialog from "../../electron/ElectronDialog.ts";
1221
import * as ElectronWindow from "../../electron/ElectronWindow.ts";
1322
import {
1423
getLocalEnvironmentBootstraps,
1524
getWindowFullscreenState,
25+
pasteAsText,
1626
pickProjectFavicon,
1727
} from "./window.ts";
1828

@@ -153,6 +163,50 @@ describe("getWindowFullscreenState", () => {
153163
});
154164
});
155165

166+
describe("pasteAsText", () => {
167+
it.effect(
168+
"pastes into the focused guest only after the main renderer acknowledges the menu action",
169+
() => {
170+
const paste = vi.fn();
171+
const mainPaste = vi.fn();
172+
const window = {
173+
webContents: { id: 42, paste: mainPaste },
174+
isDestroyed: () => false,
175+
} as unknown as Electron.BrowserWindow;
176+
focusedWebContents.mockReturnValue({ paste, isDestroyed: () => false });
177+
ownerWindow.mockReturnValue(window);
178+
179+
return Effect.gen(function* () {
180+
yield* pasteAsText.handler(undefined, { sender: { id: 42 } });
181+
assert.equal(paste.mock.calls.length, 1);
182+
assert.equal(mainPaste.mock.calls.length, 0);
183+
184+
yield* pasteAsText.handler(undefined, { sender: { id: 99 } });
185+
assert.equal(paste.mock.calls.length, 1);
186+
ownerWindow.mockReturnValue({}); // A focused PiP/other BrowserWindow.
187+
yield* pasteAsText.handler(undefined, { sender: { id: 42 } });
188+
assert.equal(paste.mock.calls.length, 1);
189+
ownerWindow.mockReturnValue(null); // Detached contents.
190+
yield* pasteAsText.handler(undefined, { sender: { id: 42 } });
191+
assert.equal(paste.mock.calls.length, 1);
192+
ownerWindow.mockReturnValue(window);
193+
focusedWebContents.mockReturnValue({ paste, isDestroyed: () => true });
194+
yield* pasteAsText.handler(undefined, { sender: { id: 42 } });
195+
assert.equal(paste.mock.calls.length, 1);
196+
focusedWebContents.mockReturnValue(null);
197+
yield* pasteAsText.handler(undefined, { sender: { id: 42 } });
198+
assert.equal(paste.mock.calls.length, 1);
199+
}).pipe(
200+
Effect.provide(
201+
Layer.mock(ElectronWindow.ElectronWindow)({
202+
main: Effect.succeed(Option.some(window)),
203+
}),
204+
),
205+
);
206+
},
207+
);
208+
});
209+
156210
describe("pickProjectFavicon", () => {
157211
it.effect("opens a single-image picker from the project directory", () =>
158212
Effect.gen(function* () {

0 commit comments

Comments
 (0)