You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit c6f38e1
Browse filesBrowse the repository at this point in the historyBrowse files
fix(server): shell resync also skips an unknown event type
subscribeOrchestrationV2Shell's resume path replayed with
readApplicationEvents, which stayed strict even after the thread fix: a
shell cursor from before a row this build doesn't know still failed the
whole resubscribe with OrchestrationV2GetShellSnapshotError instead of
sending the resumed shell and synchronized.
readApplicationEvents now takes the same skipUnknownEventTypes opt-in as
readAgentEvents, applied only by the shell's resume call in ws.ts.
Pagination now counts raw SQL rows instead of post-filter decoded events,
so a page that drops an unknown row mid-page still advances its cursor and
"more pages?" check correctly - the gap this change closes also applies to
project rows, which readApplicationEvents reads alongside thread rows, so
the known-type check now branches on aggregate_kind. Everything that builds
server state (EventSink catch-up, ingest, projections, the live tail) still
calls through strict, since only the shell's one-shot replay call sets the
flag.
Store-level tests cover the skip and the still-fails-a-broken-known-type
case, mirroring the thread-level tests. They do not reach ws.ts's
subscribeOrchestrationV2Shell itself (the synchronized marker, snapshot
fallback, or shell-stream projection), which would need a layer providing
ThreadManagementService, ProjectStoreV2, ProjectService, and
ProjectEnrichmentService; verified that path manually with a scripted call
to subscribeOrchestrationV2Shell against a real SQLite-backed store, which
now emits synchronized and logs exactly one skip warning.
Co-Authored-By: Claude Sonnet 5 <[email protected]>
0 commit comments