Skip to content

Commit c62d2b2

Browse files
committed
fix(web): preserve consecutive interval commits before settings sync
1 parent dd39691 commit c62d2b2

2 files changed

Lines changed: 15 additions & 2 deletions

File tree

‎apps/web/src/components/settings/IntervalSecondsField.tsx‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,10 @@ export function IntervalSecondsField({
2323
}) {
2424
const [draft, setDraft] = useState<number | null>(value);
2525
const [savedValue, setSavedValue] = useState(value);
26+
const [committedValue, setCommittedValue] = useState(value);
2627
if (savedValue !== value) {
2728
setSavedValue(value);
29+
setCommittedValue(value);
2830
setDraft(value);
2931
}
3032

@@ -38,12 +40,15 @@ export function IntervalSecondsField({
3840
onValueChange={setDraft}
3941
onValueCommitted={(next) => {
4042
if (next === null) {
41-
setDraft(value);
43+
setDraft(committedValue);
4244
return;
4345
}
4446
const seconds = normalizeIntervalSeconds(next, min);
4547
setDraft(seconds);
46-
if (seconds !== value) onCommit(seconds);
48+
if (seconds !== committedValue) {
49+
setCommittedValue(seconds);
50+
onCommit(seconds);
51+
}
4752
}}
4853
>
4954
<NumberFieldGroup>

‎apps/web/src/components/settings/ProviderSettingsPanel.environment.browser.test.tsx‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -365,6 +365,14 @@ describe("EnvironmentProviderSettings health check interval", () => {
365365
await using _screen = await render(panel());
366366
const input = page.getByRole("textbox", { name: "Provider health check interval in seconds" });
367367

368+
await userEvent.type(input, "{ArrowUp}{ArrowDown}");
369+
expect(
370+
state.updateSettings.mock.calls.map(([patch]) =>
371+
Duration.toSeconds(patch.backgroundActivity.overrides.providerHealthRefreshInterval),
372+
),
373+
).toEqual([330, 300]);
374+
state.updateSettings.mockClear();
375+
368376
// Replacing 300 with 120 passes through 30, 3, an empty field, 1 and 12.
369377
await userEvent.type(input, "{Backspace}{Backspace}{Backspace}120");
370378
await expect.element(input).toHaveValue("120");

0 commit comments

Comments
 (0)