Repository navigation
Commit c5cdcb6
refactor(web): context chips render through one ContextChip component
Button variant="chip" was an escape hatch: it skipped buttonVariants
entirely and let each call site assemble the chip look from exported
class-name constants (CHAT_INLINE_CHIP_CLASS_NAME, the tone maps, the
interactive and dismiss classes). Every chip surface re-derived the same
pill slightly differently.
ContextChip (components/ContextChip.tsx) now owns that look. It is a chat
feature component, not a components/ui primitive: nothing outside chat
context uses it. ContextChip takes a kind (neutral,
file, mention, terminal, skill, pull request states, …) and a state
(unresolved, invalid). Interactivity follows from what it renders as:
render={<button/>} or a link gets the hover tint, focus outline and
pointer, and media kinds zoom. ContextChipLabel truncates the text and
ContextChipAction is the in-chip icon button. The composer, sent messages, the
markdown file link, skills, terminal excerpts and citations all use it,
and variant="chip" plus the class-name exports are gone.
The markdown file link drops its own color and focus ring from
index.css so the chip's apply alone. The background worktree setup pill
is a Button ghost-muted micro now; it is a control, not context.
no-restyle findings: 624 -> 604.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>1 parent e22e7ca commit c5cdcb6
14 files changed
Lines changed: 330 additions & 576 deletions
File tree
- apps/web/src
- components
- chat
- ui
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
108 | | - | |
| 108 | + | |
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| 121 | + | |
121 | 122 | | |
122 | 123 | | |
123 | 124 | | |
| |||
1156 | 1157 | | |
1157 | 1158 | | |
1158 | 1159 | | |
1159 | | - | |
1160 | 1160 | | |
1161 | 1161 | | |
1162 | | - | |
1163 | | - | |
| 1162 | + | |
1164 | 1163 | | |
1165 | 1164 | | |
1166 | 1165 | | |
| |||
1895 | 1894 | | |
1896 | 1895 | | |
1897 | 1896 | | |
1898 | | - | |
1899 | 1897 | | |
1900 | 1898 | | |
1901 | 1899 | | |
| |||
2165 | 2163 | | |
2166 | 2164 | | |
2167 | 2165 | | |
2168 | | - | |
2169 | | - | |
2170 | | - | |
2171 | | - | |
2172 | | - | |
2173 | | - | |
2174 | | - | |
| 2166 | + | |
| 2167 | + | |
| 2168 | + | |
| 2169 | + | |
2175 | 2170 | | |
2176 | 2171 | | |
2177 | 2172 | | |
| |||
2188 | 2183 | | |
2189 | 2184 | | |
2190 | 2185 | | |
2191 | | - | |
2192 | | - | |
| 2186 | + | |
| 2187 | + | |
2193 | 2188 | | |
2194 | | - | |
2195 | | - | |
| 2189 | + | |
| 2190 | + | |
| 2191 | + | |
2196 | 2192 | | |
2197 | 2193 | | |
2198 | | - | |
2199 | | - | |
2200 | | - | |
2201 | | - | |
2202 | | - | |
2203 | | - | |
| 2194 | + | |
2204 | 2195 | | |
2205 | 2196 | | |
2206 | 2197 | | |
2207 | 2198 | | |
2208 | | - | |
2209 | | - | |
| 2199 | + | |
| 2200 | + | |
2210 | 2201 | | |
2211 | 2202 | | |
2212 | 2203 | | |
| |||
2242 | 2233 | | |
2243 | 2234 | | |
2244 | 2235 | | |
2245 | | - | |
2246 | | - | |
| 2236 | + | |
2247 | 2237 | | |
2248 | 2238 | | |
2249 | 2239 | | |
| |||
2571 | 2561 | | |
2572 | 2562 | | |
2573 | 2563 | | |
2574 | | - | |
2575 | | - | |
2576 | | - | |
2577 | | - | |
2578 | | - | |
2579 | | - | |
| 2564 | + | |
2580 | 2565 | | |
2581 | 2566 | | |
2582 | 2567 | | |
| |||
2633 | 2618 | | |
2634 | 2619 | | |
2635 | 2620 | | |
2636 | | - | |
2637 | 2621 | | |
2638 | 2622 | | |
2639 | 2623 | | |
| |||
3068 | 3052 | | |
3069 | 3053 | | |
3070 | 3054 | | |
3071 | | - | |
3072 | 3055 | | |
3073 | 3056 | | |
3074 | 3057 | | |
| |||
3085 | 3068 | | |
3086 | 3069 | | |
3087 | 3070 | | |
3088 | | - | |
3089 | 3071 | | |
3090 | 3072 | | |
3091 | 3073 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
| 61 | + | |
| 62 | + | |
69 | 63 | | |
70 | 64 | | |
71 | 65 | | |
72 | 66 | | |
| 67 | + | |
73 | 68 | | |
74 | 69 | | |
75 | 70 | | |
| |||
190 | 185 | | |
191 | 186 | | |
192 | 187 | | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
193 | 195 | | |
194 | 196 | | |
195 | 197 | | |
| |||
217 | 219 | | |
218 | 220 | | |
219 | 221 | | |
220 | | - | |
221 | | - | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
222 | 225 | | |
223 | 226 | | |
224 | | - | |
225 | 227 | | |
226 | 228 | | |
227 | 229 | | |
| |||
231 | 233 | | |
232 | 234 | | |
233 | 235 | | |
234 | | - | |
| 236 | + | |
235 | 237 | | |
236 | 238 | | |
237 | | - | |
| 239 | + | |
238 | 240 | | |
239 | 241 | | |
240 | 242 | | |
| |||
275 | 277 | | |
276 | 278 | | |
277 | 279 | | |
278 | | - | |
| 280 | + | |
279 | 281 | | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
280 | 285 | | |
281 | | - | |
282 | | - | |
283 | | - | |
284 | | - | |
285 | | - | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | | - | |
290 | | - | |
291 | | - | |
292 | 286 | | |
293 | 287 | | |
294 | 288 | | |
| |||
380 | 374 | | |
381 | 375 | | |
382 | 376 | | |
383 | | - | |
| 377 | + | |
384 | 378 | | |
385 | 379 | | |
386 | 380 | | |
| |||
435 | 429 | | |
436 | 430 | | |
437 | 431 | | |
438 | | - | |
| 432 | + | |
439 | 433 | | |
440 | 434 | | |
441 | 435 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
0 commit comments