Skip to content

Commit c23590a

Browse files
fix(mobile): the pull requests tab's empty detail asks for a pull request
On iPad and iPhone Duo, the pull requests tab's empty detail column said "Select a thread" and could offer New Task. It now asks for a pull request, as Android already does, and leaves out the task action. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent fe869ab commit c23590a

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

‎apps/mobile/src/features/layout/WorkspaceEmptyDetail.tsx‎

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,14 @@ import { AppText as Text } from "../../components/ui/AppText";
55
import { NewThreadButton } from "../../components/NewThreadButton";
66
import { FloatingActionButton } from "../../components/ui/FloatingActionButton";
77
import { EmptyState } from "../../components/ui/EmptyState";
8+
import type { WorkspaceTab } from "../workspace/workspace-tabs-state";
89

910
export function WorkspaceEmptyDetail(props: {
11+
readonly tab?: WorkspaceTab;
1012
readonly onStartNewTask?: () => void;
1113
readonly onAddConnection?: () => void;
1214
}) {
15+
const pullRequests = props.tab === "pullRequests";
1316
return (
1417
<View
1518
className={
@@ -43,13 +46,17 @@ export function WorkspaceEmptyDetail(props: {
4346
tintColorClassName="accent-icon-subtle"
4447
type="hierarchical"
4548
/>
46-
<Text className="text-center text-xl font-t3-bold">Select a thread</Text>
49+
<Text className="text-center text-xl font-t3-bold">
50+
{pullRequests ? "Select a pull request" : "Select a thread"}
51+
</Text>
4752
<Text className="text-center text-base text-foreground-muted">
48-
{Platform.OS === "android"
49-
? "Choose a thread from the sidebar or start a new thread."
50-
: "Choose a thread from the sidebar or start a new task."}
53+
{pullRequests
54+
? "Choose a pull request from the sidebar to review it."
55+
: Platform.OS === "android"
56+
? "Choose a thread from the sidebar or start a new thread."
57+
: "Choose a thread from the sidebar or start a new task."}
5158
</Text>
52-
{props.onStartNewTask ? (
59+
{props.onStartNewTask && !pullRequests ? (
5360
Platform.OS === "android" ? (
5461
<NewThreadButton extended className="mt-2" onPress={props.onStartNewTask} />
5562
) : (

‎apps/mobile/src/features/layout/createWorkspaceStackNavigator.ios.tsx‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,7 @@ function WorkspaceColumns(
280280
/>
281281
<ColumnContent>
282282
<WorkspaceEmptyDetail
283+
tab={selectedTab}
283284
onStartNewTask={
284285
// The detail bar or a visible sidebar already carries compose.
285286
detailCompose || panes.primarySidebarVisible ? undefined : openNewTask

0 commit comments

Comments
 (0)