Skip to content

Commit c1c3539

Browse files
only21milclaude
andcommitted
fix(server): clear unreachable preview downloads after a server restart
The server browser indexes saved downloads in memory and server tab ids carry a per-process epoch, so files an earlier run saved under server-browser/downloads can never be opened again. Tab close removes its own folder, but a stop or crash leaves the rest on disk for good. Clear the downloads folder when the service starts, before any tab can save. The server ownership lock guarantees one server per state directory, so no other live server owns these files. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 62245d8 commit c1c3539

2 files changed

Lines changed: 27 additions & 0 deletions

File tree

‎apps/server/src/preview/ServerBrowser.test.ts‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1057,6 +1057,27 @@ it.live.each(["save failed", "oversized"])(
10571057
).pipe(Effect.provide(layer)),
10581058
);
10591059

1060+
it.live("a restarted server removes the previous run's downloads and keeps its profiles", () =>
1061+
Effect.scoped(
1062+
Effect.gen(function* () {
1063+
const { stateDir } = yield* ServerConfig.ServerConfig;
1064+
const fs = yield* FileSystem.FileSystem;
1065+
const path = yield* Path.Path;
1066+
const previousTab = path.join(stateDir, "server-browser", "downloads", "previous-tab");
1067+
const profile = path.join(stateDir, "server-browser", "profiles", "default");
1068+
yield* fs.makeDirectory(previousTab, { recursive: true });
1069+
yield* fs.makeDirectory(profile, { recursive: true });
1070+
yield* fs.writeFileString(path.join(previousTab, "report.csv"), "a,b");
1071+
yield* fs.writeFileString(path.join(profile, "Preferences"), "{}");
1072+
1073+
yield* Layer.build(ServerBrowser.layer);
1074+
1075+
expect(yield* fs.exists(previousTab)).toBe(false);
1076+
expect(yield* fs.readFileString(path.join(profile, "Preferences"))).toBe("{}");
1077+
}),
1078+
).pipe(Effect.provide(dependencies)),
1079+
);
1080+
10601081
it.live("a page's file picker goes to the controller and takes its uploaded files", () =>
10611082
Effect.scoped(
10621083
Effect.gen(function* () {

‎apps/server/src/preview/ServerBrowser.ts‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -903,6 +903,12 @@ const make = Effect.gen(function* () {
903903
};
904904

905905
const downloadsRoot = NodePath.join(config.stateDir, "server-browser", "downloads");
906+
// Saved downloads are indexed in memory, so an earlier run's files can never be opened again.
907+
yield* Effect.tryPromise(() => NodeFSP.rm(downloadsRoot, { recursive: true, force: true })).pipe(
908+
Effect.catch((cause) =>
909+
Effect.logWarning("server preview could not clear earlier downloads", { cause }),
910+
),
911+
);
906912
// Tab ids are opaque server strings; hashing keeps them out of the path.
907913
const downloadDir = (tab: ServerTab) =>
908914
NodePath.join(

0 commit comments

Comments
 (0)