Skip to content

Commit c099f5a

Browse files
committed
fix(codex): preserve memory approval cleanup
1 parent d01509b commit c099f5a

2 files changed

Lines changed: 14 additions & 0 deletions

File tree

‎apps/server/src/provider/Layers/CodexSessionRuntime.test.ts‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -369,6 +369,16 @@ describe("makeMemoryConsolidationNotificationFilter", () => {
369369
}),
370370
true,
371371
);
372+
NodeAssert.equal(
373+
shouldSuppress({
374+
method: "serverRequest/resolved",
375+
params: {
376+
requestId: "memory-approval",
377+
threadId: "memory-thread",
378+
},
379+
}),
380+
false,
381+
);
372382
NodeAssert.equal(
373383
shouldSuppress({
374384
method: "warning",

‎apps/server/src/provider/Layers/CodexSessionRuntime.ts‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -573,6 +573,10 @@ export function makeMemoryConsolidationNotificationFilter(): (
573573
return false;
574574
}
575575

576+
if (notification.method === "serverRequest/resolved") {
577+
return false;
578+
}
579+
576580
if (notification.method === "thread/closed") {
577581
threadIds.delete(threadId);
578582
}

0 commit comments

Comments
 (0)