Skip to content

Commit bff09dc

Browse files
feat(web): hide test files in the pull request Code tab
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 67999fd commit bff09dc

4 files changed

Lines changed: 54 additions & 11 deletions

File tree

‎apps/mobile/src/features/pull-requests/PullRequestRouteScreen.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ import {
4141
pullRequestDiffInitialPosition,
4242
} from "./pullRequestDiffDebug";
4343
import { usePullRequestDiffHighlightFiles } from "./usePullRequestDiffHighlightFiles";
44-
import { isPullRequestTestFile } from "./pullRequestFileFilters";
44+
import { isTestChangedFile } from "@t3tools/shared/changedFileKind";
4545
import { useFocusEffect, useNavigation, type StaticScreenProps } from "@react-navigation/native";
4646
import type { NativeStackNavigationProp } from "@react-navigation/native-stack";
4747
import { RegistryContext, useAtomRefresh, useAtomValue } from "@effect/atom-react";
@@ -1035,7 +1035,7 @@ function PullRequestFileRouteContent({ route }: PullRequestFileRouteProps) {
10351035
const jumpedUnder = useRef<boolean | null>(filter.hideTestFiles);
10361036
const hasTestFiles =
10371037
result.parsed.kind === "files" &&
1038-
result.parsed.files.some((file) => isPullRequestTestFile(file.path));
1038+
result.parsed.files.some((file) => isTestChangedFile(file.path));
10391039
const jumpStarted = () =>
10401040
jumpedUnder.current !== null && (!hasTestFiles || jumpedUnder.current === filter.hideTestFiles);
10411041
const scrollToFile = (fileId: string) => {

‎apps/mobile/src/features/pull-requests/pullRequestFileFilters.ts‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,14 @@
1-
import { classifyChangedFile } from "@t3tools/shared/changedFileKind";
1+
import { isTestChangedFile } from "@t3tools/shared/changedFileKind";
22
import type { ReviewParsedDiff } from "../review/reviewModel";
33

4-
/** Test support such as fixtures and snapshots is hidden along with the tests. */
5-
export function isPullRequestTestFile(path: string): boolean {
6-
const kind = classifyChangedFile(path);
7-
return kind === "tests" || kind === "mocks";
8-
}
9-
104
export function filterPullRequestTestFiles(
115
parsed: ReviewParsedDiff,
126
hideTestFiles: boolean,
137
includePath?: string,
148
): ReviewParsedDiff {
159
if (!hideTestFiles || parsed.kind !== "files") return parsed;
1610
const files = parsed.files.filter(
17-
(file) => file.path === includePath || !isPullRequestTestFile(file.path),
11+
(file) => file.path === includePath || !isTestChangedFile(file.path),
1812
);
1913
if (files.length === parsed.files.length) return parsed;
2014
return {

‎apps/web/src/components/pullRequest/PullRequestCodeTab.tsx‎

Lines changed: 45 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import {
1919
ChevronDownIcon,
2020
ChevronRightIcon,
2121
Columns2Icon,
22+
FlaskConicalOffIcon,
2223
FolderTreeIcon,
2324
InfoIcon,
2425
MessageSquareOffIcon,
@@ -51,6 +52,7 @@ import {
5152
canEditPullRequestComment,
5253
canResolvePullRequestThread,
5354
} from "@t3tools/client-runtime/pull-request-editing";
55+
import { isTestChangedFile } from "@t3tools/shared/changedFileKind";
5456
import { orderDiffFiles } from "./pullRequestFileOrder.logic";
5557
import {
5658
buildFileDiffRenderKey,
@@ -134,6 +136,7 @@ type ReviewAnnotation = DiffLineAnnotation<ReviewAnnotationGroup>;
134136
const COMMIT_PAGE_SIZE = 10;
135137

136138
const PULL_REQUEST_FILE_TREE_STORAGE_KEY = "t3code.pullRequestFileTreeOpen";
139+
const PULL_REQUEST_HIDE_TEST_FILES_STORAGE_KEY = "t3code.pullRequestHideTestFiles";
137140

138141
interface DiffSlice {
139142
readonly source: PullRequestDiffResult;
@@ -307,6 +310,11 @@ function PullRequestCodeTab({
307310
false,
308311
Schema.Boolean,
309312
);
313+
const [hideTestFiles, setHideTestFiles] = useLocalStorage(
314+
PULL_REQUEST_HIDE_TEST_FILES_STORAGE_KEY,
315+
false,
316+
Schema.Boolean,
317+
);
310318
const [selectedLines, setSelectedLines] = useState<{
311319
id: string;
312320
range: SelectedLineRange;
@@ -496,11 +504,22 @@ function PullRequestCodeTab({
496504
ignoreWhitespace,
497505
),
498506
);
499-
const files = orderDiffFilesLikeTree(
507+
const loadedFiles = orderDiffFilesLikeTree(
500508
parsedSlices.flatMap((parsed) =>
501509
parsed?.kind === "files" ? orderDiffFiles(parsed.files) : [],
502510
),
503511
);
512+
const testFileCount = loadedFiles.filter((file) =>
513+
isTestChangedFile(resolveFileDiffPath(file)),
514+
).length;
515+
// A requested file stays visible so a jump to a hidden test still lands.
516+
const files = hideTestFiles
517+
? loadedFiles.filter((file) => {
518+
const path = resolveFileDiffPath(file);
519+
return path === revealRequest?.path || !isTestChangedFile(path);
520+
})
521+
: loadedFiles;
522+
const hiddenTestFileCount = loadedFiles.length - files.length;
504523
const filePaths = files.map((file) => resolveFileDiffPath(file));
505524
const omittedFileStats = new Map(
506525
loadedSlices.flatMap((slice) =>
@@ -1073,6 +1092,11 @@ function PullRequestCodeTab({
10731092
{files.length} {files.length === 1 ? "file" : "files"}
10741093
{nextCursor === null ? "" : "+"}
10751094
</span>
1095+
{hiddenTestFileCount > 0 ? (
1096+
<Button type="button" size="xs" variant="link" onClick={() => setHideTestFiles(false)}>
1097+
{hiddenTestFileCount} test {hiddenTestFileCount === 1 ? "file" : "files"} hidden
1098+
</Button>
1099+
) : null}
10761100
{filesViewed.enabled && files.length > 0 ? (
10771101
<span className="flex min-w-0 items-center gap-1 tabular-nums">
10781102
<span className="shrink-0">
@@ -1285,6 +1309,26 @@ function PullRequestCodeTab({
12851309
</TooltipPopup>
12861310
</Tooltip>
12871311
) : null}
1312+
{testFileCount > 0 ? (
1313+
<Tooltip>
1314+
<TooltipTrigger
1315+
render={
1316+
<Toggle
1317+
aria-label="Hide test files"
1318+
variant="ghost"
1319+
size="sm"
1320+
pressed={hideTestFiles}
1321+
onPressedChange={(pressed) => setHideTestFiles(Boolean(pressed))}
1322+
/>
1323+
}
1324+
>
1325+
<FlaskConicalOffIcon className="size-3.5" />
1326+
</TooltipTrigger>
1327+
<TooltipPopup side="top">
1328+
{hideTestFiles ? "Show test files" : "Hide test files"}
1329+
</TooltipPopup>
1330+
</Tooltip>
1331+
) : null}
12881332
{fileKeys.length > 0 ? (
12891333
<Tooltip>
12901334
<TooltipTrigger

‎packages/shared/src/changedFileKind.ts‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,11 @@ const NOT_DOCS_NAME = /^(requirements.*|constraints.*|CMakeLists|robots|llms)\.t
6767
* output count as generated, and test support (mocks, fixtures, snapshots) is kept apart from the
6868
* tests themselves, and prose (Markdown, plain text) is its own kind, so a reviewer can see how much of a change is logic.
6969
*/
70+
export function isTestChangedFile(path: string): boolean {
71+
const kind = classifyChangedFile(path);
72+
return kind === "tests" || kind === "mocks";
73+
}
74+
7075
export function classifyChangedFile(path: string): ChangedFileKind {
7176
const segments = path.replaceAll("\\", "/").split("/");
7277
const name = segments.pop() ?? "";

0 commit comments

Comments
 (0)