Skip to content

Commit bfb3884

Browse files
authored
fix(ui): snooze menu times match the menu's typography (#30596)
1 parent c52df24 commit bfb3884

2 files changed

Lines changed: 15 additions & 2 deletions

File tree

‎apps/web/src/components/sidebar/SidebarThreadRow.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ import { shouldShowInstanceBadge, type ProviderInstanceEntry } from "../../provi
110110
import { useThreadRunningTerminalIds } from "../../state/terminalSessions";
111111
import { InlineButton } from "../ui/button";
112112
import { Kbd } from "../ui/kbd";
113-
import { Menu, MenuItem, MenuPopup, MenuSeparator, MenuShortcut, MenuTrigger } from "../ui/menu";
113+
import { Menu, MenuItem, MenuItemDetail, MenuPopup, MenuSeparator, MenuTrigger } from "../ui/menu";
114114
import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip";
115115
import { MiddleTruncate } from "../ui/middle-truncate";
116116
import { useThreadHasUnsentDraft } from "../../composerDraftStore";
@@ -411,7 +411,7 @@ function SnoozeMenuButton(props: {
411411
}}
412412
>
413413
{preset.label}
414-
<MenuShortcut>{preset.whenLabel}</MenuShortcut>
414+
<MenuItemDetail>{preset.whenLabel}</MenuItemDetail>
415415
</MenuItem>
416416
))}
417417
{presets.length > 0 ? <MenuSeparator /> : null}

‎apps/web/src/components/ui/menu.tsx‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -307,6 +307,18 @@ function MenuShortcut({ className, ...props }: React.ComponentProps<"kbd">) {
307307
);
308308
}
309309

310+
// Trailing value on a menu row, such as the time a snooze preset wakes at.
311+
// Reads as text at the row's size; MenuShortcut is only for key chords.
312+
function MenuItemDetail({ className, ...props }: React.ComponentProps<"span">) {
313+
return (
314+
<span
315+
className={cn("ms-auto shrink-0 ps-4 text-secondary-label tabular-nums", className)}
316+
data-slot="menu-item-detail"
317+
{...props}
318+
/>
319+
);
320+
}
321+
310322
function MenuSub(props: MenuPrimitive.SubmenuRoot.Props) {
311323
return <MenuPrimitive.SubmenuRoot data-slot="menu-sub" {...props} />;
312324
}
@@ -390,6 +402,7 @@ export {
390402
MenuGroupLabel as DropdownMenuLabel,
391403
MenuSeparator,
392404
MenuSeparator as DropdownMenuSeparator,
405+
MenuItemDetail,
393406
MenuShortcut,
394407
MenuShortcut as DropdownMenuShortcut,
395408
MenuSub,

0 commit comments

Comments
 (0)