Skip to content

Commit bed9111

Browse files
juliusmarmingecodex
andcommitted
Fix nightly desktop product name
Co-authored-by: codex <[email protected]>
1 parent 409ff90 commit bed9111

2 files changed

Lines changed: 13 additions & 3 deletions

File tree

‎scripts/build-desktop-artifact.test.ts‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { ConfigProvider, Effect, Option } from "effect";
55
import {
66
resolveBuildOptions,
77
resolveDesktopBuildIconAssets,
8+
resolveDesktopProductName,
89
resolveDesktopUpdateChannel,
910
resolveMockUpdateServerPort,
1011
resolveMockUpdateServerUrl,
@@ -17,6 +18,11 @@ it.layer(NodeServices.layer)("build-desktop-artifact", (it) => {
1718
assert.equal(resolveDesktopUpdateChannel("0.0.17"), "latest");
1819
});
1920

21+
it("switches desktop packaging product names to nightly for nightly builds", () => {
22+
assert.equal(resolveDesktopProductName("0.0.17"), "T3 Code (Alpha)");
23+
assert.equal(resolveDesktopProductName("0.0.17-nightly.20260413.42"), "T3 Code (Nightly)");
24+
});
25+
2026
it("switches desktop packaging icons to the nightly artwork for nightly versions", () => {
2127
assert.deepStrictEqual(resolveDesktopBuildIconAssets("0.0.17"), {
2228
macIconPng: BRAND_ASSET_PATHS.productionMacIconPng,

‎scripts/build-desktop-artifact.ts‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -503,18 +503,23 @@ export function resolveMockUpdateServerUrl(mockUpdateServerPort: number | undefi
503503
return `http://localhost:${mockUpdateServerPort ?? 3000}`;
504504
}
505505

506+
export function resolveDesktopProductName(version: string): string {
507+
return resolveDesktopUpdateChannel(version) === "nightly"
508+
? "T3 Code (Nightly)"
509+
: (desktopPackageJson.productName ?? "T3 Code");
510+
}
511+
506512
const createBuildConfig = Effect.fn("createBuildConfig")(function* (
507513
platform: typeof BuildPlatform.Type,
508514
target: string,
509-
productName: string,
510515
version: string,
511516
signed: boolean,
512517
mockUpdates: boolean,
513518
mockUpdateServerPort: number | undefined,
514519
) {
515520
const buildConfig: Record<string, unknown> = {
516521
appId: "com.t3tools.t3code",
517-
productName,
522+
productName: resolveDesktopProductName(version),
518523
artifactName: "T3-Code-${version}-${arch}.${ext}",
519524
directories: {
520525
buildResources: "apps/desktop/resources",
@@ -732,7 +737,6 @@ const buildDesktopArtifact = Effect.fn("buildDesktopArtifact")(function* (
732737
build: yield* createBuildConfig(
733738
options.platform,
734739
options.target,
735-
desktopPackageJson.productName ?? "T3 Code",
736740
appVersion,
737741
options.signed,
738742
options.mockUpdates,

0 commit comments

Comments
 (0)