You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit be9bac7
Browse filesBrowse the repository at this point in the historyBrowse files
fix(web): SSH password prompts wait for their dialog, and the app shell drops its sync effects
SSH password prompts that the desktop sent while the prompt dialog was not
mounted (pairing, sign-in, or any page outside the authenticated shell) were
dropped, because the dialog only listened to the bridge from its own effect.
The queue now subscribes once at app start and the dialog reads it with
useSyncExternalStore.
The rest of the app shell's lifetime work moves to its real owners:
- background thread announcements, the legacy visited-time migration and the
main-app location tracker start in startAppServices instead of running from
effects (or a null component) inside AppSidebarLayout
- the confirm dialog treats a store subscriber as its host, so the host's
registration effect goes away
- the quit-hold hint and desktop-local bootstraps become external stores/atoms
- live regions attach through a ref callback, and Escape-to-go-back registers a
dispatcher observer from the page root's ref callback
- remote-capable editors are probed once per page by a keepAlive atom
Effects removed: 12 (SshPasswordPromptDialog 3, BackgroundThreadAnnouncer,
ConfirmDialogHost, QuitHoldOverlay, mainAppLocation, useDesktopLocalBootstraps,
useLiveRegion, useNavigateBack, useThreadVisitedMigration, remoteOpen 1 each).
The sidebar toggle effect in AppSidebarLayout stays: moving it needs a stable
toggle from the sidebar provider, which is a separate change.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
0 commit comments