Skip to content

Commit be5a5cd

Browse files
fix(mobile): use native sheet headers and toolbar filters (#22390)
Co-authored-by: Claude Opus 5.5 <[email protected]>
1 parent 81dea78 commit be5a5cd

5 files changed

Lines changed: 467 additions & 341 deletions

File tree

‎apps/mobile/src/Stack.tsx‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ import { AndroidWorkspaceTabsProvider } from "./features/workspace/AndroidWorksp
3939
import {
4040
PullRequestRouteScreen,
4141
PullRequestFileRouteScreen,
42-
PullRequestFilesRouteScreen,
4342
} from "./features/pull-requests/PullRequestRouteScreen";
43+
import { PullRequestFilesSheet } from "./features/pull-requests/PullRequestFiles";
4444
import { PullRequestReviewSheet } from "./features/pull-requests/PullRequestReviewSheet";
4545
import { PullRequestReviewersScreen } from "./features/pull-requests/PullRequestReviewersScreen";
4646
import {
@@ -729,12 +729,13 @@ const RootStackConfig = createWorkspaceStackNavigator({
729729
options: DETAIL_HEADER_OPTIONS,
730730
}),
731731
PullRequestFiles: createNativeStackScreen({
732-
screen: PullRequestFilesRouteScreen,
732+
screen: PullRequestFilesSheet,
733733
options: {
734+
...(Platform.OS === "ios" ? SHEET_GLASS_HEADER_OPTIONS : undefined),
734735
...FORM_SHEET_PRESENTATION_OPTIONS,
735736
sheetAllowedDetents: [0.6, 0.92],
736737
sheetGrabberVisible: true,
737-
headerShown: false,
738+
sheetCornerRadius: Platform.OS === "android" ? 28 : undefined,
738739
},
739740
}),
740741
PullRequestReviewers: createNativeStackScreen({
@@ -756,19 +757,18 @@ const RootStackConfig = createWorkspaceStackNavigator({
756757
options: {
757758
...(Platform.OS === "android"
758759
? { presentation: "fullScreenModal" as const }
759-
: FORM_SHEET_PRESENTATION_OPTIONS),
760+
: { ...SHEET_GLASS_HEADER_OPTIONS, ...FORM_SHEET_PRESENTATION_OPTIONS }),
760761
sheetAllowedDetents: Platform.OS === "android" ? undefined : [0.75, 0.92],
761762
sheetGrabberVisible: Platform.OS !== "android",
762-
headerShown: false,
763763
},
764764
}),
765765
PullRequestReview: createNativeStackScreen({
766766
screen: PullRequestReviewSheet,
767767
options: {
768+
...(Platform.OS === "ios" ? SHEET_GLASS_HEADER_OPTIONS : undefined),
768769
...FORM_SHEET_PRESENTATION_OPTIONS,
769770
sheetAllowedDetents: [0.75, 0.92],
770771
sheetGrabberVisible: true,
771-
headerShown: false,
772772
},
773773
}),
774774
Thread: createNativeStackScreen({
@@ -900,6 +900,7 @@ const RootStackConfig = createWorkspaceStackNavigator({
900900
screen: GitCommitSheet,
901901
linking: `${THREAD_LINKING_PREFIX}/git/commit`,
902902
options: {
903+
...(Platform.OS === "ios" ? SHEET_GLASS_HEADER_OPTIONS : undefined),
903904
...FORM_SHEET_PRESENTATION_OPTIONS,
904905
sheetAllowedDetents: [0.8, 0.92],
905906
sheetGrabberVisible: true,

0 commit comments

Comments
 (0)