Skip to content

Commit bc26b21

Browse files
fix(server): recheck live triggers during manual reservation
1 parent 83a6009 commit bc26b21

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

‎apps/server/src/scheduledTasks/ScheduledTaskService.ts‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -777,6 +777,11 @@ export const layer = Layer.effect(
777777
DateTime.toEpochMillis(parsedNextRunAt.value) > DateTime.toEpochMillis(startedAt))
778778
)
779779
return { task: active, running: false };
780+
if (trigger === "manual" && active.schedule.type === "webhook") {
781+
return yield* taskError("Webhook tasks run when their URL receives a request.", {
782+
taskId: active.id,
783+
});
784+
}
780785
if (webhook !== undefined) {
781786
const reason =
782787
active.createdAt !== task.createdAt
@@ -789,6 +794,7 @@ export const layer = Layer.effect(
789794
if (reason !== null) return yield* new WebhookDeliverySkipped({ reason });
790795
}
791796
yield* markRunning(active.id, startedAtIso);
797+
reservedAt = startedAtIso;
792798
return { task: active, running: true };
793799
}),
794800
)
@@ -809,7 +815,6 @@ export const layer = Layer.effect(
809815
}
810816
if (!reservedTask.running) return reservedTask.task;
811817
const active = reservedTask.task;
812-
reservedAt = startedAtIso;
813818
yield* notifyChanged;
814819

815820
const fireKey =

0 commit comments

Comments
 (0)