Skip to content

Commit bbfc047

Browse files
committed
ci: keep release smoke as its own job
In the background next to lint, its workspace install slowed knip from 39s to 69s, and it only runs on PRs that touch scripts, so folding it saved little.
1 parent 7d62dd0 commit bbfc047

1 file changed

Lines changed: 33 additions & 34 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 33 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ jobs:
3535
test_web: ${{ steps.detect.outputs.test_web }}
3636
test_server: ${{ steps.detect.outputs.test_server }}
3737
rust: ${{ steps.detect.outputs.rust }}
38+
release_smoke: ${{ steps.detect.outputs.release_smoke }}
3839
mobile_native: ${{ steps.detect.outputs.mobile_native }}
3940
steps:
4041
# Only the package manifests the script reads to build the dependency graph.
@@ -54,19 +55,14 @@ jobs:
5455
id: detect
5556
uses: ./.github/actions/ci-changes
5657

57-
# Lint and the desktop build keep separate runners so their checks can run
58-
# side by side. Typecheck shares the build's install, and release smoke shares
59-
# lint's install. Lint always runs and formats every file, docs included; it
60-
# gates release smoke itself rather than waiting ~15s for `changes`. The
61-
# `Check` job at the end of this file passes only when every other job passes
62-
# or was skipped by `changes`.
58+
# Lint and the desktop build each get a runner so they run side by side.
59+
# Typecheck shares the build's install. Lint always runs: it formats every
60+
# file, docs included. The `Check` job at the end of this file passes only
61+
# when every other job passes or was skipped by `changes`.
6362
lint:
6463
name: Lint
6564
runs-on: blacksmith-8vcpu-ubuntu-2404
6665
timeout-minutes: 10
67-
permissions:
68-
contents: read
69-
pull-requests: read
7066
steps:
7167
- name: Checkout
7268
uses: actions/checkout@v6
@@ -84,29 +80,13 @@ jobs:
8480
exit 1
8581
fi
8682
87-
- name: Detect affected jobs
88-
id: changes
89-
uses: ./.github/actions/ci-changes
90-
9183
- name: Setup Vite+
9284
uses: voidzero-dev/setup-vp@v1
9385
with:
9486
node-version-file: package.json
9587
cache: true
9688
run-install: true
9789

98-
# Runs in the background next to the lint steps, so merging it into this
99-
# job adds no time; the last step reports its result.
100-
- name: Start release smoke
101-
id: smoke
102-
if: steps.changes.outputs.release_smoke != 'false'
103-
run: |
104-
(
105-
set +e
106-
node scripts/release-smoke.ts
107-
echo "$?" > "$RUNNER_TEMP/smoke-status"
108-
) > "$RUNNER_TEMP/smoke.log" 2>&1 < /dev/null &
109-
11090
- name: Ensure Electron runtime is installed
11191
run: vp run --filter @t3tools/desktop ensure:electron
11292

@@ -117,15 +97,6 @@ jobs:
11797
- name: Check
11898
run: vp check
11999

120-
# Reports even when an earlier lint step failed, as its own job did.
121-
- name: Exercise release-only workflow steps
122-
if: ${{ !cancelled() && steps.smoke.outcome == 'success' }}
123-
timeout-minutes: 5
124-
run: |
125-
until test -s "$RUNNER_TEMP/smoke-status"; do sleep 1; done
126-
cat "$RUNNER_TEMP/smoke.log"
127-
exit "$(cat "$RUNNER_TEMP/smoke-status")"
128-
129100
build:
130101
name: Build and Typecheck
131102
needs: changes
@@ -499,6 +470,33 @@ jobs:
499470
- name: Lint mobile native sources
500471
run: vp run lint:mobile
501472

473+
release_smoke:
474+
name: Release Smoke
475+
needs: changes
476+
if: ${{ !cancelled() && needs.changes.outputs.release_smoke != 'false' }}
477+
runs-on: blacksmith-8vcpu-ubuntu-2404
478+
timeout-minutes: 10
479+
steps:
480+
- name: Checkout
481+
uses: actions/checkout@v6
482+
with:
483+
sparse-checkout: |
484+
/*
485+
!/.repos/
486+
sparse-checkout-cone-mode: false
487+
488+
- name: Setup Vite+
489+
uses: voidzero-dev/setup-vp@v1
490+
with:
491+
node-version-file: package.json
492+
cache: true
493+
run-install: |
494+
args:
495+
- --filter=@t3tools/scripts...
496+
497+
- name: Exercise release-only workflow steps
498+
run: node scripts/release-smoke.ts
499+
502500
# Branch protection requires this job by its name, `Check`. It fails when any
503501
# other job fails, is cancelled, or is skipped without a reason, so splitting
504502
# or resharding jobs needs no ruleset change. Add every new job to `needs`.
@@ -518,6 +516,7 @@ jobs:
518516
transfer-report,
519517
rust,
520518
mobile_native_static_analysis,
519+
release_smoke,
521520
]
522521
runs-on: blacksmith-2vcpu-ubuntu-2404
523522
timeout-minutes: 5

0 commit comments

Comments
 (0)