Skip to content

Commit bb9fe60

Browse files
refactor(mobile): keep review reset hashing private
1 parent eced382 commit bb9fe60

3 files changed

Lines changed: 10 additions & 13 deletions

File tree

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { describe, expect, it } from "vite-plus/test";
22

3-
import { buildNativeReviewTokensResetKey, hashReviewDiffKey } from "./reviewDiffBridgeKeys";
3+
import { buildNativeReviewTokensResetKey } from "./reviewDiffBridgeKeys";
44

55
describe("native review diff bridge", () => {
6-
it("builds stable reset keys from the rendered diff identity", () => {
6+
it("changes reset keys when the rendered diff identity changes", () => {
77
const input = {
88
threadKey: "env:thread",
99
sectionId: "turn:2",
@@ -13,15 +13,12 @@ describe("native review diff bridge", () => {
1313
rowCount: 4,
1414
};
1515

16-
expect(buildNativeReviewTokensResetKey(input)).toBe(buildNativeReviewTokensResetKey(input));
17-
expect(buildNativeReviewTokensResetKey({ ...input, rowCount: 5 })).not.toBe(
18-
buildNativeReviewTokensResetKey(input),
19-
);
20-
expect(buildNativeReviewTokensResetKey({ ...input, diff: null })).toContain(":empty:");
21-
});
16+
const resetKey = buildNativeReviewTokensResetKey(input);
2217

23-
it("includes diff length in the hash key to reduce accidental collisions", () => {
24-
expect(hashReviewDiffKey("abc")).toMatch(/^3:/);
25-
expect(hashReviewDiffKey("abcd")).toMatch(/^4:/);
18+
expect(
19+
buildNativeReviewTokensResetKey({ ...input, diff: "diff --git a/b.ts b/b.ts" }),
20+
).not.toBe(resetKey);
21+
expect(buildNativeReviewTokensResetKey({ ...input, rowCount: 5 })).not.toBe(resetKey);
22+
expect(buildNativeReviewTokensResetKey({ ...input, diff: null })).not.toBe(resetKey);
2623
});
2724
});

‎apps/mobile/src/features/review/reviewDiffBridgeKeys.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import type { NativeReviewDiffHighlightScheme } from "../diffs/nativeReviewDiffH
33
// Pure key-derivation helpers for the native review diff bridge. Kept free of
44
// react-native / hook imports so they stay unit-testable in node.
55

6-
export function hashReviewDiffKey(diff: string | null | undefined): string {
6+
function hashReviewDiffKey(diff: string | null | undefined): string {
77
if (!diff) {
88
return "empty";
99
}

‎apps/mobile/src/features/review/useNativeReviewDiffBridge.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { useNativeReviewDiffHighlighting } from "./useNativeReviewDiffHighlighti
88
import { buildNativeReviewTokensResetKey } from "./reviewDiffBridgeKeys";
99
import { useUniwindTheme } from "../../lib/useUniwindTheme";
1010

11-
export { buildNativeReviewTokensResetKey, hashReviewDiffKey } from "./reviewDiffBridgeKeys";
11+
export { buildNativeReviewTokensResetKey } from "./reviewDiffBridgeKeys";
1212

1313
export function useNativeReviewDiffBridge(input: {
1414
readonly threadKey: string | null;

0 commit comments

Comments
 (0)