Skip to content

Commit ba78593

Browse files
committed
fix(web): refresh fold rows when deferred work changes
1 parent ecf9842 commit ba78593

2 files changed

Lines changed: 38 additions & 1 deletion

File tree

‎apps/web/src/components/chat/MessagesTimeline.logic.test.ts‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2969,6 +2969,35 @@ describe("v2 run and attempt history", () => {
29692969
});
29702970
});
29712971

2972+
it.each([
2973+
[undefined, ["first"]],
2974+
[["first"], ["second"]],
2975+
[["first"], []],
2976+
[
2977+
["first", "second"],
2978+
["second", "first"],
2979+
],
2980+
[undefined, []],
2981+
] as const)("keeps deferred fold anchors current from %j to %j", (before, after) => {
2982+
const row: Extract<MessagesTimelineRow, { kind: "turn-fold" }> = {
2983+
kind: "turn-fold",
2984+
id: "fold",
2985+
runId: RunId.make("run"),
2986+
createdAt: "2026-01-01T00:00:00Z",
2987+
label: "Worked for 1m",
2988+
expanded: true,
2989+
...(before === undefined ? {} : { deferredWorkItemIds: before }),
2990+
};
2991+
const previous = computeStableMessagesTimelineRows([row], { result: [], byId: new Map() });
2992+
const nextRow = { ...row, deferredWorkItemIds: after };
2993+
const next = computeStableMessagesTimelineRows([nextRow], previous);
2994+
const fold = next.result[0];
2995+
expect(fold?.kind === "turn-fold" ? (fold.deferredWorkItemIds ?? []) : null).toEqual(after);
2996+
expect(
2997+
computeStableMessagesTimelineRows([{ ...nextRow, deferredWorkItemIds: [...after] }], next),
2998+
).toBe(next);
2999+
});
3000+
29723001
describe("streaming v2 row projection", () => {
29733002
function fixture(text = "") {
29743003
const source = makeStreamingTimelineFixture(text);

‎apps/web/src/components/chat/MessagesTimeline.logic.ts‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2312,7 +2312,15 @@ function isRowUnchanged(a: MessagesTimelineRow, b: MessagesTimelineRow): boolean
23122312

23132313
case "turn-fold": {
23142314
const bf = b as typeof a;
2315-
return a.createdAt === bf.createdAt && a.label === bf.label && a.expanded === bf.expanded;
2315+
const anchors = a.deferredWorkItemIds ?? [];
2316+
const nextAnchors = bf.deferredWorkItemIds ?? [];
2317+
return (
2318+
a.createdAt === bf.createdAt &&
2319+
a.label === bf.label &&
2320+
a.expanded === bf.expanded &&
2321+
anchors.length === nextAnchors.length &&
2322+
anchors.every((id, index) => id === nextAnchors[index])
2323+
);
23162324
}
23172325

23182326
case "attempt-fold": {

0 commit comments

Comments
 (0)