Skip to content

Commit b78296a

Browse files
perf(web): the traits picker compiles without manual memoization (#20540)
Co-authored-by: Claude Opus 5.5 <[email protected]>
1 parent d94ea2c commit b78296a

1 file changed

Lines changed: 16 additions & 19 deletions

File tree

‎apps/web/src/components/chat/TraitsPicker.tsx‎

Lines changed: 16 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import {
1616
isClaudeUltrathinkPrompt,
1717
normalizeModelSlug,
1818
} from "@t3tools/shared/model";
19-
import { memo, useCallback } from "react";
19+
import { memo } from "react";
2020
import { BrainIcon } from "lucide-react";
2121
import {
2222
Menu,
@@ -296,24 +296,21 @@ export const TraitsMenuContent = memo(function TraitsMenuContentImpl({
296296
const modelSelection =
297297
instanceId && model ? { instanceId, model, options: modelOptions ?? [] } : null;
298298
const setProviderModelOptions = useComposerDraftStore((store) => store.setProviderModelOptions);
299-
const updateModelOptions = useCallback(
300-
(nextOptions: ProviderOptions | undefined) => {
301-
if ("onModelOptionsChange" in persistence) {
302-
persistence.onModelOptionsChange(nextOptions);
303-
return;
304-
}
305-
const threadTarget = persistence.threadRef ?? persistence.draftId;
306-
if (!threadTarget) {
307-
return;
308-
}
309-
setProviderModelOptions(threadTarget, provider, nextOptions, {
310-
...(instanceId ? { instanceId } : {}),
311-
model,
312-
persistSticky: true,
313-
});
314-
},
315-
[instanceId, model, persistence, provider, setProviderModelOptions],
316-
);
299+
const updateModelOptions = (nextOptions: ProviderOptions | undefined) => {
300+
if ("onModelOptionsChange" in persistence) {
301+
persistence.onModelOptionsChange(nextOptions);
302+
return;
303+
}
304+
const threadTarget = persistence.threadRef ?? persistence.draftId;
305+
if (!threadTarget) {
306+
return;
307+
}
308+
setProviderModelOptions(threadTarget, provider, nextOptions, {
309+
...(instanceId ? { instanceId } : {}),
310+
model,
311+
persistSticky: true,
312+
});
313+
};
317314
const {
318315
descriptors,
319316
selectDescriptors,

0 commit comments

Comments
 (0)