Skip to content

Commit b6aab96

Browse files
committed
fix(web): restore settled PR colors on hover
1 parent 8b2838e commit b6aab96

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

‎apps/web/src/components/Sidebar.tsx‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1468,9 +1468,7 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: {
14681468
// number from reflowing as PR states stream in.
14691469
"shrink-0 text-xs tabular-nums hover:underline",
14701470
variant === "slim" && variantAction === "unsettle"
1471-
? props.isActive
1472-
? "text-secondary-label"
1473-
: cn("text-secondary-label transition-colors", settledPrHoverClass)
1471+
? cn("text-secondary-label transition-colors", settledPrHoverClass)
14741472
: prStatus.colorClass,
14751473
)}
14761474
aria-label={prStatus.tooltip}

‎apps/web/src/components/ThreadStatusIndicators.test.ts‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,12 @@ describe("settledPrHoverColorClass", () => {
125125
["merged", "text-violet-600"],
126126
["closed", "text-red-600"],
127127
] as const)("restores the %s pull request color on row hover", (state, colorClass) => {
128-
expect(settledPrHoverColorClass(state)).toContain(`group-hover/v2-row:${colorClass}`);
128+
expect(settledPrHoverColorClass(state)).toContain(`group-hover/sidebar-row:${colorClass}`);
129129
});
130130

131131
it("keeps draft pull requests gray on row hover", () => {
132-
expect(settledPrHoverColorClass("open", true)).toContain("group-hover/v2-row:text-zinc-500");
132+
expect(settledPrHoverColorClass("open", true)).toContain(
133+
"group-hover/sidebar-row:text-zinc-500",
134+
);
133135
});
134136
});

‎apps/web/src/components/ThreadStatusIndicators.tsx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,13 @@ export function settledPrHoverColorClass(
8686
switch (state) {
8787
case "open":
8888
if (isDraft) {
89-
return "group-hover/v2-row:text-zinc-500 dark:group-hover/v2-row:text-zinc-400/80";
89+
return "group-hover/sidebar-row:text-zinc-500 dark:group-hover/sidebar-row:text-zinc-400/80";
9090
}
91-
return "group-hover/v2-row:text-emerald-600 dark:group-hover/v2-row:text-emerald-300/90";
91+
return "group-hover/sidebar-row:text-emerald-600 dark:group-hover/sidebar-row:text-emerald-300/90";
9292
case "merged":
93-
return "group-hover/v2-row:text-violet-600 dark:group-hover/v2-row:text-violet-300/90";
93+
return "group-hover/sidebar-row:text-violet-600 dark:group-hover/sidebar-row:text-violet-300/90";
9494
case "closed":
95-
return "group-hover/v2-row:text-red-600 dark:group-hover/v2-row:text-red-300/90";
95+
return "group-hover/sidebar-row:text-red-600 dark:group-hover/sidebar-row:text-red-300/90";
9696
}
9797
}
9898

0 commit comments

Comments
 (0)