Skip to content

Commit b6a7297

Browse files
committed
fix(web): use three-dot approval menu with ghost actions
1 parent b6a2fe4 commit b6a7297

2 files changed

Lines changed: 13 additions & 9 deletions

File tree

‎apps/web/src/components/chat/ComposerPendingApprovalActions.tsx‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import {
44
type ProviderApprovalOption,
55
} from "@t3tools/contracts";
66
import { memo } from "react";
7-
import { ChevronRightIcon, TriangleAlertIcon } from "lucide-react";
8-
import { Button, buttonVariants } from "../ui/button";
7+
import { EllipsisIcon, TriangleAlertIcon } from "lucide-react";
8+
import { Button } from "../ui/button";
99
import { Menu, MenuItem, MenuPopup, MenuTrigger } from "../ui/menu";
1010
import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip";
1111
import { composerFloatingLayerProps } from "./composerEventScope";
@@ -73,7 +73,7 @@ export const ComposerPendingApprovalActions = memo(function ComposerPendingAppro
7373
disabled={isResponding}
7474
render={<Button size="icon-xs" variant="outline" aria-label="More approval options" />}
7575
>
76-
<ChevronRightIcon />
76+
<EllipsisIcon />
7777
</MenuTrigger>
7878
<MenuPopup
7979
{...composerFloatingLayerProps}
@@ -88,11 +88,8 @@ export const ComposerPendingApprovalActions = memo(function ComposerPendingAppro
8888
disabled={isResponding}
8989
aria-description={option.warning}
9090
onClick={() => void onRespondToApproval(requestId, option.decision)}
91-
className={buttonVariants({
92-
variant: "outline",
93-
size: "compact",
94-
className: "mb-1 h-auto min-h-7 w-full last:mb-0 sm:text-xs",
95-
})}
91+
variant="ghost"
92+
className="mb-1 last:mb-0"
9693
>
9794
{option.warning ? <TriangleAlertIcon className="size-3 text-warning" /> : null}
9895
<span className="min-w-0 whitespace-normal wrap-break-word">{option.label}</span>

‎apps/web/src/components/ui/menu.tsx‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { CheckIcon, ChevronRightIcon } from "lucide-react";
55
import type * as React from "react";
66

77
import { cn } from "~/lib/utils";
8+
import { buttonVariants } from "./button";
89

910
const MenuCreateHandle = MenuPrimitive.createHandle;
1011

@@ -81,12 +82,18 @@ function MenuItem({
8182
...props
8283
}: MenuPrimitive.Item.Props & {
8384
inset?: boolean;
84-
variant?: "default" | "destructive";
85+
variant?: "default" | "destructive" | "ghost";
8586
}) {
8687
return (
8788
<MenuPrimitive.Item
8889
className={cn(
8990
"[&>svg]:-mx-0.5 flex min-h-8 cursor-pointer select-none items-center gap-2 rounded-sm px-2 py-1 text-base text-foreground outline-none data-disabled:pointer-events-none data-disabled:cursor-not-allowed data-highlighted:bg-accent data-inset:ps-8 data-[variant=destructive]:text-destructive-foreground data-highlighted:text-accent-foreground data-disabled:opacity-64 sm:min-h-7 sm:text-sm [&>svg:not([class*='opacity-'])]:opacity-80 [&>svg:not([class*='size-'])]:size-4.5 sm:[&>svg:not([class*='size-'])]:size-4 [&>svg:not([class*='text-'])]:text-muted-foreground data-[variant=destructive]:[&>svg:not([class*='text-'])]:text-current [&>svg]:pointer-events-none [&>svg]:shrink-0",
91+
variant === "ghost" &&
92+
buttonVariants({
93+
variant: "ghost",
94+
size: "compact",
95+
className: "h-auto min-h-7 w-full sm:text-xs",
96+
}),
9097
className,
9198
)}
9299
data-inset={inset}

0 commit comments

Comments
 (0)