Skip to content

Commit b6a56a4

Browse files
juliusmarmingejaviergusartclaude
committed
fix(antigravity): keep Windows runtime unpacking under MAX_PATH
#12008 pointed the agent's TEMP at a per-process directory under the provider profile. On Windows that profile already sits ~120 characters deep, and the PyInstaller bundle unpacks members up to 120 characters long, so the deepest file lands at 278+ characters. Without long paths enabled the bootloader fails to extract it and exits before ACP starts, which surfaces as a failed Google sign-in, a health check that never leaves "not checked yet", or "ACP process exited with code 4294967295" at session start. Managed install validation used a short system temp profile, so installs still passed. Root the Windows runtime temp at <system temp>\t3-agy\<profile hash>, keep the per-process run- directories and the driver-start sweep, sweep the old in-profile root once, and remove the validation run's directory now that it no longer lives inside the disposable profile. Co-Authored-By: javiergusart <[email protected]> Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
1 parent e67abcf commit b6a56a4

7 files changed

Lines changed: 136 additions & 23 deletions

File tree

‎apps/server/src/provider/AntigravityInstallation.test.ts‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import {
55
HostProcessEnvironment,
66
HostProcessIsExecutable,
77
HostProcessPlatform,
8+
HostProcessTempDirectory,
89
} from "@t3tools/shared/hostProcess";
910
import * as Deferred from "effect/Deferred";
1011
import * as Effect from "effect/Effect";
@@ -332,6 +333,7 @@ it.layer(NodeServices.layer)("Antigravity installation", (it) => {
332333
);
333334
const methods: string[] = [];
334335
const profiles = new Set<string>();
336+
const runtimeTempDirectories = new Set<string>();
335337
let closedRuntimes = 0;
336338
const spawner = ChildProcessSpawner.make(
337339
Effect.fn("test.spawnAntigravityValidator")(function* (command) {
@@ -342,6 +344,8 @@ it.layer(NodeServices.layer)("Antigravity installation", (it) => {
342344
if (!profile) return yield* Effect.die("Expected a disposable validation profile.");
343345
profiles.add(profile);
344346
const helper = command.args[0] === "-e";
347+
const runtimeTemp = command.options.env?.TEMP ?? command.options.env?.TMPDIR;
348+
if (!helper && runtimeTemp) runtimeTempDirectories.add(runtimeTemp);
345349
const output = yield* Queue.unbounded<Uint8Array>();
346350
const exited = yield* Deferred.make<ChildProcessSpawner.ExitCode>();
347351
const terminate = Deferred.succeed(exited, ChildProcessSpawner.ExitCode(0)).pipe(
@@ -415,10 +419,17 @@ it.layer(NodeServices.layer)("Antigravity installation", (it) => {
415419
});
416420
}),
417421
);
422+
const systemTemp = yield* fs.makeTempDirectoryScoped({ prefix: "t3-agy-validate-temp-" });
418423
const { installation, stagingReleased } = yield* makeHarness({
419424
previous: true,
420425
useDefaultValidation: true,
421-
}).pipe(Effect.provideService(ChildProcessSpawner.ChildProcessSpawner, spawner));
426+
platform: "win32",
427+
archive: Buffer.from(zipFixtures.windows, "base64"),
428+
}).pipe(
429+
Effect.provideService(ChildProcessSpawner.ChildProcessSpawner, spawner),
430+
// Windows unpacks outside the profile, so its removal is not implied.
431+
Effect.provideService(HostProcessTempDirectory, systemTemp),
432+
);
422433
yield* installation.start;
423434
expect((yield* terminalState(installation)).phase).toBe(
424435
testCase.valid ? "succeeded" : "failed",
@@ -427,8 +438,9 @@ it.layer(NodeServices.layer)("Antigravity installation", (it) => {
427438
expect(methods).toEqual(["initialize"]);
428439
expect(closedRuntimes).toBe(1);
429440
expect(profiles.size).toBe(1);
430-
for (const profile of profiles) {
431-
expect(yield* fs.exists(profile)).toBe(false);
441+
expect(runtimeTempDirectories.size).toBe(1);
442+
for (const directory of [...profiles, ...runtimeTempDirectories]) {
443+
expect(yield* fs.exists(directory)).toBe(false);
432444
}
433445
if (testCase.valid) {
434446
expect((yield* installation.resolve()).version).toBe("fixture-new");

‎apps/server/src/provider/AntigravityInstallation.ts‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -477,6 +477,11 @@ export const makeAntigravityInstallation = Effect.fn("AntigravityInstallation.ma
477477
platform,
478478
baseEnv: environment,
479479
});
480+
// Windows keeps runtime temp outside the profile. Remove it after the
481+
// process exits; this profile, and so its temp directory, is unique.
482+
yield* Effect.addFinalizer(() =>
483+
fs.remove(profile.tempDirectory, { recursive: true, force: true }).pipe(Effect.ignore),
484+
);
480485
const runtime = yield* makeAntigravityAcpRuntime({
481486
spawn: buildAntigravityAcpSpawnInput({
482487
installation: executable,

‎apps/server/src/provider/Drivers/AntigravityDriver.test.ts‎

Lines changed: 28 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010
HostProcessExecutablePath,
1111
HostProcessIsExecutable,
1212
HostProcessPlatform,
13+
HostProcessTempDirectory,
1314
} from "@t3tools/shared/hostProcess";
1415
import * as Effect from "effect/Effect";
1516
import * as Deferred from "effect/Deferred";
@@ -475,7 +476,11 @@ it.layer(testLayer)("AntigravityDriver", (it) => {
475476
() =>
476477
Effect.gen(function* () {
477478
const h = yield* makeHarness();
478-
const tempRoot = resolveAntigravityRuntimeTempDirectory(h.profileDirectory);
479+
const tempRoot = resolveAntigravityRuntimeTempDirectory(
480+
h.profileDirectory,
481+
hostPlatform,
482+
yield* HostProcessTempDirectory,
483+
);
479484
yield* h.refresh();
480485
yield* h.refresh();
481486
const directories = h.launches.flatMap((launch) =>
@@ -490,20 +495,30 @@ it.layer(testLayer)("AntigravityDriver", (it) => {
490495
}).pipe(Effect.scoped),
491496
);
492497

493-
it.effect.skipIf(windowsHost)(
494-
"removes runtime temp directories left by a previous server on create",
495-
() =>
498+
// Posix host paths stand in for Windows ones: only the root choice differs.
499+
it.effect.each(["linux", "win32"] as const)(
500+
"removes runtime temp directories left by a previous server on create (%s)",
501+
(platform) =>
496502
Effect.gen(function* () {
503+
if (windowsHost) return;
497504
const fs = yield* FileSystem.FileSystem;
498505
const path = yield* Path.Path;
499506
const config = yield* ServerConfig;
500-
const instanceId = ProviderInstanceId.make("antigravity-orphan-sweep");
507+
const systemTemp = yield* fs.makeTempDirectoryScoped({ prefix: "t3-agy-system-temp-" });
508+
const instanceId = ProviderInstanceId.make(`antigravity-orphan-sweep-${platform}`);
509+
const profileDirectory = resolveAntigravityProfileDirectory(config.stateDir, instanceId);
501510
const tempRoot = resolveAntigravityRuntimeTempDirectory(
502-
resolveAntigravityProfileDirectory(config.stateDir, instanceId),
511+
profileDirectory,
512+
platform,
513+
systemTemp,
503514
);
504-
const orphan = path.join(tempRoot, "run-orphan", "_MEI123", "google3");
505-
yield* fs.makeDirectory(orphan, { recursive: true });
506-
yield* fs.writeFileString(path.join(orphan, "payload.bin"), "stale");
515+
// Windows unpacked under the profile before the root moved to the system temp.
516+
const legacyRoot = path.join(profileDirectory, "antigravity-acp", "tmp");
517+
for (const root of [tempRoot, legacyRoot]) {
518+
const orphan = path.join(root, "run-orphan", "_MEI123", "google3");
519+
yield* fs.makeDirectory(orphan, { recursive: true });
520+
yield* fs.writeFileString(path.join(orphan, "payload.bin"), "stale");
521+
}
507522
yield* AntigravityDriver.create({
508523
instanceId,
509524
displayName: "Sweep",
@@ -518,8 +533,12 @@ it.layer(testLayer)("AntigravityDriver", (it) => {
518533
acquire: () => Effect.die("unused"),
519534
}),
520535
),
536+
Effect.provideService(HostProcessPlatform, platform),
537+
Effect.provideService(HostProcessTempDirectory, systemTemp),
521538
);
522539
expect(yield* fs.exists(tempRoot)).toBe(false);
540+
expect(yield* fs.exists(legacyRoot)).toBe(false);
541+
expect(yield* fs.exists(systemTemp)).toBe(true);
523542
}).pipe(Effect.scoped),
524543
);
525544

‎apps/server/src/provider/Drivers/AntigravityDriver.ts‎

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { withAgentDeviceEnvironment } from "../../mcp/McpProviderSession.ts";
22
import { AntigravitySettings, ProviderDriverKind, ProviderSetupError } from "@t3tools/contracts";
3-
import { HostProcessPlatform } from "@t3tools/shared/hostProcess";
3+
import { HostProcessPlatform, HostProcessTempDirectory } from "@t3tools/shared/hostProcess";
44
import {
55
NodeRuntimeUnavailableError,
66
nodeRuntimeUnavailableMessage,
@@ -102,16 +102,27 @@ export const AntigravityDriver: ProviderDriver<AntigravitySettings, AntigravityD
102102
};
103103
const authConfigIssue = antigravityAuthConfigIssue(auth);
104104
const processEnvironment = mergeProviderInstanceEnvironment(environment);
105-
const userHome = resolveAntigravityUserHome(yield* HostProcessPlatform, processEnvironment);
105+
const platform = yield* HostProcessPlatform;
106+
const userHome = resolveAntigravityUserHome(platform, processEnvironment);
106107
const profileDirectory = resolveAntigravityProfileDirectory(
107108
serverConfig.stateDir,
108109
instanceId,
109110
);
110111
// No process of this instance exists yet, so every runtime temp
111-
// directory left under the profile is an orphan from a killed server.
112-
yield* removeAntigravityRuntimeTempDirs(
113-
resolveAntigravityRuntimeTempDirectory(profileDirectory),
114-
).pipe(Effect.provideService(FileSystem.FileSystem, fileSystem));
112+
// directory it owns is an orphan from a killed server. Windows hosts with
113+
// long paths enabled unpacked under the profile before the root moved.
114+
for (const directory of new Set([
115+
resolveAntigravityRuntimeTempDirectory(
116+
profileDirectory,
117+
platform,
118+
yield* HostProcessTempDirectory,
119+
),
120+
path.join(profileDirectory, "antigravity-acp", "tmp"),
121+
])) {
122+
yield* removeAntigravityRuntimeTempDirs(directory).pipe(
123+
Effect.provideService(FileSystem.FileSystem, fileSystem),
124+
);
125+
}
115126
const continuationIdentity = defaultProviderContinuationIdentity({
116127
driverKind: DRIVER,
117128
instanceId,

‎apps/server/src/provider/antigravityAuthSupport.test.ts‎

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
// @effect-diagnostics-next-line nodeBuiltinImport:off
22
import * as NodeChildProcess from "node:child_process";
3+
// @effect-diagnostics-next-line nodeBuiltinImport:off - Windows path math must run on every host.
4+
import * as NodePath from "node:path";
35

46
import * as NodeServices from "@effect/platform-node/NodeServices";
57
import { ProviderInstanceId } from "@t3tools/contracts";
@@ -37,6 +39,7 @@ import {
3739
parseAntigravityAuthorizationUrl,
3840
prepareAntigravityProfile,
3941
resolveAntigravityProfileDirectory,
42+
resolveAntigravityRuntimeTempDirectory,
4043
} from "./antigravityAuthSupport.ts";
4144

4245
const authorizationUrl =
@@ -260,6 +263,46 @@ describe("Antigravity process environment", () => {
260263
resolveAntigravityProfileDirectory("/userdata", ProviderInstanceId.make("antigravity")),
261264
).toBe(first);
262265
});
266+
267+
it("keeps the unpacked Windows runtime under MAX_PATH for long user names", () => {
268+
// Deepest member of the official agy_acp_server_1.1.1 windows-x86_64 bundle.
269+
const deepestMember =
270+
"google3\\cloud\\developer_experience\\antigravity_extensions\\acp_server\\_private__agy_acp_server_bin.lazy_imports_info.json";
271+
const home = "C:\\Users\\a-twenty-char-person";
272+
// Normalize separators: the profile resolver joins with the host's path module.
273+
const profileDirectory = NodePath.win32.normalize(
274+
resolveAntigravityProfileDirectory(
275+
NodePath.win32.join(home, ".t3", "userdata"),
276+
ProviderInstanceId.make("antigravity"),
277+
),
278+
);
279+
const extracted = (tempDirectory: string) =>
280+
NodePath.win32.join(tempDirectory, "run-AbC123", "_MEI000012ab2", deepestMember);
281+
282+
const root = resolveAntigravityRuntimeTempDirectory(
283+
profileDirectory,
284+
"win32",
285+
NodePath.win32.join(home, "AppData", "Local", "Temp"),
286+
);
287+
// MAX_PATH is 260 including the terminating NUL.
288+
expect(extracted(root).length).toBeLessThan(260);
289+
expect(
290+
extracted(NodePath.win32.join(profileDirectory, "antigravity-acp", "tmp")).length,
291+
).toBeGreaterThanOrEqual(260);
292+
expect(
293+
resolveAntigravityRuntimeTempDirectory(
294+
resolveAntigravityProfileDirectory("C:\\state", ProviderInstanceId.make("Antigravity")),
295+
"win32",
296+
"C:\\Temp",
297+
),
298+
).not.toBe(
299+
resolveAntigravityRuntimeTempDirectory(
300+
resolveAntigravityProfileDirectory("C:\\state", ProviderInstanceId.make("antigravity")),
301+
"win32",
302+
"C:\\Temp",
303+
),
304+
);
305+
});
263306
});
264307

265308
describe("Antigravity authorization URL", () => {

‎apps/server/src/provider/antigravityAuthSupport.ts‎

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import * as NodeFSP from "node:fs/promises";
55
import * as NodePath from "node:path";
66

77
import type { AntigravityAuthMethod, ProviderInstanceId } from "@t3tools/contracts";
8-
import { HostProcessPlatform } from "@t3tools/shared/hostProcess";
8+
import { HostProcessPlatform, HostProcessTempDirectory } from "@t3tools/shared/hostProcess";
99
import { resolveNodeExecutable, nodeRuntimeUnavailableMessage } from "@t3tools/shared/nodeRuntime";
1010
import * as Effect from "effect/Effect";
1111
import * as FileSystem from "effect/FileSystem";
@@ -194,9 +194,21 @@ export function resolveAntigravityProfileDirectory(
194194
return NodePath.join(stateDir, "providers", "antigravity", directoryName);
195195
}
196196

197-
/** Parent of the per-process runtime temp directories inside a profile. */
198-
export function resolveAntigravityRuntimeTempDirectory(profileDirectory: string): string {
199-
return NodePath.join(profileDirectory, "antigravity-acp", "tmp");
197+
/**
198+
* Parent of the per-process runtime temp directories. On Windows the agent
199+
* unpacks members up to 120 characters deep, and a profile nested under the
200+
* state directory pushes them past MAX_PATH, so the bootloader exits before
201+
* ACP starts. A short T3-owned directory in the system temp keeps them under
202+
* it; the profile hash keeps instances apart.
203+
*/
204+
export function resolveAntigravityRuntimeTempDirectory(
205+
profileDirectory: string,
206+
platform: NodeJS.Platform,
207+
systemTempDirectory: string,
208+
): string {
209+
if (platform !== "win32") return NodePath.join(profileDirectory, "antigravity-acp", "tmp");
210+
const scope = NodeCrypto.createHash("sha256").update(profileDirectory).digest("hex").slice(0, 12);
211+
return NodePath.join(systemTempDirectory, "t3-agy", scope);
200212
}
201213

202214
function quoteBrowserArgument(value: string): string {
@@ -337,7 +349,11 @@ export const prepareAntigravityProfile = Effect.fn("prepareAntigravityProfile")(
337349

338350
const geminiHome = path.resolve(input.profileDirectory);
339351
const acpDirectory = path.join(geminiHome, "antigravity-acp");
340-
const tempDirectory = resolveAntigravityRuntimeTempDirectory(geminiHome);
352+
const tempDirectory = resolveAntigravityRuntimeTempDirectory(
353+
geminiHome,
354+
platform,
355+
yield* HostProcessTempDirectory,
356+
);
341357
const profile: AntigravityProfile = {
342358
platform,
343359
geminiHome,

‎packages/shared/src/hostProcess.ts‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,13 @@ export const HostProcessWorkingDirectory = Context.Reference<string>(
3939
},
4040
);
4141

42+
export const HostProcessTempDirectory = Context.Reference<string>(
43+
"@t3tools/shared/hostProcess/HostProcessTempDirectory",
44+
{
45+
defaultValue: () => NodeOS.tmpdir(),
46+
},
47+
);
48+
4249
export const HostProcessExecutablePath = Context.Reference<string>(
4350
"@t3tools/shared/hostProcess/HostProcessExecutablePath",
4451
{

0 commit comments

Comments
 (0)