Skip to content

Commit b623a30

Browse files
Tighten validation for nightly release inputs
- Require integer nightly run numbers and desktop ports - Keep existing range checks in place - Co-authored-by: codex <[email protected]>
1 parent 2c825c0 commit b623a30

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

‎scripts/build-desktop-artifact.ts‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,11 +204,8 @@ const BuildEnvConfig = Config.all({
204204
mockUpdateServerPort: Config.string("T3CODE_DESKTOP_MOCK_UPDATE_SERVER_PORT").pipe(Config.option),
205205
});
206206

207-
const ValidMockUpdateServerPort = Schema.makeFilter(
208-
(port: number) => Number.isInteger(port) || "Expected an integer mock update server port.",
209-
);
210207
const MockUpdateServerPortSchema = Schema.NumberFromString.check(
211-
ValidMockUpdateServerPort,
208+
Schema.isInt(),
212209
Schema.isBetween({ minimum: 1, maximum: 65535 }),
213210
);
214211
const decodeMockUpdateServerPort = Schema.decodeUnknownEffect(MockUpdateServerPortSchema);

‎scripts/resolve-nightly-release.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@ interface NightlyReleaseMetadata {
1414
}
1515

1616
const DateSchema = Schema.String.check(Schema.isPattern(/^\d{8}$/));
17-
const RunNumberSchema = Schema.FiniteFromString.check(Schema.isGreaterThanOrEqualTo(1));
17+
const RunNumberSchema = Schema.FiniteFromString.check(
18+
Schema.isInt(),
19+
Schema.isGreaterThanOrEqualTo(1),
20+
);
1821
const ShaSchema = Schema.String.check(Schema.isPattern(/^[0-9a-f]{7,40}$/i));
1922
const DesktopPackageJsonSchema = Schema.Struct({
2023
version: Schema.NonEmptyString,

0 commit comments

Comments
 (0)