Skip to content

Commit b5b69a3

Browse files
only21milclaude
andcommitted
perf(web): stop unrelated visits re-rendering sidebar folder headers
Each boring-sidebar folder header subscribed to the whole local visit map, so any thread visit re-rendered every folder header, open ones included. The header now selects its derived status dot instead, so it re-renders only when its own dot changes. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 1d626d0 commit b5b69a3

2 files changed

Lines changed: 109 additions & 14 deletions

File tree

Lines changed: 94 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
import { scopedThreadKey, scopeThreadRef } from "@t3tools/client-runtime/environment";
2+
import { EnvironmentId, ProjectId, RunId, ThreadId } from "@t3tools/contracts";
3+
import { Profiler } from "react";
4+
import { expect, it, vi } from "vite-plus/test";
5+
6+
import { act, render } from "../../../test/render";
7+
import type { SidebarProjectSnapshot } from "../../sidebarProjectGrouping";
8+
import { makeThreadFixture } from "../../test-fixtures";
9+
import { useUiStateStore } from "../../uiStateStore";
10+
import { SidebarProjectFolderHeader } from "./SidebarProjectFolderHeader";
11+
12+
const environmentId = EnvironmentId.make("folder-dot-environment");
13+
const COMPLETED_AT = "2026-03-09T10:05:00.000Z";
14+
const BEFORE_COMPLETION = "2026-03-09T10:04:00.000Z";
15+
const AFTER_COMPLETION = "2026-03-09T10:06:00.000Z";
16+
17+
function makeFolderFixture(index: number) {
18+
const projectId = ProjectId.make(`folder-project-${index}`);
19+
const group = {
20+
environmentId,
21+
workspaceRoot: `/repo-${index}`,
22+
title: `Project ${index}`,
23+
faviconPath: null,
24+
projectIcon: null,
25+
projectKey: `folder-${index}`,
26+
displayName: `Project ${index}`,
27+
} as SidebarProjectSnapshot;
28+
// No server lastVisitedAt, as from an older server, so the dot reads local visits.
29+
const thread = makeThreadFixture({
30+
environmentId,
31+
id: ThreadId.make(`folder-thread-${index}`),
32+
projectId,
33+
runtime: null,
34+
latestRun: {
35+
runId: RunId.make(`folder-run-${index}`),
36+
status: "completed",
37+
assistantMessageId: null,
38+
requestedAt: "2026-03-09T10:00:00.000Z",
39+
startedAt: "2026-03-09T10:00:00.000Z",
40+
completedAt: COMPLETED_AT,
41+
},
42+
});
43+
return { group, thread };
44+
}
45+
46+
const threadKey = (thread: { environmentId: EnvironmentId; id: ThreadId }) =>
47+
scopedThreadKey(scopeThreadRef(thread.environmentId, thread.id));
48+
49+
it("re-renders a folder header only when a visit changes its dot", async () => {
50+
const initial = useUiStateStore.getState();
51+
using _store = {
52+
[Symbol.dispose]: () => useUiStateStore.setState(initial, true),
53+
};
54+
const [unread, seen] = [makeFolderFixture(0), makeFolderFixture(1)];
55+
useUiStateStore.setState({
56+
threadLastVisitedAtById: {
57+
[threadKey(unread.thread)]: BEFORE_COMPLETION,
58+
[threadKey(seen.thread)]: AFTER_COMPLETION,
59+
},
60+
});
61+
const renders = new Map<string, number>();
62+
const onRender = (id: string) => renders.set(id, (renders.get(id) ?? 0) + 1);
63+
await using screen = await render(
64+
<ul>
65+
{[unread, seen].map(({ group, thread }) => (
66+
<Profiler key={group.projectKey} id={group.projectKey} onRender={onRender}>
67+
<SidebarProjectFolderHeader
68+
group={group}
69+
collapsed
70+
hiddenThreads={[thread]}
71+
onToggle={vi.fn()}
72+
onNewThread={vi.fn()}
73+
onContextMenu={vi.fn()}
74+
/>
75+
</Profiler>
76+
))}
77+
</ul>,
78+
);
79+
const header = (index: number) =>
80+
screen.getByRole("treeitem", { name: new RegExp(`^Project ${index}`) });
81+
await expect.element(header(0)).toHaveAccessibleName(/, done/);
82+
await expect.element(header(1)).not.toHaveAccessibleName(/, done/);
83+
84+
renders.clear();
85+
const elsewhere = threadKey({ environmentId, id: ThreadId.make("elsewhere") });
86+
await act(() => initial.markThreadVisited(elsewhere, "2026-03-09T11:00:00.000Z"));
87+
expect(renders.size).toBe(0);
88+
89+
await act(() => initial.markThreadVisited(threadKey(unread.thread), AFTER_COMPLETION));
90+
await expect.element(header(0)).not.toHaveAccessibleName(/, done/);
91+
await act(() => initial.markThreadUnread(threadKey(seen.thread), COMPLETED_AT));
92+
await expect.element(header(1)).toHaveAccessibleName(/, done/);
93+
expect(Object.fromEntries(renders)).toEqual({ "folder-0": 1, "folder-1": 1 });
94+
});

‎apps/web/src/components/sidebar/SidebarProjectFolderHeader.tsx‎

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -45,20 +45,21 @@ export const SidebarProjectFolderHeader = memo(function SidebarProjectFolderHead
4545
}) {
4646
const { group, collapsed, hiddenThreads } = props;
4747
const rowId = sidebarFolderRowId(group.projectKey);
48-
const localLastVisitedAtById = useUiStateStore((state) => state.threadLastVisitedAtById);
49-
const dot = collapsed
50-
? resolveSidebarFolderDot(
51-
hiddenThreads.map((thread) => ({
52-
...thread,
53-
lastVisitedAt: resolveThreadLastVisitedAt(
54-
thread.lastVisitedAt,
55-
localLastVisitedAtById[
56-
scopedThreadKey(scopeThreadRef(thread.environmentId, thread.id))
57-
],
58-
),
59-
})),
60-
)
61-
: null;
48+
const dot = useUiStateStore((state) =>
49+
collapsed
50+
? resolveSidebarFolderDot(
51+
hiddenThreads.map((thread) => ({
52+
...thread,
53+
lastVisitedAt: resolveThreadLastVisitedAt(
54+
thread.lastVisitedAt,
55+
state.threadLastVisitedAtById[
56+
scopedThreadKey(scopeThreadRef(thread.environmentId, thread.id))
57+
],
58+
),
59+
})),
60+
)
61+
: null,
62+
);
6263
return (
6364
<li
6465
data-testid="sidebar-project-folder"

0 commit comments

Comments
 (0)