Skip to content

Commit b40c7e6

Browse files
committed
fix(web): keep completed prefixes compatible with filtering
1 parent 0a9b40b commit b40c7e6

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

‎packages/client-runtime/src/state/filesystem.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ describe("filesystem browse model", () => {
9696
isComplete: false,
9797
});
9898
expect(getFilesystemBrowseTabCompletion([entry("😀one"), entry("😁two")], "")).toBeNull();
99+
expect(getFilesystemBrowseTabCompletion([entry("ΟΣα"), entry("οσβ")], "ο")).toBeNull();
99100
expect(getFilesystemBrowseTabCompletion([entry("😀one"), entry("😀other")], "😀")).toEqual({
100101
name: "😀o",
101102
isComplete: false,

‎packages/client-runtime/src/state/filesystem.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,11 @@ export function getFilesystemBrowseTabCompletion(
105105
prefix = prefix.slice(0, length);
106106
}
107107
const name = prefix.join("");
108-
return name.length > filterQuery.length ? { name, isComplete: false } : null;
108+
const lowerName = name.toLowerCase();
109+
return name.length > filterQuery.length &&
110+
visibleEntries.every((entry) => entry.name.toLowerCase().startsWith(lowerName))
111+
? { name, isComplete: false }
112+
: null;
109113
}
110114

111115
export function createBrowseNavigationCoordinator() {

0 commit comments

Comments
 (0)