Repository navigation
Commit b3d651a
committed
test(ssh): zombie-reap launch test no longer races the shell
The test killed the background child as soon as sh printed its pid. If the
kill landed before sh exec'd, dash's SIGCHLD handling reaped the child, so
no zombie was left and ps printed nothing.
Kill the child only after sh has exec'd into node, which never reaps an
inherited child, and print its pid once SIGCHLD confirms it is a zombie.1 parent 069e63b commit b3d651a
1 file changed
Lines changed: 15 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1451 | 1451 | | |
1452 | 1452 | | |
1453 | 1453 | | |
| 1454 | + | |
| 1455 | + | |
| 1456 | + | |
1454 | 1457 | | |
1455 | | - | |
| 1458 | + | |
| 1459 | + | |
| 1460 | + | |
| 1461 | + | |
| 1462 | + | |
| 1463 | + | |
| 1464 | + | |
| 1465 | + | |
| 1466 | + | |
| 1467 | + | |
| 1468 | + | |
1456 | 1469 | | |
1457 | 1470 | | |
1458 | 1471 | | |
1459 | 1472 | | |
1460 | 1473 | | |
1461 | 1474 | | |
1462 | | - | |
1463 | | - | |
1464 | | - | |
1465 | | - | |
1466 | | - | |
1467 | | - | |
1468 | | - | |
1469 | | - | |
1470 | | - | |
1471 | | - | |
1472 | | - | |
1473 | | - | |
| 1475 | + | |
1474 | 1476 | | |
1475 | 1477 | | |
1476 | 1478 | | |
| |||
0 commit comments