Skip to content

Commit b2bdb4e

Browse files
test(contracts): keep driver default lookup private
1 parent d2c3e2e commit b2bdb4e

2 files changed

Lines changed: 5 additions & 10 deletions

File tree

‎packages/contracts/src/settings.test.ts‎

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import {
77
ClientSettingsPatch,
88
ClaudeSettings,
99
DEFAULT_SERVER_SETTINGS,
10-
defaultEnabledForDriver,
1110
resolveProviderInstanceEnabled,
1211
ServerSettings,
1312
ServerSettingsPatch,
@@ -432,14 +431,6 @@ describe("provider enabled defaults", () => {
432431
expect(decoded.providers.opencode.enabled).toBe(false);
433432
});
434433

435-
it("derives per-driver defaults from the settings schemas", () => {
436-
expect(defaultEnabledForDriver(ProviderDriverKind.make("codex"))).toBe(true);
437-
expect(defaultEnabledForDriver(ProviderDriverKind.make("cursor"))).toBe(false);
438-
expect(defaultEnabledForDriver(ProviderDriverKind.make("grok"))).toBe(false);
439-
// Unknown fork drivers stay enabled; their own build decides otherwise.
440-
expect(defaultEnabledForDriver(ProviderDriverKind.make("ollama"))).toBe(true);
441-
});
442-
443434
it("keeps Cursor enabled when an existing user explicitly opted in", () => {
444435
const cursor = ProviderDriverKind.make("cursor");
445436
const cursorId = ProviderInstanceId.make("cursor");
@@ -460,6 +451,10 @@ describe("provider enabled defaults", () => {
460451
// No flags anywhere: driver default applies.
461452
expect(resolveProviderInstanceEnabled({ driver: grok, config: {} })).toBe(false);
462453
expect(resolveProviderInstanceEnabled({ driver: codex, config: {} })).toBe(true);
454+
// Unknown fork drivers stay enabled.
455+
expect(
456+
resolveProviderInstanceEnabled({ driver: ProviderDriverKind.make("ollama"), config: {} }),
457+
).toBe(true);
463458
// Envelope flag wins over the driver default.
464459
expect(resolveProviderInstanceEnabled({ driver: grok, enabled: true, config: {} })).toBe(true);
465460
expect(resolveProviderInstanceEnabled({ driver: codex, enabled: false, config: {} })).toBe(

‎packages/contracts/src/settings.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -975,7 +975,7 @@ export const providerInstanceConfigEnabledFlag = (config: unknown): boolean | un
975975
* through `DEFAULT_SERVER_SETTINGS`, so the schema's decoding default stays
976976
* the single source of truth. Unknown (fork) drivers default to enabled.
977977
*/
978-
export const defaultEnabledForDriver = (driver: ProviderDriverKind): boolean => {
978+
const defaultEnabledForDriver = (driver: ProviderDriverKind): boolean => {
979979
const legacyDefaults = DEFAULT_SERVER_SETTINGS.providers as Record<
980980
string,
981981
{ readonly enabled?: boolean } | undefined

0 commit comments

Comments
 (0)