You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b2b6463
Browse filesBrowse the repository at this point in the historyBrowse files
refactor(web): pull request views record answers and refresh by revision
Pull request pages and panels record shared summaries, snapshots and
guide watches from query answers, refetch when a host revision changes,
and keep files-viewed writes in a scope-keyed store instead of chaining
effects on tokens and counters.
Effect categories removed:
- shared summary, list, detail snapshot and running-guide mirrors moved
into query answer handlers
- window and document key listeners moved to dispatcher scopes (detail,
page, guide tour, list search, close-sweep Escape)
- sentinels, overflow, condense and stats visibility observers moved to
ref callbacks
- values reported back to parents derived in render (selected commit,
stats batches, tab fallback)
- refresh-token and revalidation-counter effects replaced by reads keyed
on the pull request's host revision
- per-watch guide run components replaced by an app-lifetime poller
- files-viewed mirror and scope-leave effects moved into a scoped store
- code tab file reveals became requests that pend until the file loads
Bugs fixed:
- A review guide seen as Running reported the previous run's failure as
a toast or desktop notification.
- A selected commit missing from a still-loading list was reset to "all
commits" permanently.
- Comment overflow was measured after paint, so the fade and button
popped in.
- A guide open request with review guides disabled looped between tabs.
- A files-viewed answer for a scope that was left and re-entered was
applied to the new visit.
Kept effects:
- Linked-selection panel open: the URL changes through reload and
back/forward and resolves against late project data.
- Guide tab maximize on show: needs the page's maximized state in a store.
- Close-sweep sensor cancel.
Temporary compat shims (removed in a later layer of this stack):
- components/pullRequest/guide/PullRequestGuideRunCoordinator.tsx: final startGuideRunNotifications plus a compat PullRequestGuideRunCoordinator component that the base __root mounts until appInit starts it in the web-chat-view layer; guideRunStore's final shape removes the state the base coordinator used (removed in layer 10)
- hooks/useSettings.ts: starts model-preference migration at module load until appInit starts it in the app-bootstrap layer (the final module drops useMigrateModelPreferences) (removed in layer 10)
- components/diffs/useCodeViewFileReveal.ts: final hook plus a retry effect for the base DiffPanel's (viewer, scope, readyFileKeys) call, so DiffPanel's reveal still waits for the file to render until DiffPanel lands in the web-files layer; the PR code tab needs the final hook (removed in layer 07)
Co-Authored-By: Claude Opus 5.5 <[email protected]>
0 commit comments