Skip to content

Commit b10ac9d

Browse files
committed
fix(web): keep release note keys unique
1 parent 997ddb8 commit b10ac9d

1 file changed

Lines changed: 11 additions & 2 deletions

File tree

‎apps/web/src/components/sidebar/SidebarUpdatePill.tsx‎

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,15 @@ import { Alert, AlertDescription, AlertTitle } from "../ui/alert";
1919
import { Separator } from "../ui/separator";
2020
import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip";
2121

22+
function keyReleaseNoteItems(items: ReadonlyArray<string>) {
23+
const occurrences = new Map<string, number>();
24+
return items.map((item) => {
25+
const occurrence = occurrences.get(item) ?? 0;
26+
occurrences.set(item, occurrence + 1);
27+
return { item, key: JSON.stringify([item, occurrence]) };
28+
});
29+
}
30+
2231
function SidebarUpdateReleaseNotesTooltip({
2332
state,
2433
tooltip,
@@ -44,8 +53,8 @@ function SidebarUpdateReleaseNotesTooltip({
4453
{index === 0 ? "What's changed" : `Changes in ${releaseNote.version}`}
4554
</h3>
4655
<ul className="mt-2 space-y-1.5 pl-4 text-xs leading-5 text-popover-foreground/90">
47-
{releaseNote.items.map((item) => (
48-
<li className="list-disc break-words" key={`${releaseNote.version}-${item}`}>
56+
{keyReleaseNoteItems(releaseNote.items).map(({ item, key }) => (
57+
<li className="list-disc break-words" key={key}>
4958
{item}
5059
</li>
5160
))}

0 commit comments

Comments
 (0)