Skip to content

Commit af342e1

Browse files
committed
test(web): align file preview saves with current command boundary
1 parent 79752d0 commit af342e1

1 file changed

Lines changed: 53 additions & 51 deletions

File tree

‎apps/web/src/components/files/FilePreviewPanel.browser.test.tsx‎

Lines changed: 53 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,19 @@
11
import { EnvironmentId, ThreadId, type ProjectReadFileResult } from "@t3tools/contracts";
22
import { AsyncResult } from "effect/reactivity";
3-
import { act } from "react";
4-
import { createRoot, type Root } from "react-dom/client";
5-
import { afterEach, beforeEach, describe, expect, it, vi } from "vite-plus/test";
3+
import { describe, expect, it, vi } from "vite-plus/test";
4+
import { act, fakeTimers, render } from "../../../test/render";
65

76
const state = vi.hoisted(() => ({
87
file: null as ProjectReadFileResult | null,
98
optimistic: null as ProjectReadFileResult | null,
109
writeFile: vi.fn(),
1110
}));
1211

12+
vi.mock(import("@t3tools/client-runtime/state/runtime"), async (original) => ({
13+
...(await original()),
14+
runAtomCommand: ((_registry: unknown, _command: unknown, request: unknown) =>
15+
state.writeFile(request)) as never,
16+
}));
1317
vi.mock(import("~/state/session"), async (original) => ({
1418
...(await original()),
1519
readEnvironmentScope: () => true,
@@ -73,67 +77,61 @@ import FilePreviewPanel from "./FilePreviewPanel";
7377

7478
const environmentId = EnvironmentId.make("markdown-preview-test");
7579
const threadRef = { environmentId, threadId: ThreadId.make("thread") };
76-
let root: Root;
77-
let container: HTMLDivElement;
78-
79-
beforeEach(() => {
80-
vi.stubGlobal("IS_REACT_ACT_ENVIRONMENT", true);
81-
vi.useFakeTimers();
82-
localStorage.setItem("t3code.fileExplorerOpen", "false");
83-
localStorage.setItem("t3code.renderMarkdown", "true");
80+
function setup() {
81+
const keys = ["t3code.fileExplorerOpen", "t3code.renderMarkdown"];
82+
const previous = keys.map((key) => localStorage.getItem(key));
83+
localStorage.setItem(keys[0]!, "false");
84+
localStorage.setItem(keys[1]!, "true");
8485
state.optimistic = null;
8586
state.writeFile.mockReset().mockResolvedValue(AsyncResult.success(undefined));
86-
container = document.body.appendChild(document.createElement("div"));
87-
root = createRoot(container);
88-
});
89-
90-
afterEach(async () => {
91-
await act(async () => root.unmount());
92-
container.remove();
93-
localStorage.removeItem("t3code.fileExplorerOpen");
94-
localStorage.removeItem("t3code.renderMarkdown");
95-
vi.useRealTimers();
96-
vi.unstubAllGlobals();
97-
});
87+
return {
88+
[Symbol.dispose]() {
89+
for (const [index, key] of keys.entries()) {
90+
const value = previous[index];
91+
if (value == null) localStorage.removeItem(key);
92+
else localStorage.setItem(key, value);
93+
}
94+
},
95+
};
96+
}
9897

99-
async function openMarkdown(truncated: boolean) {
98+
function markdownPreview(truncated: boolean) {
10099
state.file = {
101100
relativePath: "tasks.md",
102101
contents: "- [ ] Keep the rest of this file\n",
103102
byteLength: truncated ? 1_200_000 : 32,
104103
truncated,
105104
};
106-
await act(async () =>
107-
root.render(
108-
<FilePreviewPanel
109-
environmentId={environmentId}
110-
cwd="/workspace"
111-
projectName="Project"
112-
relativePath="tasks.md"
113-
threadRef={threadRef}
114-
composerDraftTarget={threadRef}
115-
keybindings={[]}
116-
availableEditors={[]}
117-
openInShortcutEnabled={false}
118-
revealLine={null}
119-
revealRequestId={0}
120-
onOpenFile={vi.fn()}
121-
onNavigateFolder={vi.fn()}
122-
folderTrail={undefined}
123-
onPendingChange={vi.fn()}
124-
selectedFilePending={false}
125-
workspaceMutationId={null}
126-
/>,
127-
),
105+
return (
106+
<FilePreviewPanel
107+
environmentId={environmentId}
108+
cwd="/workspace"
109+
projectName="Project"
110+
relativePath="tasks.md"
111+
threadRef={threadRef}
112+
composerDraftTarget={threadRef}
113+
keybindings={[]}
114+
availableEditors={[]}
115+
openInShortcutEnabled={false}
116+
revealLine={null}
117+
revealRequestId={0}
118+
onOpenFile={vi.fn()}
119+
onNavigateFolder={vi.fn()}
120+
folderTrail={undefined}
121+
onPendingChange={vi.fn()}
122+
selectedFilePending={false}
123+
workspaceMutationId={null}
124+
/>
128125
);
129-
const checkbox = container.querySelector<HTMLInputElement>('input[type="checkbox"]');
130-
expect(checkbox).not.toBeNull();
131-
return checkbox!;
132126
}
133127

134128
describe("rendered Markdown task saves", () => {
135129
it("keeps a truncated read read-only without queuing a replacement", async () => {
136-
const checkbox = await openMarkdown(true);
130+
using _settings = setup();
131+
await using screen = await render(markdownPreview(true));
132+
using _timers = fakeTimers();
133+
const checkbox = screen.container.querySelector<HTMLInputElement>('input[type="checkbox"]')!;
134+
expect(checkbox).not.toBeNull();
137135
expect(checkbox.disabled).toBe(true);
138136
expect(checkbox.readOnly).toBe(true);
139137
await act(async () => checkbox.click());
@@ -144,7 +142,11 @@ describe("rendered Markdown task saves", () => {
144142
});
145143

146144
it("still toggles and saves tasks from a complete read", async () => {
147-
const checkbox = await openMarkdown(false);
145+
using _settings = setup();
146+
await using screen = await render(markdownPreview(false));
147+
using _timers = fakeTimers();
148+
const checkbox = screen.container.querySelector<HTMLInputElement>('input[type="checkbox"]')!;
149+
expect(checkbox).not.toBeNull();
148150
expect(checkbox.disabled).toBe(false);
149151
await act(async () => checkbox.click());
150152
await vi.advanceTimersByTimeAsync(500);

0 commit comments

Comments
 (0)