Repository navigation
Commit af0214f
refactor(mobile): drop the unreachable pending-task editor from new-task drafts
Since #23467 a pending task on the home list opens as a Thread route, so
nothing sets draft.pendingTaskId any more (no navigation, deep link,
notification or URL producer). The new-task draft still carried a full
editor for it: route param plumbing, begin/cancel/finish editing, a
compare-and-swap write module, an outbox subscription to end stale edits,
and an unmount flush.
Remove that editor: state/pending-task-editor-writes.ts and its test, the
pendingTaskId route param and Stack plumbing, and the editingPendingTask
paths in NewTaskFlowProvider, NewTaskDraftScreen and
NewTaskDraftRouteScreen. resolvePendingTaskInteractionMode loses the
queued-mode fallback that only the editor used.
NewTaskFlowProvider wraps the whole root stack and subscribed to the
thread outbox only to notice a deleted in-edit task, so every outbox
change re-rendered it. That subscription is gone.
Effects removed (5): provider stale-edit effect, provider flush-ref
effect, provider unmount flush; draft screen begin-editing effect and
its cleanup effect. holdEditingQueuedMessage/releaseEditingQueuedMessage
stay (home list delete and queued-message edit use them).
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent abf8f43 commit af0214f
8 files changed
Lines changed: 35 additions & 674 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
509 | 509 | | |
510 | 510 | | |
511 | 511 | | |
512 | | - | |
513 | | - | |
514 | | - | |
| 512 | + | |
515 | 513 | | |
516 | 514 | | |
517 | 515 | | |
518 | 516 | | |
519 | | - | |
520 | | - | |
521 | | - | |
522 | 517 | | |
523 | 518 | | |
524 | 519 | | |
| |||
540 | 535 | | |
541 | 536 | | |
542 | 537 | | |
543 | | - | |
544 | | - | |
545 | | - | |
546 | | - | |
547 | | - | |
| 538 | + | |
548 | 539 | | |
549 | 540 | | |
550 | 541 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | 43 | | |
47 | 44 | | |
48 | 45 | | |
| |||
75 | 72 | | |
76 | 73 | | |
77 | 74 | | |
78 | | - | |
| 75 | + | |
79 | 76 | | |
80 | 77 | | |
81 | 78 | | |
| |||
200 | 197 | | |
201 | 198 | | |
202 | 199 | | |
203 | | - | |
204 | 200 | | |
205 | 201 | | |
206 | 202 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
153 | | - | |
154 | 153 | | |
155 | 154 | | |
156 | 155 | | |
| |||
386 | 385 | | |
387 | 386 | | |
388 | 387 | | |
389 | | - | |
| 388 | + | |
390 | 389 | | |
391 | 390 | | |
392 | 391 | | |
393 | | - | |
| 392 | + | |
394 | 393 | | |
395 | 394 | | |
396 | 395 | | |
| |||
415 | 414 | | |
416 | 415 | | |
417 | 416 | | |
418 | | - | |
419 | | - | |
420 | | - | |
421 | | - | |
422 | | - | |
423 | | - | |
424 | | - | |
425 | | - | |
426 | | - | |
427 | | - | |
428 | | - | |
429 | | - | |
430 | | - | |
431 | | - | |
432 | | - | |
433 | | - | |
434 | | - | |
435 | | - | |
436 | | - | |
437 | | - | |
438 | | - | |
439 | | - | |
440 | | - | |
| 417 | + | |
441 | 418 | | |
442 | 419 | | |
443 | 420 | | |
444 | 421 | | |
445 | | - | |
| 422 | + | |
446 | 423 | | |
447 | 424 | | |
448 | 425 | | |
| |||
516 | 493 | | |
517 | 494 | | |
518 | 495 | | |
519 | | - | |
| 496 | + | |
520 | 497 | | |
521 | | - | |
522 | 498 | | |
523 | 499 | | |
524 | 500 | | |
| |||
901 | 877 | | |
902 | 878 | | |
903 | 879 | | |
904 | | - | |
905 | | - | |
906 | | - | |
907 | | - | |
908 | | - | |
909 | | - | |
910 | | - | |
911 | | - | |
912 | | - | |
913 | | - | |
914 | | - | |
| 880 | + | |
915 | 881 | | |
916 | 882 | | |
917 | 883 | | |
| |||
939 | 905 | | |
940 | 906 | | |
941 | 907 | | |
942 | | - | |
943 | | - | |
944 | | - | |
945 | | - | |
946 | | - | |
947 | | - | |
948 | | - | |
949 | | - | |
950 | | - | |
951 | | - | |
952 | | - | |
| 908 | + | |
| 909 | + | |
| 910 | + | |
| 911 | + | |
| 912 | + | |
| 913 | + | |
| 914 | + | |
953 | 915 | | |
954 | 916 | | |
955 | 917 | | |
| |||
1146 | 1108 | | |
1147 | 1109 | | |
1148 | 1110 | | |
1149 | | - | |
| 1111 | + | |
1150 | 1112 | | |
1151 | 1113 | | |
1152 | 1114 | | |
| |||
0 commit comments