Skip to content

Commit ab71b13

Browse files
authored
Merge branch 'main' into fix/chat-beside-details-shift
2 parents b46d2f2 + ae521d1 commit ab71b13

535 files changed

Lines changed: 24438 additions & 2750 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 145 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,145 @@
1+
name: Mobile EAS Preview (Fork)
2+
3+
# EAS previews for fork PRs. This runs the PR's code with an Expo token: the
4+
# app config and plugins run on this runner, and native builds run on EAS
5+
# with preview signing credentials. The label is the maintainer's sign-off
6+
# that they reviewed that code, so it covers exactly the commit it was applied
7+
# to: this pins that commit and consumes the label before running anything. A
8+
# later push deploys nothing until the label is applied again.
9+
#
10+
# Same-repo PRs deploy on every push while labeled, via mobile-eas-preview.yml.
11+
12+
on:
13+
pull_request_target:
14+
types: [labeled]
15+
16+
permissions:
17+
contents: read
18+
19+
jobs:
20+
preview:
21+
name: EAS Preview
22+
if: >-
23+
github.event.pull_request.head.repo.full_name != github.repository &&
24+
github.event.label.name == '🚀 Mobile Continuous Deployment'
25+
runs-on: blacksmith-8vcpu-ubuntu-2404
26+
concurrency:
27+
group: mobile-eas-preview-fork-${{ github.event.pull_request.number }}
28+
cancel-in-progress: true
29+
permissions:
30+
contents: read
31+
pull-requests: write
32+
env:
33+
APP_VARIANT: preview
34+
NODE_OPTIONS: --max-old-space-size=8192
35+
MOBILE_VERSION_POLICY: fingerprint
36+
steps:
37+
# If a maintainer removed the label first, that removal wins.
38+
- id: consume
39+
name: Consume the deployment label
40+
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8
41+
with:
42+
script: |
43+
try {
44+
await github.rest.issues.removeLabel({
45+
owner: context.repo.owner,
46+
repo: context.repo.repo,
47+
issue_number: context.payload.pull_request.number,
48+
name: context.payload.label.name,
49+
});
50+
core.setOutput("consumed", "true");
51+
} catch (error) {
52+
if (error.status !== 404) throw error;
53+
core.info("The label was removed before this run could consume it. Skipping.");
54+
core.setOutput("consumed", "false");
55+
}
56+
57+
- id: expo-token
58+
name: Check for EXPO_PREVIEW_TOKEN
59+
if: steps.consume.outputs.consumed == 'true'
60+
env:
61+
EXPO_TOKEN: ${{ secrets.EXPO_PREVIEW_TOKEN }}
62+
run: |
63+
if [ -n "$EXPO_TOKEN" ]; then
64+
echo "present=true" >> "$GITHUB_OUTPUT"
65+
else
66+
echo "present=false" >> "$GITHUB_OUTPUT"
67+
echo "EXPO_PREVIEW_TOKEN is not set; skipping EAS preview."
68+
fi
69+
70+
# The head SHA from the label event, not the branch, so a push after the
71+
# label cannot swap in unreviewed code. No credentials stay in .git for
72+
# the PR's scripts to read.
73+
- name: Checkout reviewed commit
74+
if: steps.expo-token.outputs.present == 'true'
75+
uses: actions/checkout@v6
76+
with:
77+
ref: ${{ github.event.pull_request.head.sha }}
78+
fetch-depth: 0
79+
persist-credentials: false
80+
# No sparse-checkout: see mobile-eas-preview.yml.
81+
82+
# No caches: pull_request_target saves them under main's scope, where
83+
# trusted workflows with other secrets would restore what PR code wrote.
84+
- name: Setup Vite+
85+
if: steps.expo-token.outputs.present == 'true'
86+
uses: voidzero-dev/setup-vp@v1
87+
with:
88+
node-version-file: package.json
89+
cache: false
90+
run-install: |
91+
args:
92+
- --filter=@t3tools/mobile...
93+
94+
- name: Expose pnpm
95+
if: steps.expo-token.outputs.present == 'true'
96+
run: |
97+
pnpm_version="$(node --print "require('./package.json').packageManager.split('@').pop()")"
98+
vp_pnpm_bin="$HOME/.vite-plus/package_manager/pnpm/$pnpm_version/pnpm/bin"
99+
echo "$vp_pnpm_bin" >> "$GITHUB_PATH"
100+
"$vp_pnpm_bin/pnpm" --version
101+
102+
- name: Setup EAS
103+
if: steps.expo-token.outputs.present == 'true'
104+
uses: expo/expo-github-action@v8
105+
with:
106+
# Pinned and installed with npm for the same reasons as mobile-eas-preview.yml.
107+
eas-version: 21.8.0
108+
eas-cache: false
109+
token: ${{ secrets.EXPO_PREVIEW_TOKEN }}
110+
packager: npm
111+
112+
- name: Pull preview environment variables
113+
if: steps.expo-token.outputs.present == 'true'
114+
working-directory: apps/mobile
115+
env:
116+
EXPO_TOKEN: ${{ secrets.EXPO_PREVIEW_TOKEN }}
117+
run: |
118+
eas env:pull preview --non-interactive
119+
# See mobile-eas-preview.yml: keeps Android build and OTA fingerprints matching.
120+
node --input-type=module <<'NODE'
121+
import { appendFileSync, readFileSync } from "node:fs";
122+
import { parseEnv } from "node:util";
123+
const env = parseEnv(readFileSync(".env.local", "utf8"));
124+
const googleServicesFile = env.T3CODE_ANDROID_GOOGLE_SERVICES_FILE;
125+
if (googleServicesFile) {
126+
appendFileSync(process.env.GITHUB_ENV, `T3CODE_ANDROID_GOOGLE_SERVICES_FILE=${googleServicesFile}\n`);
127+
}
128+
NODE
129+
130+
- name: Deploy with fingerprint check
131+
if: steps.expo-token.outputs.present == 'true'
132+
uses: expo/expo-github-action/continuous-deploy-fingerprint@main
133+
env:
134+
EXPO_TOKEN: ${{ secrets.EXPO_PREVIEW_TOKEN }}
135+
RUNNER_DEBUG: "1"
136+
# The action only comments for pull_request events; this hook gives
137+
# it the PR under pull_request_target. Without it, it skips the comment.
138+
EXPO_TEST_GITHUB_PULL: ${{ github.event.pull_request.number }}
139+
with:
140+
profile: preview:dev
141+
branch: pr-${{ github.event.pull_request.number }}
142+
platform: all
143+
environment: preview
144+
working-directory: apps/mobile
145+
github-token: ${{ secrets.GITHUB_TOKEN }}

‎.github/workflows/mobile-eas-preview.yml‎

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ on:
77
jobs:
88
preview:
99
name: EAS Preview
10+
# Fork PRs deploy one reviewed commit per label through mobile-eas-preview-fork.yml.
1011
if: |
12+
github.event.pull_request.head.repo.full_name == github.repository &&
1113
contains(github.event.pull_request.labels.*.name, '🚀 Mobile Continuous Deployment') &&
1214
(github.event.action != 'labeled' || github.event.label.name == '🚀 Mobile Continuous Deployment')
1315
runs-on: blacksmith-8vcpu-ubuntu-2404
@@ -23,15 +25,15 @@ jobs:
2325
MOBILE_VERSION_POLICY: fingerprint
2426
steps:
2527
- id: expo-token
26-
name: Check for EXPO_TOKEN
28+
name: Check for EXPO_PREVIEW_TOKEN
2729
env:
28-
EXPO_TOKEN: ${{ secrets.EXPO_TOKEN }}
30+
EXPO_TOKEN: ${{ secrets.EXPO_PREVIEW_TOKEN }}
2931
run: |
3032
if [ -n "$EXPO_TOKEN" ]; then
3133
echo "present=true" >> "$GITHUB_OUTPUT"
3234
else
3335
echo "present=false" >> "$GITHUB_OUTPUT"
34-
echo "EXPO_TOKEN is not available; skipping EAS preview."
36+
echo "EXPO_PREVIEW_TOKEN is not available; skipping EAS preview."
3537
fi
3638
3739
- name: Checkout
@@ -70,7 +72,7 @@ jobs:
7072
# continuous-deploy-fingerprint still reads `build.project.ownerAccount`.
7173
# Unpin once https://github.com/expo/expo-github-action/issues/358 is fixed.
7274
eas-version: 21.8.0
73-
token: ${{ secrets.EXPO_TOKEN }}
75+
token: ${{ secrets.EXPO_PREVIEW_TOKEN }}
7476
# npm, not pnpm: this only installs eas-cli into the action's own
7577
# tool dir, and pnpm 11 hard-fails that install on dtrace-provider's
7678
# ignored build script (no allowBuilds config outside the repo).
@@ -80,7 +82,7 @@ jobs:
8082
if: steps.expo-token.outputs.present == 'true'
8183
working-directory: apps/mobile
8284
env:
83-
EXPO_TOKEN: ${{ secrets.EXPO_TOKEN }}
85+
EXPO_TOKEN: ${{ secrets.EXPO_PREVIEW_TOKEN }}
8486
run: |
8587
eas env:pull preview --non-interactive
8688
# EAS Update disables dotenv loading. Keep the downloaded native config
@@ -99,7 +101,7 @@ jobs:
99101
if: steps.expo-token.outputs.present == 'true'
100102
uses: expo/expo-github-action/continuous-deploy-fingerprint@main
101103
env:
102-
EXPO_TOKEN: ${{ secrets.EXPO_TOKEN }}
104+
EXPO_TOKEN: ${{ secrets.EXPO_PREVIEW_TOKEN }}
103105
# The Expo action otherwise suppresses the EAS command's failure output.
104106
RUNNER_DEBUG: "1"
105107
with:

‎.github/workflows/mobile-eas-production.yml‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -97,13 +97,13 @@ jobs:
9797
- id: expo-token
9898
name: Check for EXPO_TOKEN
9999
env:
100-
EXPO_TOKEN: ${{ secrets.EXPO_TOKEN }}
100+
EXPO_TOKEN: ${{ secrets.EXPO_PRODUCTION_TOKEN }}
101101
run: |
102102
if [ -n "$EXPO_TOKEN" ]; then
103103
echo "present=true" >> "$GITHUB_OUTPUT"
104104
else
105105
echo "present=false" >> "$GITHUB_OUTPUT"
106-
echo "EXPO_TOKEN is not available; skipping EAS production job."
106+
echo "EXPO_PRODUCTION_TOKEN is not available; skipping EAS production job."
107107
fi
108108
109109
- id: version_app_token
@@ -149,7 +149,7 @@ jobs:
149149
uses: expo/expo-github-action@v8
150150
with:
151151
eas-version: latest
152-
token: ${{ secrets.EXPO_TOKEN }}
152+
token: ${{ secrets.EXPO_PRODUCTION_TOKEN }}
153153
# npm, not pnpm: this only installs eas-cli into the action's own
154154
# tool dir, and pnpm 11 hard-fails that install on dtrace-provider's
155155
# ignored build script (no allowBuilds config outside the repo).
@@ -159,7 +159,7 @@ jobs:
159159
if: steps.expo-token.outputs.present == 'true'
160160
working-directory: apps/mobile
161161
env:
162-
EXPO_TOKEN: ${{ secrets.EXPO_TOKEN }}
162+
EXPO_TOKEN: ${{ secrets.EXPO_PRODUCTION_TOKEN }}
163163
run: |
164164
eas env:pull production --non-interactive
165165
# EAS commands skip dotenv, and the Android fingerprint hashes this
@@ -244,7 +244,7 @@ jobs:
244244
if: steps.expo-token.outputs.present == 'true' && github.event_name == 'workflow_dispatch' && inputs.mode == 'build'
245245
working-directory: apps/mobile
246246
env:
247-
EXPO_TOKEN: ${{ secrets.EXPO_TOKEN }}
247+
EXPO_TOKEN: ${{ secrets.EXPO_PRODUCTION_TOKEN }}
248248
MOBILE_BUILD_PROFILE: ${{ inputs.profile || 'production' }}
249249
run: eas build --platform ${{ inputs.platform }} --profile "$MOBILE_BUILD_PROFILE" --auto-submit --non-interactive --no-wait
250250

@@ -255,7 +255,7 @@ jobs:
255255
if: steps.expo-token.outputs.present == 'true' && (github.event_name == 'push' || inputs.mode == 'update')
256256
working-directory: apps/mobile
257257
env:
258-
EXPO_TOKEN: ${{ secrets.EXPO_TOKEN }}
258+
EXPO_TOKEN: ${{ secrets.EXPO_PRODUCTION_TOKEN }}
259259
PLATFORM: ${{ inputs.platform || 'all' }}
260260
run: |
261261
if [ "$PLATFORM" = "all" ]; then platforms="ios android"; else platforms="$PLATFORM"; fi
@@ -275,7 +275,7 @@ jobs:
275275
if: steps.expo-token.outputs.present == 'true' && github.event_name == 'workflow_dispatch' && inputs.mode == 'update'
276276
working-directory: apps/mobile
277277
env:
278-
EXPO_TOKEN: ${{ secrets.EXPO_TOKEN }}
278+
EXPO_TOKEN: ${{ secrets.EXPO_PRODUCTION_TOKEN }}
279279
MOBILE_BUILD_PROFILE: ${{ inputs.profile || 'production' }}
280280
OTA_MESSAGE: ${{ inputs.message || format('Production OTA ({0})', github.sha) }}
281281
run: |
@@ -299,7 +299,7 @@ jobs:
299299
if: steps.expo-token.outputs.present == 'true' && github.event_name == 'push'
300300
working-directory: apps/mobile
301301
env:
302-
EXPO_TOKEN: ${{ secrets.EXPO_TOKEN }}
302+
EXPO_TOKEN: ${{ secrets.EXPO_PRODUCTION_TOKEN }}
303303
run: |
304304
failed=0
305305
message="$(git log -1 --pretty=%s | head -c 120) ($(git rev-parse --short=9 HEAD))"

‎apps/desktop/src/app/DesktopCliCommand.test.ts‎

Lines changed: 70 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import * as NodeServices from "@effect/platform-node/NodeServices";
22
import { afterEach, beforeEach, expect, it } from "@effect/vitest";
3+
import * as HostProcess from "@t3tools/shared/HostProcess";
34
import * as Effect from "effect/Effect";
45
import * as FileSystem from "effect/FileSystem";
56
import * as Option from "effect/Option";
@@ -135,6 +136,14 @@ it.layer(NodeServices.layer)("DesktopCliCommand", (it) => {
135136
yield* command.uninstall;
136137
expect(yield* fs.readFileString(theirs)).toBe("npm's t3\n");
137138
expect(yield* fs.readLink(path.join(home, "bin", "t3"))).toBe(path.join(home, "gone"));
139+
140+
const launcher = path.join(home, ".t3", "bin", "t3");
141+
yield* fs.writeFileString(launcher, "npm's t3\n");
142+
process.env.PATH = path.dirname(launcher);
143+
expect(yield* command.state).toMatchObject({ onPath: false, shadowedBy: launcher });
144+
expect((yield* Effect.flip(command.install)).message).toContain("Could not set up");
145+
yield* command.uninstall;
146+
expect(yield* fs.readFileString(launcher)).toBe("npm's t3\n");
138147
}).pipe(Effect.scoped),
139148
);
140149

@@ -183,6 +192,67 @@ it.layer(NodeServices.layer)("DesktopCliCommand", (it) => {
183192
}).pipe(Effect.scoped),
184193
);
185194

195+
it.effect.skipIf(HostProcess.Platform.defaultValue() === "win32")(
196+
"skips a t3 directory or a file this user cannot execute",
197+
() =>
198+
Effect.gen(function* () {
199+
const fs = yield* FileSystem.FileSystem;
200+
const path = yield* Path.Path;
201+
const home = yield* fs.makeTempDirectoryScoped();
202+
const folder = path.join(home, "folder");
203+
const plain = path.join(home, "plain");
204+
const shadow = path.join(home, "shadow");
205+
yield* fs.makeDirectory(path.join(folder, "t3"), { recursive: true });
206+
yield* fs.makeDirectory(plain);
207+
yield* fs.writeFileString(path.join(plain, "t3"), "notes\n");
208+
// Root can execute mode 0o601; other users must honor the owner permissions.
209+
yield* fs.chmod(path.join(plain, "t3"), process.getuid?.() === 0 ? 0o600 : 0o601);
210+
yield* fs.makeDirectory(shadow);
211+
yield* fs.writeFileString(path.join(shadow, "t3"), "#!/bin/sh\n", { mode: 0o755 });
212+
process.env.PATH = [folder, plain, shadow, path.join(home, ".local", "bin")].join(":");
213+
214+
const command = yield* commandIn({ home });
215+
expect((yield* command.state).shadowedBy).toBe(path.join(shadow, "t3"));
216+
217+
const error = yield* Effect.flip(command.install);
218+
expect(error.message).toContain(path.join(shadow, "t3"));
219+
220+
yield* fs.remove(shadow, { recursive: true });
221+
expect(yield* command.install).toMatchObject({
222+
onPath: true,
223+
installedPath: path.join(home, ".local", "bin", "t3"),
224+
});
225+
}).pipe(Effect.scoped),
226+
);
227+
228+
it.effect("does not treat its own launcher as another t3 when its folder is first on PATH", () =>
229+
Effect.gen(function* () {
230+
const fs = yield* FileSystem.FileSystem;
231+
const path = yield* Path.Path;
232+
const home = yield* fs.makeTempDirectoryScoped();
233+
const launcher = path.join(home, ".t3", "bin", "t3");
234+
process.env.PATH = [path.dirname(launcher), path.join(home, ".local", "bin")].join(":");
235+
236+
const command = yield* commandIn({ home });
237+
const installed = yield* command.install;
238+
239+
expect(yield* fs.exists(launcher)).toBe(true);
240+
expect(installed).toMatchObject({
241+
onPath: true,
242+
installedPath: path.join(home, ".local", "bin", "t3"),
243+
});
244+
expect(installed.shadowedBy).toBeUndefined();
245+
expect(yield* command.state).toEqual(installed);
246+
247+
const removed = yield* command.uninstall;
248+
expect(removed.installedPath).toBeNull();
249+
expect(removed.onPath).toBe(true);
250+
expect(yield* command.state).toEqual(removed);
251+
expect(yield* fs.exists(installed.installedPath!)).toBe(false);
252+
expect(yield* fs.exists(launcher)).toBe(true);
253+
}).pipe(Effect.scoped),
254+
);
255+
186256
it.effect("leaves the Windows PATH alone when it cannot be read", () =>
187257
Effect.gen(function* () {
188258
const fs = yield* FileSystem.FileSystem;

0 commit comments

Comments
 (0)