Skip to content

Commit ab034ab

Browse files
saphidclaude
authored andcommitted
fix(server): html_preview no longer splits an emoji in a long console line
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 07a1e79 commit ab034ab

2 files changed

Lines changed: 15 additions & 4 deletions

File tree

‎apps/server/src/htmlRender/HtmlRender.test.ts‎

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -350,16 +350,24 @@ fs.createReadStream(null, { fd: 3 }).on("end", quit).on("data", (chunk) => {
350350
for (const { id, method, sessionId } of messages.map((raw) => JSON.parse(raw))) {
351351
if (method === "Browser.close") quit();
352352
reply({ id, sessionId, result: results[method] ?? {} });
353-
if (method === "Page.navigate") reply({ sessionId, method: "Page.loadEventFired", params: {} });
353+
if (method === "Page.navigate") {
354+
const value = "x" + "\u{1F600}".repeat(300);
355+
const params = { type: "log", args: [{ type: "string", value }] };
356+
reply({ sessionId, method: "Runtime.consoleAPICalled", params });
357+
reply({ sessionId, method: "Page.loadEventFired", params: {} });
358+
}
354359
}
355360
});
356361
`,
357362
{ mode: 0o755 },
358363
);
359364

360-
yield* HtmlRender.HtmlRender.use((htmlRender) =>
365+
const preview = yield* HtmlRender.HtmlRender.use((htmlRender) =>
361366
htmlRender.preview({ html: "<p>x</p>" }),
362367
).pipe(Effect.provide(layerHtmlRender(executable)));
368+
const logged = preview.consoleMessages[0]?.text ?? "";
369+
expect(logged.isWellFormed()).toBe(true);
370+
expect(logged).toHaveLength(500);
363371

364372
const exitedBy = yield* fileSystem.readFileString(exitRecord).pipe(Effect.option);
365373
expect(Option.getOrElse(exitedBy, () => "killed by a signal")).toBe("asked to close");

‎apps/server/src/htmlRender/headlessChrome.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -316,10 +316,13 @@ const launchBrowser = Effect.fnUntraced(function* (input: {
316316
return yield* Effect.void;
317317
}
318318
const text = consoleMessage.text.replaceAll(PAGE_URL, PAGE_NAME);
319+
// Half an emoji serializes to a lone surrogate escape, which provider JSON parsers reject.
320+
const last = text.charCodeAt(MAX_CONSOLE_TEXT_CHARS - 1);
321+
const end =
322+
last >= 0xd800 && last <= 0xdbff ? MAX_CONSOLE_TEXT_CHARS - 1 : MAX_CONSOLE_TEXT_CHARS;
319323
page.consoleMessages.push({
320324
level: consoleMessage.level,
321-
text:
322-
text.length > MAX_CONSOLE_TEXT_CHARS ? `${text.slice(0, MAX_CONSOLE_TEXT_CHARS)}…` : text,
325+
text: text.length > MAX_CONSOLE_TEXT_CHARS ? `${text.slice(0, end)}…` : text,
323326
});
324327
return yield* Effect.void;
325328
});

0 commit comments

Comments
 (0)