Skip to content

Commit a977b9e

Browse files
fixfonclaude
andcommitted
fix(antigravity): read usage from each instance data directory
Antigravity usage scans resolved ANTIGRAVITY_DATA_DIR from the host environment only, so an instance configured with its own data directory had its history omitted. Resolve the data roots from each instance's merged environment; the existing canonical directory set still counts shared and aliased roots once. Refs #17631. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent bd2346e commit a977b9e

2 files changed

Lines changed: 45 additions & 5 deletions

File tree

‎apps/server/src/provider/Drivers/AntigravityUsage.ts‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,14 @@ const make = Effect.gen(function* () {
4444
const fileSystem = yield* FileSystem.FileSystem;
4545
const path = yield* Path.Path;
4646
const host = yield* ProviderHost.ProviderHost;
47-
const hostEnvironment = yield* HostProcess.Environment;
4847
const cache = makeAntigravityUsageCache();
4948

50-
/** `ANTIGRAVITY_DATA_DIR` (comma-separated) or the defaults, canonicalized. */
51-
const dataRoots = Effect.gen(function* () {
49+
/** An instance's `ANTIGRAVITY_DATA_DIR` (comma-separated) or the defaults, canonicalized. */
50+
const dataRoots = Effect.fn("AntigravityUsage.dataRoots")(function* (
51+
environment: NodeJS.ProcessEnv,
52+
) {
5253
const home = yield* HostProcess.HomeDirectory;
53-
const configured = hostEnvironment["ANTIGRAVITY_DATA_DIR"]
54+
const configured = environment["ANTIGRAVITY_DATA_DIR"]
5455
?.split(",")
5556
.map((value) => value.trim())
5657
.filter(Boolean);
@@ -74,7 +75,8 @@ const make = Effect.gen(function* () {
7475
instances,
7576
windowStartMs,
7677
}) {
77-
const roots = yield* dataRoots;
78+
const roots: Array<string> = [];
79+
for (const instance of instances) roots.push(...(yield* dataRoots(instance.environment)));
7880
// Only configured instances have a profile; the implicit default never ran.
7981
for (const { instanceId } of instances.filter((instance) => instance.configured)) {
8082
const directories = yield* resolveAntigravityInstanceDirectories(

‎apps/server/src/usage/UsageService.test.ts‎

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -749,6 +749,44 @@ describe("UsageService", () => {
749749
}).pipe(Effect.scoped),
750750
);
751751

752+
it.live("reads Antigravity history from each instance's data directory", () =>
753+
Effect.gen(function* () {
754+
const { settings, home } = yield* setup;
755+
const first = NodePath.join(home, "antigravity-first");
756+
const second = NodePath.join(home, "antigravity-second");
757+
yield* Effect.promise(async () => {
758+
await NodeFSP.mkdir(first);
759+
await NodeFSP.mkdir(second);
760+
});
761+
const instance = (dataDir: string) => ({
762+
driver: ProviderDriverKind.make("antigravity"),
763+
environment: [{ name: "ANTIGRAVITY_DATA_DIR", value: dataDir, sensitive: false }],
764+
});
765+
const service = yield* UsageService.make.pipe(
766+
Effect.provide(
767+
layerService({
768+
prefix: "usage-service-antigravity-instances-test",
769+
home,
770+
settings: {
771+
providerInstances: {
772+
...settings.providerInstances,
773+
[ProviderInstanceId.make("antigravity-first")]: instance(first),
774+
[ProviderInstanceId.make("antigravity-second")]: instance(` ${second}, `),
775+
},
776+
},
777+
}),
778+
),
779+
);
780+
const summary = yield* service.readSummary(WINDOW);
781+
const roots = summary.sources
782+
.filter((source) => source.fingerprint.provider === "antigravity")
783+
.map((source) => source.fingerprint.resolvedHomePath);
784+
for (const dir of [first, second]) {
785+
assert.include(roots, yield* Effect.promise(() => NodeFSP.realpath(dir)));
786+
}
787+
}).pipe(Effect.scoped),
788+
);
789+
752790
it.live("reads configured and disabled accounts once across shared and aliased homes", () =>
753791
Effect.gen(function* () {
754792
const { transcript, settings, home } = yield* setup;

0 commit comments

Comments
 (0)