Repository navigation
Commit a852de0
authored
fix(web): play completion sounds without delay (#29146)
Completion alerts waited two seconds after the client received a completed thread state. Audio was also fetched and decoded only when an alert needed to play, adding a first-play delay.
Notify immediately when the thread shell reports completion, and preload both sounds when a user gesture unlocks audio. Keep completion deduplication and suppression for existing, archived, and stopped runs.
This intentionally removes the continuation grace for completion alerts. A completed run can now notify before an automatic continuation starts. The sidebar's two-second placement grace and server settlement behavior remain in place.
Validation: `vp run check:changed` passes after merging current main, including 40 affected tests, formatting, lint, unused-code checks, affected typechecks, and React compiler checks. Tests cover immediate completion, duplicate suppression across reconnects, preloaded audio reuse, and retrying failed loads on alerts without retrying on every gesture. Audible timing has not been verified in a live client.
Model: GPT 6.1 Sol. Harness: Codex through T3 Code.1 parent d01b92c commit a852de0
7 files changed
Lines changed: 100 additions & 191 deletions
File tree
- apps/web/src
- components
- packages/client-runtime/src/state
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
4 | 3 | | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
9 | | - | |
| 8 | + | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
| |||
241 | 240 | | |
242 | 241 | | |
243 | 242 | | |
244 | | - | |
| 243 | + | |
245 | 244 | | |
| 245 | + | |
246 | 246 | | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | 247 | | |
253 | 248 | | |
254 | | - | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
255 | 252 | | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | 253 | | |
| 254 | + | |
262 | 255 | | |
263 | 256 | | |
264 | 257 | | |
| |||
277 | 270 | | |
278 | 271 | | |
279 | 272 | | |
280 | | - | |
281 | 273 | | |
282 | 274 | | |
283 | 275 | | |
| |||
296 | 288 | | |
297 | 289 | | |
298 | 290 | | |
| 291 | + | |
299 | 292 | | |
300 | 293 | | |
301 | | - | |
302 | 294 | | |
303 | 295 | | |
304 | | - | |
305 | 296 | | |
306 | 297 | | |
307 | | - | |
308 | 298 | | |
| 299 | + | |
309 | 300 | | |
310 | 301 | | |
311 | 302 | | |
312 | 303 | | |
313 | 304 | | |
314 | | - | |
| 305 | + | |
315 | 306 | | |
316 | 307 | | |
317 | 308 | | |
318 | | - | |
319 | 309 | | |
320 | 310 | | |
321 | 311 | | |
322 | 312 | | |
323 | 313 | | |
324 | | - | |
325 | | - | |
| 314 | + | |
326 | 315 | | |
327 | | - | |
328 | | - | |
329 | | - | |
330 | | - | |
| 316 | + | |
331 | 317 | | |
332 | 318 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
| 1 | + | |
3 | 2 | | |
4 | 3 | | |
5 | 4 | | |
| |||
30 | 29 | | |
31 | 30 | | |
32 | 31 | | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
| 32 | + | |
51 | 33 | | |
52 | 34 | | |
53 | 35 | | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | 36 | | |
58 | 37 | | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | 38 | | |
66 | 39 | | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
| 40 | + | |
75 | 41 | | |
76 | 42 | | |
77 | | - | |
| 43 | + | |
78 | 44 | | |
79 | 45 | | |
80 | 46 | | |
81 | | - | |
82 | 47 | | |
83 | | - | |
84 | 48 | | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
91 | 55 | | |
92 | 56 | | |
93 | | - | |
| 57 | + | |
94 | 58 | | |
95 | 59 | | |
96 | | - | |
97 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
98 | 65 | | |
99 | | - | |
100 | | - | |
101 | 66 | | |
102 | | - | |
103 | | - | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
104 | 71 | | |
105 | 72 | | |
106 | | - | |
| 73 | + | |
107 | 74 | | |
108 | 75 | | |
109 | 76 | | |
110 | | - | |
111 | 77 | | |
112 | 78 | | |
113 | | - | |
114 | 79 | | |
115 | 80 | | |
116 | 81 | | |
117 | 82 | | |
118 | 83 | | |
119 | 84 | | |
120 | | - | |
| 85 | + | |
121 | 86 | | |
122 | | - | |
123 | 87 | | |
124 | | - | |
125 | | - | |
126 | 88 | | |
| 89 | + | |
127 | 90 | | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | 91 | | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
150 | 95 | | |
151 | | - | |
152 | | - | |
| 96 | + | |
153 | 97 | | |
154 | 98 | | |
155 | 99 | | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
175 | 104 | | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
182 | 111 | | |
183 | 112 | | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | 113 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | 1 | | |
4 | 2 | | |
5 | 3 | | |
| |||
11 | 9 | | |
12 | 10 | | |
13 | 11 | | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | 12 | | |
20 | 13 | | |
21 | 14 | | |
22 | | - | |
23 | 15 | | |
24 | 16 | | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | 17 | | |
32 | 18 | | |
33 | 19 | | |
| |||
38 | 24 | | |
39 | 25 | | |
40 | 26 | | |
41 | | - | |
42 | | - | |
43 | 27 | | |
44 | 28 | | |
45 | 29 | | |
46 | 30 | | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | 31 | | |
51 | 32 | | |
52 | 33 | | |
53 | 34 | | |
54 | 35 | | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
| 36 | + | |
| 37 | + | |
65 | 38 | | |
66 | 39 | | |
67 | 40 | | |
68 | | - | |
69 | 41 | | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | 42 | | |
75 | 43 | | |
76 | | - | |
77 | 44 | | |
78 | | - | |
79 | 45 | | |
80 | 46 | | |
81 | 47 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
114 | | - | |
115 | 114 | | |
116 | 115 | | |
117 | 116 | | |
| |||
308 | 307 | | |
309 | 308 | | |
310 | 309 | | |
311 | | - | |
312 | 310 | | |
313 | 311 | | |
314 | 312 | | |
| |||
0 commit comments