Skip to content

Commit a73a2ce

Browse files
Leave empty webhook values unframed
An empty request value carries no data, so it no longer gets a frame or the untrusted-data note. A template of only {{body}} with an empty body renders empty again, as before framing. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent b9cc023 commit a73a2ce

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

‎apps/server/src/scheduledTasks/webhookTemplate.test.ts‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,12 @@ describe("renderWebhookPrompt", () => {
114114
assert.deepEqual(rendered.missing, ["body.nope", "headers.x-missing", "unknown"]);
115115
});
116116

117+
it("leaves empty values unframed and does not report them missing", () => {
118+
const rendered = renderWebhookPrompt("{{body}}", { ...githubPullRequest, bodyText: "" }, "id");
119+
assert.equal(rendered.prompt, "");
120+
assert.deepEqual(rendered.missing, []);
121+
});
122+
117123
it("trims placeholder whitespace before resolving and reporting missing fields", () => {
118124
const rendered = renderWebhookPrompt(
119125
"{{\tbody.action\n}}|{{ body.nope }}|{{\nbody.nope\t}}|{{ \t\n }}",

‎apps/server/src/scheduledTasks/webhookTemplate.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,11 @@ export function renderWebhookPrompt(
151151
if (!missing.includes(expression)) missing.push(expression);
152152
return "";
153153
}
154+
const text = stringify(value);
155+
// An empty value carries no request data, so it needs no frame or note.
156+
if (text === "") return "";
154157
framed = true;
155-
return `<${tag}>${stringify(value).replace(MENTION, "$&\u2060")}</${tag}>`;
158+
return `<${tag}>${text.replace(MENTION, "$&\u2060")}</${tag}>`;
156159
});
157160
if (!framed) return { prompt, missing };
158161
return {

0 commit comments

Comments
 (0)