Skip to content

Commit a5d7321

Browse files
chore(lint): enforce unnecessaryFailYieldableError
1 parent 664f485 commit a5d7321

10 files changed

Lines changed: 36 additions & 49 deletions

File tree

‎apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1511,12 +1511,10 @@ describe("ClaudeAdapterV2 attachments", () => {
15111511
Effect.gen(function* () {
15121512
if (failOpen) {
15131513
failOpen = false;
1514-
return yield* Effect.fail(
1515-
new ClaudeAdapterV2.ClaudeAgentSdkQueryRunnerError({
1516-
method: "open",
1517-
cause: "rejected open",
1518-
}),
1519-
);
1514+
return yield* new ClaudeAdapterV2.ClaudeAgentSdkQueryRunnerError({
1515+
method: "open",
1516+
cause: "rejected open",
1517+
});
15201518
}
15211519
const messages = yield* Queue.unbounded<SDKMessage>();
15221520
return {

‎apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7175,7 +7175,7 @@ export const makeCodexAdapterV2 = Effect.fn("makeCodexAdapterV2")(function* (
71757175
const terminationResults = yield* terminateTrackedTerminals(interruptTargets);
71767176
const failedTermination = terminationResults.find((result) => !result.success);
71777177
if (failedTermination !== undefined && !failedTermination.success) {
7178-
return yield* Effect.fail(failedTermination.error);
7178+
return yield* failedTermination.error;
71797179
}
71807180
yield* turnTerminalizationPermit.withPermits(1)(
71817181
Effect.gen(function* () {

‎apps/server/src/orchestration-v2/ThreadManagementService.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1195,7 +1195,7 @@ const make = Effect.gen(function* () {
11951195
),
11961196
);
11971197
}
1198-
if (failures[0] !== undefined) return yield* Effect.fail(failures[0]);
1198+
if (failures[0] !== undefined) return yield* failures[0];
11991199
});
12001200

12011201
return ThreadManagementService.of({

‎apps/server/src/provider/ProviderAuthService.test.ts‎

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -281,13 +281,11 @@ const makeHarness = Effect.fn("ProviderAuthService.test.makeHarness")(function*
281281
actions.push(`stop:${providerSessionId}`);
282282
yield* input.beforeStop ?? Effect.void;
283283
if (input.stopError) {
284-
return yield* Effect.fail(
285-
new ProviderSessionManager.ProviderSessionReleaseError({
286-
providerSessionId,
287-
reason,
288-
cause: new Error("private process diagnostics"),
289-
}),
290-
);
284+
return yield* new ProviderSessionManager.ProviderSessionReleaseError({
285+
providerSessionId,
286+
reason,
287+
cause: new Error("private process diagnostics"),
288+
});
291289
}
292290
released.push(providerSessionId);
293291
for (const [threadId, list] of sessions) {

‎apps/server/src/storageCleanup.ts‎

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -692,14 +692,12 @@ const make = Effect.gen(function* () {
692692
timeoutMs: 300_000,
693693
});
694694
if (result.exitCode !== 0)
695-
return yield* Effect.fail(
696-
new GitCommandError({
697-
operation: "StorageCleanup.cleanupGit",
698-
command,
699-
cwd,
700-
detail: result.stderr.trim().split(/\r?\n/)[0]?.slice(0, 1000) || "command failed",
701-
}),
702-
);
695+
return yield* new GitCommandError({
696+
operation: "StorageCleanup.cleanupGit",
697+
command,
698+
cwd,
699+
detail: result.stderr.trim().split(/\r?\n/)[0]?.slice(0, 1000) || "command failed",
700+
});
703701
});
704702

705703
const cleanWorktrees = Effect.fn("StorageCleanup.cleanWorktrees")(function* (

‎apps/server/src/ws.ts‎

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2430,29 +2430,23 @@ export const layerWsRpc = (
24302430
) ?? projection.providerThreads.at(-1);
24312431
const providerSessionId = providerThread?.providerSessionId ?? null;
24322432
if (providerThread === undefined || providerSessionId === null) {
2433-
return yield* Effect.fail(
2434-
new ProviderUploadFeedbackError({
2435-
threadId: input.threadId,
2436-
cause: "No provider session has run in this thread yet.",
2437-
}),
2438-
);
2433+
return yield* new ProviderUploadFeedbackError({
2434+
threadId: input.threadId,
2435+
cause: "No provider session has run in this thread yet.",
2436+
});
24392437
}
24402438
const runtime = Option.getOrNull(yield* providerSessionsV2.get(providerSessionId));
24412439
if (runtime === null) {
2442-
return yield* Effect.fail(
2443-
new ProviderUploadFeedbackError({
2444-
threadId: input.threadId,
2445-
cause: "The provider session is no longer running. Send a message first.",
2446-
}),
2447-
);
2440+
return yield* new ProviderUploadFeedbackError({
2441+
threadId: input.threadId,
2442+
cause: "The provider session is no longer running. Send a message first.",
2443+
});
24482444
}
24492445
if (runtime.uploadFeedback === undefined) {
2450-
return yield* Effect.fail(
2451-
new ProviderUploadFeedbackError({
2452-
threadId: input.threadId,
2453-
cause: `Provider '${runtime.driver}' does not support feedback uploads.`,
2454-
}),
2455-
);
2446+
return yield* new ProviderUploadFeedbackError({
2447+
threadId: input.threadId,
2448+
cause: `Provider '${runtime.driver}' does not support feedback uploads.`,
2449+
});
24562450
}
24572451
return yield* runtime.uploadFeedback({
24582452
providerThread,

‎packages/client-runtime/src/state/commandPermissions.ts‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,10 @@ function makeCommandPermissions<R, E>(
5959
(scope) => Option.isNone(session) || !sessionGrantsScope(session.value, scope),
6060
);
6161
if (missing !== undefined)
62-
return yield* Effect.fail(
63-
new EnvironmentAuthorizationError({
64-
...authScopeRequiredResponse(missing),
65-
message: `This connection requires ${missing}.`,
66-
}),
67-
);
62+
return yield* new EnvironmentAuthorizationError({
63+
...authScopeRequiredResponse(missing),
64+
message: `This connection requires ${missing}.`,
65+
});
6866
}),
6967
);
7068
});

‎packages/provider-opencode/src/server/adapter.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1061,7 +1061,7 @@ export const makeOpenCodeAdapterV2 = Effect.fn("makeOpenCodeAdapterV2")(function
10611061
return firstFailure ?? failures.find((failure) => failure !== undefined);
10621062
});
10631063
const failure = yield* visit(rootId, false);
1064-
if (failure) return yield* Effect.fail(failure);
1064+
if (failure) return yield* failure;
10651065
}, Effect.timeout("15 seconds"));
10661066

10671067
const updateProviderSession =

‎packages/source-control-github/src/server/gitHubGraphQlClient.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ const refused = Effect.fn("gitHubGraphQlClient.refused")(function* (
103103
) {
104104
const reason = error.reason;
105105
if (reason._tag !== "TransportError" && reason._tag !== "ResponseError") {
106-
return yield* Effect.fail(error);
106+
return yield* error;
107107
}
108108
const status = reason.status;
109109
if (reason._tag === "TransportError" && status === undefined) {

‎tsconfig.base.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
"namespaceImportPackages": ["@effect/platform-node", "effect"],
2525
"effectFn": ["span", "inferred-span", "suggested-span"],
2626
"diagnosticSeverity": {
27+
"unnecessaryFailYieldableError": "error",
2728
"preferSucceedSomeOrNone": "error",
2829
"effectSucceedWithVoid": "error",
2930
"provideLayerSucceedToProvideService": "error",

0 commit comments

Comments
 (0)